Skip to contentSkip to conversation

dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names

PATCH Applied Rob Herring 2 participants 3 messages Jan 20, 2023 – Jan 23, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names

The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the socionext,uniphier-soc-glue binding are not patterns, but the full node name, so move them to 'properties'. As patterns, they were missing start and end anchors so any prefix or suffix was allowed.

Fixes 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
---
 .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml +0 -1
index 4b6852db4747..7845dcfca986 100644
@@ -32,7 +32,6 @@ properties:
   reg:
     maxItems: 1
 
-patternProperties:
   pinctrl:
     $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
 
Signature · 1 line
2.39.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Rob,

Quoted 25 lines · Rob Herring

The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the socionext,uniphier-soc-glue binding are not patterns, but the full node name, so move them to 'properties'. As patterns, they were missing start and end anchors so any prefix or suffix was allowed.

Fixes 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue

logic")

---
  .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
  1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g lue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g lue.yaml
index 4b6852db4747..7845dcfca986 100644
---
a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g lue.yaml
+++
b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g lue.yaml

Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml properties: · line 37

Quoted 7 lines
Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml +0 -1
@@ -32,7 +32,6 @@ properties:
    reg:
      maxItems: 1
 
-patternProperties:
    pinctrl:
      $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
 

Thanks for pointing out.
This is because I forgot to remove it when I changed the child node, and it should be removed.

Thank you,

---
Best Regards
Kunihiko Hayashi

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the socionext,uniphier-soc-glue binding are not patterns, but the full node name, so move them to 'properties'. As patterns, they were missing start and end anchors so any prefix or suffix was allowed.

Fixes 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
---
 .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks!