DP2.0 SDP CRC16 for 128/132b link layer
Subsystems (3)
v2 cover DP2.0 SDP CRC16 for 128/132b link layer
*** BLURB HERE ***
Arun R Murthy (2):
drm: Add SDP Error Detection Configuration Register i915/display/dp: SDP CRC16 for 128b132b link layer
.../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ include/drm/display/drm_dp.h | 3 +++ 2 files changed, 15 insertions(+)
Signature · 1 line
2.25.1
PATCH RESEND v2 1/2 drm: Add SDP Error Detection Configuration Register
DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device.
v2: Update the macro name to reflect the DP spec(Harry)
--- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+)
include/drm/display/drm_dp.h +3 -0
@@ -692,6 +692,9 @@# define DP_FEC_LANE_2_SELECT (2 << 4)# define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION_CONFIGURATION 0x121/* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) +#define DP_AUX_FRAME_SYNC_VALUE 0x15c/* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0)
Signature · 1 line
2.25.1
PATCH RESEND v2 2/2 i915/display/dp: SDP CRC16 for 128b132b link layer
In reply to Arun R MurthyEnable SDP error detection configuration, this will set CRC16 in 128b/132b link layer.
For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write.
Corrective actions on SDP corruption is yet to be defined.
v2: Moved the CRC enable to link training init(Jani N)
--- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +12 -0
@@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,if (!passed)intel_dp_schedule_fallback_link_training (intel_dp, crtc_state); + +/* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ +if (intel_dp_is_uhbr (crtc_state) && passed) +drm_dp_dpcd_writeb (&intel_dp->aux, +DP_SDP_ERROR_DETECTION_CONFIGURATION , +DP_SDP_CRC16_128B132B_EN ); +/* +* VIDEO_DIP_CTL register bit 31 should be set to '0' to not +* disable SDP CRC. This is applicable for Display version 13. +* Default value of bit 31 is '0' hence discarding the write +*/ +/* TODO: Corrective actions on SDP corruption yet to be defined */ }
Signature · 1 line
2.25.1
Re: [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer
Quoted 9 lines · Arun R Murthy
Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer.
For Display version 13 a hardware bit31 in registerVIDEO_DIP_CTLis added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write.
Corrective actions on SDP corruption is yet to be defined.v2: Moved the CRC enable to link training init(Jani N)
Yeah, well, I said where this doesn't belong, and I don't think it really belongs here either. :(
It has nothing to do with link training or intel_dp_start_link_train().
Alas, I'm not really sure what the right place is, I just know this isn't it. The specs don't give us any clues. The DP specs says absolutely nothing about when this could or should be written.
*Maybe* in intel_ddi_pre_enable() or intel_mst_pre_enable_dp()? Before sending any SDPs.
BR,
Jani.
Quoted 27 lines
Signed-off-by Arun R Murthy <[email protected]>--- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_dp_link_training.c +12
-0@@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,if (!passed)intel_dp_schedule_fallback_link_training (intel_dp, crtc_state); + +/* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ +if (intel_dp_is_uhbr (crtc_state) && passed) +drm_dp_dpcd_writeb (&intel_dp->aux, +DP_SDP_ERROR_DETECTION_CONFIGURATION , +DP_SDP_CRC16_128B132B_EN ); +/* +* VIDEO_DIP_CTL register bit 31 should be set to '0' to not +* disable SDP CRC. This is applicable for Display version 13. +* Default value of bit 31 is '0' hence discarding the write +*/ +/* TODO: Corrective actions on SDP corruption yet to be defined */ }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DP2.0 SDP CRC16 for 128/132b link layer
In reply to Arun R Murthy== Series Details ==
== Series Details ==
Series: DP2.0 SDP CRC16 for 128/132b link layer
URL : https://patchwork.freedesktop.org/series/113134/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for DP2.0 SDP CRC16 for 128/132b link layer
In reply to Arun R Murthy== Series Details ==
== Series Details ==
Series: DP2.0 SDP CRC16 for 128/132b link layer
URL : https://patchwork.freedesktop.org/series/113134/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12615 -> Patchwork_113134v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_113134v1 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_113134v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/index.html
Participating hosts (37 -> 31)
------------------------------
Missing (6): fi-rkl-11600 bat-dg1-6 bat-dg2-9 fi-snb-2520m bat-rpls-2 fi-skl-6600u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113134v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12615/fi-bsw-nick/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/fi-bsw-nick/igt@i915_selftest@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@hugepages:
- {bat-dg2-11}: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12615/bat-dg2-11/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/bat-dg2-11/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113134v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][5] -> [FAIL][6] ([i915#7229])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12615/fi-pnv-d510/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/fi-pnv-d510/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12615/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][9] ([i915#7699]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12615/bat-dg2-11/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/bat-dg2-11/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
Build changes
-------------
* Linux: CI_DRM_12615 -> Patchwork_113134v1
CI-20190529: 20190529
CI_DRM_12615: 8692eb28d41136537cd24aaf78f4621ddddbfb3a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7126: 3aa9364a1e478010aba0d3dfe9183486560ecc60 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113134v1: 8692eb28d41136537cd24aaf78f4621ddddbfb3a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1ec8f0a24447 i915/display/dp: SDP CRC16 for 128b132b link layer 475728c2697f drm: Add SDP Error Detection Configuration Register
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113134v1/index.html
v3 cover DP2.0 SDP CRC16 for 128/132b link layer
In reply to Arun R Murthy*** BLURB HERE ***
Arun R Murthy (2):
drm: Add SDP Error Detection Configuration Register i915/display/dp: SDP CRC16 for 128b132b link layer
.../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ include/drm/display/drm_dp.h | 3 +++ 2 files changed, 15 insertions(+)
Signature · 1 line
2.25.1
PATCH v2 1/2 drm: Add SDP Error Detection Configuration Register
DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device.
v2: Update the macro name to reflect the DP spec(Harry)
--- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+)
include/drm/display/drm_dp.h +3 -0
@@ -692,6 +692,9 @@# define DP_FEC_LANE_2_SELECT (2 << 4)# define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION_CONFIGURATION 0x121/* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) +#define DP_AUX_FRAME_SYNC_VALUE 0x15c/* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0)
Signature · 1 line
2.25.1
PATCH v3 2/2 i915/display/dp: SDP CRC16 for 128b132b link layer
In reply to Arun R MurthyEnable SDP error detection configuration, this will set CRC16 in 128b/132b link layer.
For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write.
Corrective actions on SDP corruption is yet to be defined.
v2: Moved the CRC enable to link training init(Jani N)
v3: Moved crc enable to ddi pre enable <Jani N>
--- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/i915/display/intel_dp_link_training.c +12 -0
@@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,if (!passed)intel_dp_schedule_fallback_link_training (intel_dp, crtc_state); + +/* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ +if (intel_dp_is_uhbr (crtc_state) && passed) +drm_dp_dpcd_writeb (&intel_dp->aux, +DP_SDP_ERROR_DETECTION_CONFIGURATION , +DP_SDP_CRC16_128B132B_EN ); +/* +* VIDEO_DIP_CTL register bit 31 should be set to '0' to not +* disable SDP CRC. This is applicable for Display version 13. +* Default value of bit 31 is '0' hence discarding the write +*/ +/* TODO: Corrective actions on SDP corruption yet to be defined */ }
Signature · 1 line
2.25.1
Re: [PATCHv3 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer
Quoted 10 lines · Arun R Murthy
Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer.
For Display version 13 a hardware bit31 in registerVIDEO_DIP_CTLis added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write.
Corrective actions on SDP corruption is yet to be defined.v2: Moved the CRC enable to link training init(Jani N)
v3: Moved crc enable to ddi pre enable <Jani N>
It's still in intel_dp_start_link_train()...?
BR,
Jani.
Quoted 27 lines
Signed-off-by Arun R Murthy <[email protected]>--- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_dp_link_training.c +12
-0@@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,if (!passed)intel_dp_schedule_fallback_link_training (intel_dp, crtc_state); + +/* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ +if (intel_dp_is_uhbr (crtc_state) && passed) +drm_dp_dpcd_writeb (&intel_dp->aux, +DP_SDP_ERROR_DETECTION_CONFIGURATION , +DP_SDP_CRC16_128B132B_EN ); +/* +* VIDEO_DIP_CTL register bit 31 should be set to '0' to not +* disable SDP CRC. This is applicable for Display version 13. +* Default value of bit 31 is '0' hence discarding the write +*/ +/* TODO: Corrective actions on SDP corruption yet to be defined */ }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [PATCHv3 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer
Quoted 9 lines · Jani Nikula
Quoted 8 lines · Arun R Murthy
Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer.
For Display version 13 a hardware bit31 in registerVIDEO_DIP_CTLis added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write.
Corrective actions on SDP corruption is yet to be defined.
Quoted 4 lines
Quoted 2 lines
v2: Moved the CRC enable to link training init(Jani N)
v3: Moved crc enable to ddi pre enable <Jani N>It's still in
intel_dp_start_link_train()...?
Also, please post new versions as new threads instead of in-reply-to. I don't think patchwork/CI picked this up at all, for example.
BR,
Jani
Quoted 32 lines
BR,
Jani.Quoted 27 lines
Signed-off-by Arun R Murthy <[email protected]>--- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_dp_link_training.c +12
-0@@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp,if (!passed)intel_dp_schedule_fallback_link_training (intel_dp, crtc_state); + +/* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ +if (intel_dp_is_uhbr (crtc_state) && passed) +drm_dp_dpcd_writeb (&intel_dp->aux, +DP_SDP_ERROR_DETECTION_CONFIGURATION , +DP_SDP_CRC16_128B132B_EN ); +/* +* VIDEO_DIP_CTL register bit 31 should be set to '0' to not +* disable SDP CRC. This is applicable for Display version 13. +* Default value of bit 31 is '0' hence discarding the write +*/ +/* TODO: Corrective actions on SDP corruption yet to be defined */ }
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center