Skip to contentSkip to conversation

selftests: iommu: Fix test_cmd_destroy_access() call in user_copy

PATCH In review Nicolin Chen 3 participants 3 messages Jan 20, 2023 – Jan 23, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: iommu: Fix test_cmd_destroy_access() call in user_copy

The test_cmd_destroy_access() should end with a semicolon, so add one. There is a test_ioctl_destroy(ioas_id) following already, so drop one.

Fixes 57f0988706fe ("iommufd: Add a selftest")
---
 tools/testing/selftests/iommu/iommufd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/iommu/iommufd.c +1 -1
index 8aa8a346cf22..fa08209268c4 100644
@@ -1259,7 +1259,7 @@ TEST_F(iommufd_mock_domain, user_copy)
 
 	test_cmd_destroy_access_pages(
 		access_cmd.id, access_cmd.access_pages.out_access_pages_id);
-	test_cmd_destroy_access(access_cmd.id) test_ioctl_destroy(ioas_id);
+	test_cmd_destroy_access(access_cmd.id);
 
 	test_ioctl_destroy(ioas_id);
 }
Signature · 1 line
2.39.0
maintainer
#2 lore raw
In reply to Nicolin Chen
Quoted 8 lines · Nicolin Chen

The test_cmd_destroy_access() should end with a semicolon, so add one. There is a test_ioctl_destroy(ioas_id) following already, so drop one.

Fixes 57f0988706fe ("iommufd: Add a selftest")
---
 tools/testing/selftests/iommu/iommufd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied thanks

Jason