Skip to contentSkip to conversation

dt-bindings: pinctrl: qcom,pmic-mpp: Rename "mpp" child node names to "-pins$"

PATCH Applied Rob Herring 3 participants 4 messages Jan 20, 2023 – Jan 27, 2023

Subsystems (6)
Device tree bindings Arm Qualcomm mailing list GPIO Pin control +2 more subsystems
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: pinctrl: qcom,pmic-mpp: Rename "mpp" child node names to "-pins$"

Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or suffix. Change the node name pattern to "-pins$" to align with other Qualcomm pinctrl bindings.

Signed-off-by Rob Herring <[email protected]>

---
v2:
- Use "-pins$" for pattern instead

---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml +2 -2
index 72cce38bc1ce..9412b9362328 100644
@@ -74,7 +74,7 @@ patternProperties:
     oneOf:
       - $ref: "#/$defs/qcom-pmic-mpp-state"
       - patternProperties:
-          "mpp":
+          '-pins$':
             $ref: "#/$defs/qcom-pmic-mpp-state"
         additionalProperties: false
 

@@ -179,7 +179,7 @@ examples:
       };
 
       default-state {
-        gpio-mpp {
+        gpio-pins {
           pins = "mpp1", "mpp2", "mpp3", "mpp4";
           function = "digital";
           input-enable;
Signature · 1 line
2.39.0
Applied
#2 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or suffix. Change the node name pattern to "-pins$" to align with other Qualcomm pinctrl bindings.

Or instead of review let me grab it for Linus:

Applied, thanks!

[1/1] dt-bindings: pinctrl: qcom,pmic-mpp: Rename "mpp" child node names to "-pins$"

      https://git.kernel.org/krzk/linux-dt/c/5682f23bd3daf8d66f0a4c0fa0e5645b324e7014

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
#3 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 5 lines · Rob Herring

Just 'mpp' is a bit ambiguous for a pattern as it allows any prefix or suffix. Change the node name pattern to "-pins$" to align with other Qualcomm pinctrl bindings.

Or instead of review let me grab it for Linus:

Applied, thanks!

Thanks Krzysztof!

Linus