Skip to contentSkip to conversation

hwmon: (asus-ec-sensors) add missing mutex path

PATCH Applied Eugene Shalygin 2 participants 3 messages Jan 21, 2023 – Jan 24, 2023

Subsystems (2)
lore
Share & tools
lore

Eugene Shalygin

author maintainer
#0 lore raw

cover hwmon: (asus-ec-sensors) add missing mutex path

The board definition for ProArt X570-CREATOR WIFI misses the mutex path, and because ofthe the driver can not be loaded:

asus-ec-sensors asus-ec-sensors: Hardware access guard mutex name is empty asus-ec-sensors asus-ec-sensors: Failed to setup state/EC locking: -22
asus-ec-sensors: probe of asus-ec-sensors failed with error -22

The issue was pointed out in a comment at GitHub [1]

[1] https://github.com/zeule/asus-ec-sensors/issues/17#issuecomment-1399174059

Eugene Shalygin (1):
hwmon: (asus-ec-sensors) add missing mutex path

 drivers/hwmon/asus-ec-sensors.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.39.0
author maintainer
#1 lore raw

PATCH 1/1 hwmon: (asus-ec-sensors) add missing mutex path

Add missing mutex path for ProArt X570-CREATOR WIFI.

Fixes de8fbac5 (hwmon: (asus-ec-sensors) implement locking via the ACPI global lock)
---
 drivers/hwmon/asus-ec-sensors.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/asus-ec-sensors.c +1 -0
index a901e4e33d81..b4d65916b3c0 100644
@@ -299,6 +299,7 @@ static const struct ec_board_info board_info_pro_art_x570_creator_wifi = {
 	.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | SENSOR_TEMP_VRM |
 		SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
 		SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE,
+	.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
 	.family = family_amd_500_series,
 };
 
Signature · 1 line
2.39.0
maintainer Applied
#2 lore raw
Quoted 4 lines · Eugene Shalygin

Add missing mutex path for ProArt X570-CREATOR WIFI.

Fixes de8fbac5 (hwmon: (asus-ec-sensors) implement locking via the ACPI global lock)

Applied.

The abbreviated SHA in Fixes: tags should include 12 SHA letters/digits. I fixed that up, but please keep it in mind for future patches.

Thanks,
Guenter

Quoted 16 lines
---
 drivers/hwmon/asus-ec-sensors.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/asus-ec-sensors.c +1 -0
index a901e4e33d81..b4d65916b3c0 100644
@@ -299,6 +299,7 @@ static const struct ec_board_info board_info_pro_art_x570_creator_wifi = {
 	.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | SENSOR_TEMP_VRM |
 		SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
 		SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE,
+	.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
 	.family = family_amd_500_series,
 };