Skip to contentSkip to conversation

dt-bindings: iio: dac: Maxim max5522 DAC

PATCH In review Jonathan Cameron 3 participants 5 messages Jan 15, 2023 – Jan 23, 2023

Subsystems (2)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: iio: dac: Maxim max5522 DAC

From: Jonathan Cameron <[email protected]>

Add binding Doc for this SPI DAC.

The driver was perviously posted but was missing the DT binding document.
https://lore.kernel.org/all/[email protected]/

Cc Angelo Dureghello <[email protected]>

---

As it has been a few months and I don't want to end up not taking the driver simply because it lacked this simple binding doc, I've written one.

 .../bindings/iio/dac/maxim,max5522.yaml       | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml new file +49 -0
new file mode 100644
index 000000000000..24830f56c501
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs
+
+maintainers:
+  - Angelo Dureghello <[email protected]>
+  - Jonathan Cameron <[email protected]>
+
+description: |
+  Datasheet available at:
+  https://www.analog.com/en/products/max5522.html
+
+properties:
+  compatible:
+    const: maxim,max5522
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+  vrefin-supply: true
+
+required:
+  - compatible
+  - reg
+  - vrefin-supply
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dac@0 {
+            compatible = "maxim,max5522";
+            reg = <0>;
+            vrefin-supply = <&vref>;
+        };
+    };
+...
Signature · 1 line
2.39.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jonathan Cameron

Hi Jonathan,

thanks a lot, and sorry, looks like i forgot this out.

Quoted 75 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Add binding Doc for this SPI DAC.

The driver was perviously posted but was missing the DT binding document.
https://lore.kernel.org/all/[email protected]/

Cc Angelo Dureghello <[email protected]>

---

As it has been a few months and I don't want to end up not taking the driver simply because it lacked this simple binding doc, I've written one.

 .../bindings/iio/dac/maxim,max5522.yaml       | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml new file +49 -1
new file mode 100644
index 000000000000..24830f56c501
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs
+
+maintainers:
+  - Angelo Dureghello <[email protected]>
+  - Jonathan Cameron <[email protected]>
+
+description: |
+  Datasheet available at:
+  https://www.analog.com/en/products/max5522.html
+
+properties:
+  compatible:
+    const: maxim,max5522
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+  vrefin-supply: true
+
+required:
+  - compatible
+  - reg
+  - vrefin-supply
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dac@0 {
+            compatible = "maxim,max5522";
+            reg = <0>;
+            vrefin-supply = <&vref>;
+        };
+    };
+...
--
Quoted 2 lines

2.39.0

--
Angelo Dureghello
Timesys
e. [email protected]

author maintainer
#3 lore raw
Quoted 3 lines · On Mon, 16 Jan 2023 23:46:35 +0100 Angelo Dureghello…

Hi Jonathan,

thanks a lot, and sorry, looks like i forgot this out.

No problem!

Quoted 2 lines

Applied the driver an this binding doc to the togreg branch of iio.git which will initially get pushed out as testing for 0-day to see if it can find anything we missed.

Thanks,

Jonathan

Quoted 86 lines · Jonathan Cameron
Quoted 75 lines

From: Jonathan Cameron <[email protected]>

Add binding Doc for this SPI DAC.

The driver was perviously posted but was missing the DT binding document.
https://lore.kernel.org/all/[email protected]/

Cc Angelo Dureghello <[email protected]>

---

As it has been a few months and I don't want to end up not taking the driver simply because it lacked this simple binding doc, I've written one.

 .../bindings/iio/dac/maxim,max5522.yaml       | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml new file +49 -1
new file mode 100644
index 000000000000..24830f56c501
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs
+
+maintainers:
+  - Angelo Dureghello <[email protected]>
+  - Jonathan Cameron <[email protected]>
+
+description: |
+  Datasheet available at:
+  https://www.analog.com/en/products/max5522.html
+
+properties:
+  compatible:
+    const: maxim,max5522
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+  vrefin-supply: true
+
+required:
+  - compatible
+  - reg
+  - vrefin-supply
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dac@0 {
+            compatible = "maxim,max5522";
+            reg = <0>;
+            vrefin-supply = <&vref>;
+        };
+    };
+...
--
Quoted 2 lines

2.39.0

--
Angelo Dureghello
Timesys
e. [email protected]

#4 lore raw

Hi Jonathan,

Quoted 9 lines · Jonathan Cameron
Quoted 3 lines · On Mon, 16 Jan 2023 23:46:35 +0100 Angelo Dureghello…

Hi Jonathan,

thanks a lot, and sorry, looks like i forgot this out.

No problem!

Quoted 1 line
Quoted 8 lines
Quoted 1 line

Applied the driver an this binding doc to the togreg branch of iio.git which will initially get pushed out as testing for 0-day to see if it can find anything we missed.

Thanks,

Jonathan

Great, thanks !

Signature · 3 lines
Angelo Dureghello
Timesys
e. [email protected]