Skip to contentSkip to conversation

Correct inaccuracies in Exynos5420 and Exynos5800 device trees

PATCH Applied Markuss Broks 1 participant 3 messages Jan 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Correct inaccuracies in Exynos5420 and Exynos5800 device trees

Use the proper compatibles for the DSI host controller and MIPI video phy, as the current ones are not compatible with the hardware.

While this fixes the kernel panic while trying to use DSI, I was still unsuccessful to consistently produce image that isn't noise on S6E3FA2 panel of Samsung Galaxy S5. It seems to only work sometimes.

Cc Mark Brown <[email protected]>

v1 -> v2:
- squash patch 1 and patch 3, making it one patch for adding the label and changing the compatible
- use better subject prefixes

Markuss Broks (2):
arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy
arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller

 arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
 arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.39.0
#1 lore raw

PATCH 1/2 arm: dts: exynos5420: Use Exynos5420 compatible for the MIPI video phy

For some reason, the driver adding support for Exynos5420 MIPI phy back in 2016 wasn't used on Exynos5420, which caused a kernel panic. Add the proper compatible for it.

---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index 9f2523a873d9..62263eb91b3c 100644
@@ -592,7 +592,7 @@ dp_phy: dp-video-phy {
 		};
 
 		mipi_phy: mipi-video-phy {
-			compatible = "samsung,s5pv210-mipi-video-phy";
+			compatible = "samsung,exynos5420-mipi-video-phy";
 			syscon = <&pmu_system_controller>;
 			#phy-cells = <1>;
 		};
Signature · 1 line
2.39.0
#2 lore raw

PATCH 2/2 arm: dts: exynos5800: Use Exynos5422 compatible for the DSI controller

In reply to Markuss Broks

The driver adding support for Exynos5422/Exynos5800 DSI controller was merged in 2016, yet it wasn't actually used. Add a proper compatible for it.

---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 arch/arm/boot/dts/exynos5800.dtsi | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index 62263eb91b3c..b612468515eb 100644
@@ -597,7 +597,7 @@ mipi_phy: mipi-video-phy {
 			#phy-cells = <1>;
 		};
 
-		dsi@14500000 {
+		dsi: dsi@14500000 {
 			compatible = "samsung,exynos5410-mipi-dsi";
 			reg = <0x14500000 0x10000>;
 			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/exynos5800.dtsi +4 -0
index 526729dad53f..8328ddb3b02f 100644
@@ -148,6 +148,10 @@ opp-200000000 {
 	};
 };
 
+&dsi {
+	compatible = "samsung,exynos5422-mipi-dsi";
+};
+
 &mfc {
 	compatible = "samsung,mfc-v8";
 };
Signature · 1 line
2.39.0