Skip to contentSkip to conversation

Add support for Samsung Galaxy S5 (Exynos)

PATCH Superseded Markuss Broks 2 participants 6 messages Jan 21, 2023 – Jan 23, 2023

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add support for Samsung Galaxy S5 (Exynos)

Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014. It has an Exynos5422 platform. This version of Galaxy S5 is only capable of 3G communication using the Intel modem, while the LTE version of the device (klte) has a Qualcomm Snapdragon SoC.

Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen are enabled in the device-tree.

It also has the following peripherals:

- 5" 1080p S6E3FA2 DSI display,
- Cypress StreetFighter touch buttons,
- Broadcom BCM4354 wireless connectivity module,
- Intel XMM6360 3G modem,
- STM32F401 serving as a sensor hub,
- Validify Solutions VFS61 series fingerprint sensor,
- Lattice ICE401M FPGA as an IRDA controller,
- Maxim MAX86900 heart rate sensor,
- NXP PN547 NFC controller,
- Wolfson WM5110 Audio DSP,
- Broadcom BCM4753 GPS radio,
- Maxim MAX77804 PMIC,
- Silicon Image SII8240 MHL controller,
- TI LP5562 LED driver

Cc Mark Brown <[email protected]>

v1 -> v2:
- use better subject prefixes
- rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
- align the compatibles and clock output names
- reorder the includes
- generic node name for regulator-tsp-vdd-en
- GPIO flag for regulator
- rename all the regulators, leaving the voltage values only where it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)

Markuss Broks (2):
Documentation: devicetree: bindings: Add compatible for Samsung Galaxy

    S5 (Exynos)

arm: dts: Add device-tree for Samsung Galaxy S5 (Exynos)

 .../bindings/arm/samsung/samsung-boards.yaml  |   1 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/exynos5422-samsung-k3g.dts  | 676 ++++++++++++++++++
 3 files changed, 678 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5422-samsung-k3g.dts
Signature · 1 line
2.39.0
#1 lore raw

PATCH v2 1/2 dt-bindings: arm: samsung: Add compatible for Samsung Galaxy S5 (SM-G900H)

Add the compatible for k3g in the Samsung Exynos5800 boards section.

---
 .../devicetree/bindings/arm/samsung/samsung-boards.yaml          | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +1 -0
index faea33e4f731..deb2cf971871 100644
@@ -171,6 +171,7 @@ properties:
               - hardkernel,odroid-xu3-lite      # Hardkernel Odroid XU3 Lite
               - hardkernel,odroid-xu4           # Hardkernel Odroid XU4
               - hardkernel,odroid-hc1           # Hardkernel Odroid HC1
+              - samsung,k3g                     # Samsung Galaxy S5 (SM-G900H)
           - const: samsung,exynos5800
           - const: samsung,exynos5
 
Signature · 1 line
2.39.0
#2 lore raw

PATCH v2 2/2 arm: dts: exynos5422: Add device-tree for Samsung Galaxy S5 (SM-G900H)

In reply to Markuss Broks

Samsung Galaxy S5 (SM-G900H) was sold alongside Samsung Galaxy S5 with Snapdragon SoC, however the Exynos version features a 3G capable Intel modem instead of Qualcomm version featuring LTE modem. This phone is based on Exynos5422. Currently, the touchscreen, USB, eMMC and the PMIC are enabled in the device-tree.

---
 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 676 +++++++++++++++++++
 2 files changed, 677 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5422-samsung-k3g.dts
arch/arm/boot/dts/Makefile +1 -0
index c014f4fc53c0..b3aa4ad73d52 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
 	exynos5422-odroidxu3.dtb \
 	exynos5422-odroidxu3-lite.dtb \
 	exynos5422-odroidxu4.dtb \
+	exynos5422-samsung-k3g.dtb \
 	exynos5800-peach-pi.dtb
 dtb-$(CONFIG_ARCH_GEMINI) += \
 	gemini-dlink-dir-685.dtb \
arch/arm/boot/dts/exynos5422-samsung-k3g.dts new file +676 -0

676 lines not on this page · raw message

Signature · 1 line
2.39.0
#3 lore raw

Re: [PATCH v2 2/2] arm: dts: exynos5422: Add device-tree for Samsung Galaxy S5 (SM-G900H)

Quoted 6 lines · Markuss Broks

Samsung Galaxy S5 (SM-G900H) was sold alongside Samsung Galaxy S5 with Snapdragon SoC, however the Exynos version features a 3G capable Intel modem instead of Qualcomm version featuring LTE modem. This phone is based on Exynos5422. Currently, the touchscreen, USB, eMMC and the PMIC are enabled in the device-tree.

Quoted 7 lines
---
 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 676 +++++++++++++++++++
 2 files changed, 677 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5422-samsung-k3g.dts

I gave it a try but dtbs_check complain:

/home/krzk/dev/linux/linux/out/arch/arm/boot/dts/exynos5422-samsung-k3g.dtb:
pinctrl@13400000: 's2mps11-irq-pin', 'touch-int-pin' do not match any of the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$', '^[a-z]+[0-9]*-gpio-bank$', 'pinctrl-[0-9]+'
From schema:
/home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml

Best regards,
Krzysztof

#4 lore raw
In reply to Markuss Broks
Quoted 27 lines · Markuss Broks

Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014. It has an Exynos5422 platform. This version of Galaxy S5 is only capable of 3G communication using the Intel modem, while the LTE version of the device (klte) has a Qualcomm Snapdragon SoC.

Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen are enabled in the device-tree.

It also has the following peripherals:

- 5" 1080p S6E3FA2 DSI display,
- Cypress StreetFighter touch buttons,
- Broadcom BCM4354 wireless connectivity module,
- Intel XMM6360 3G modem,
- STM32F401 serving as a sensor hub,
- Validify Solutions VFS61 series fingerprint sensor,
- Lattice ICE401M FPGA as an IRDA controller,
- Maxim MAX86900 heart rate sensor,
- NXP PN547 NFC controller,
- Wolfson WM5110 Audio DSP,
- Broadcom BCM4753 GPS radio,
- Maxim MAX77804 PMIC,
- Silicon Image SII8240 MHL controller,
- TI LP5562 LED driver

Cc Mark Brown <[email protected]>
Quoted 9 lines

v1 -> v2:
- use better subject prefixes
- rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
- align the compatibles and clock output names
- reorder the includes
- generic node name for regulator-tsp-vdd-en
- GPIO flag for regulator
- rename all the regulators, leaving the voltage values only where it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)

I got two v2 patchsets from you. No clue which one is correct. Please send v3 if there were differences. Otherwise please annotate somehow...

Best regards,
Krzysztof

#5 lore raw

Hi Krzysztof,

Quoted 37 lines · Krzysztof Kozlowski
Quoted 27 lines · Markuss Broks

Samsung Galaxy S5 (Exynos) is a mobile phone released in 2014. It has an Exynos5422 platform. This version of Galaxy S5 is only capable of 3G communication using the Intel modem, while the LTE version of the device (klte) has a Qualcomm Snapdragon SoC.

Currently, internal eMMC, USB, regulators on a PMIC, and touchscreen are enabled in the device-tree.

It also has the following peripherals:

- 5" 1080p S6E3FA2 DSI display,
- Cypress StreetFighter touch buttons,
- Broadcom BCM4354 wireless connectivity module,
- Intel XMM6360 3G modem,
- STM32F401 serving as a sensor hub,
- Validify Solutions VFS61 series fingerprint sensor,
- Lattice ICE401M FPGA as an IRDA controller,
- Maxim MAX86900 heart rate sensor,
- NXP PN547 NFC controller,
- Wolfson WM5110 Audio DSP,
- Broadcom BCM4753 GPS radio,
- Maxim MAX77804 PMIC,
- Silicon Image SII8240 MHL controller,
- TI LP5562 LED driver

Cc Mark Brown <[email protected]>
Quoted 9 lines

v1 -> v2:
- use better subject prefixes
- rename Galaxy S5 (Exynos) to Galaxy S5 (SM-G900H)
- align the compatibles and clock output names
- reorder the includes
- generic node name for regulator-tsp-vdd-en
- GPIO flag for regulator
- rename all the regulators, leaving the voltage values only where it makes sense (e.g. on 3V3 and 1V8 supplies for the HRM)

Quoted 2 lines

I got two v2 patchsets from you. No clue which one is correct. Please send v3 if there were differences. Otherwise please annotate somehow...

Sorry about that, the first time I sent v2 it lacked the v2 tag in actual patch letters, but contained the tag in the cover letter, so I thought it would make confusion, so I fixed it and sent it properly. The patchsets are identical otherwise.

Quoted 4 lines

Best regards,
Krzysztof

- Markuss