Skip to contentSkip to conversation

agp/amd64: Fix full name of the GPL

PATCH In review Diederik de Haas 2 participants 3 messages Jan 22, 2023 – Jan 23, 2023 Agpgart driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 agp/amd64: Fix full name of the GPL

---
 drivers/char/agp/amd64-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/amd64-agp.c +1 -1
index ce8651436609..3020fd92fd00 100644
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright 2001-2003 SuSE Labs.
- * Distributed under the GNU public license, v2.
+ * Distributed under the GNU General Public License, v2.
  *
  * This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge.
  * It also includes support for the AMD 8151 AGP bridge,
Signature · 1 line
2.39.0
#1 lore raw

Le 22/01/2023 à 19:16, Diederik de Haas a écrit :

Quoted 10 lines
---
  drivers/char/agp/amd64-agp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/amd64-agp.c +0 -0
index ce8651436609..3020fd92fd00 100644

drivers/char/agp/amd64-agp.c line 7

Quoted 8 lines
drivers/char/agp/amd64-agp.c +1 -1
@@ -1,7 +1,7 @@
  // SPDX-License-Identifier: GPL-2.0-only
  /*
   * Copyright 2001-2003 SuSE Labs.
- * Distributed under the GNU public license, v2.
+ * Distributed under the GNU General Public License, v2.
   *
   * This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge.
   * It also includes support for the AMD 8151 AGP bridge,

Hi,

maybe the line can just be removed.
There is already a SPDX-License-Identifier above.

CJ

#2 lore raw
Quoted 21 lines · On Sunday, 22 January 2023 20:49:22 CET Christophe JAILLET wrote:
Quoted 20 lines · Diederik de Haas

---

  drivers/char/agp/amd64-agp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/amd64-agp.c +1 -1
index ce8651436609..3020fd92fd00 100644
@@ -1,7 +1,7 @@
 
  // SPDX-License-Identifier: GPL-2.0-only
  /*
 
   * Copyright 2001-2003 SuSE Labs.
 
- * Distributed under the GNU public license, v2.
+ * Distributed under the GNU General Public License, v2.
Quoted 7 lines
Quoted 4 lines

*
* This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge.
* It also includes support for the AMD 8151 AGP bridge,

maybe the line can just be removed.
There is already a SPDX-License-Identifier above.

Hi,

That does sound reasonable, but I'm now seeing it as a legal issue [1] and no longer as a spelling one. Strictly speaking it seems there is a discrepancy between the SPDX identifier and the 'full' license statement. While it may be reasonable to *assume* the "GNU General Public License, v2" was meant, when it comes to license/legal stuff, I think that does not suffice.

So I'd like to retract my patch submission and want to leave it up to people who are in a position to resolve this issue, if that needs to be done.

Apologies for the noise.

Diederik

[1] https://lore.kernel.org/lkml/[email protected]/