Skip to contentSkip to conversation

watchdog: Fix full name of the GPL

PATCH In review Diederik de Haas 2 participants 3 messages Jan 22, 2023 – Jan 23, 2023 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: Fix full name of the GPL

---
 drivers/watchdog/ibmasr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/ibmasr.c +1 -1
index 4a22fe152086..eee1043acfff 100644
@@ -7,7 +7,7 @@
  * Copyright (c) IBM Corporation, 1998-2004.
  *
  * This software may be used and distributed according to the terms
- * of the GNU Public License, incorporated herein by reference.
+ * of the GNU General Public License, incorporated herein by reference.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Signature · 1 line
2.39.0
maintainer
#1 lore raw
Quoted 10 lines · Diederik de Haas
---
  drivers/watchdog/ibmasr.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/ibmasr.c +0 -0
index 4a22fe152086..eee1043acfff 100644

drivers/watchdog/ibmasr.c line 13

Quoted 8 lines
drivers/watchdog/ibmasr.c +1 -1
@@ -7,7 +7,7 @@
   * Copyright (c) IBM Corporation, 1998-2004.
   *
   * This software may be used and distributed according to the terms
- * of the GNU Public License, incorporated herein by reference.
+ * of the GNU General Public License, incorporated herein by reference.
   */
 
  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

No. The only acceptable change would be to replace the text with the SPDX license identifier. However, the code is not specific declaring _which_ license is being used (2.0 only or 2.0+ or even 1.0+). Given that, the only entity who can change the license text in this file would be the license holder (which is presumably why it wasn't touched when the SPDX conversion was made).

On top of that, include/linux/module.h and other files also refer to "GNU Public License", so I don't really see the point of changing that.

If anyone is still using this driver, it would make more sense to convert it to use the watchdog subsystem core.

Guenter

#2 lore raw
Quoted 6 lines · On Sunday, 22 January 2023 20:45:13 CET Guenter Roeck wrote:

No. The only acceptable change would be to replace the text with the SPDX license identifier. However, the code is not specific declaring _which_ license is being used (2.0 only or 2.0+ or even 1.0+). Given that, the only entity who can change the license text in this file would be the license holder (which is presumably why it wasn't touched when the SPDX conversion was made).

You are entirely correct and my initial view of it as a spelling issue, was wrong. Please disregard the patch.