Skip to contentSkip to conversation

media: meson: vdec: remove redundant if statement

PATCH In review Christian Hewitt 2 participants 2 messages Jan 23, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: meson: vdec: remove redundant if statement

From: Benjamin Roszak <[email protected]>

Checking if sess->fmt_out->pixfmt is V4L2_PIX_FMT_VP9 was already done as a condition to enter the if statement where this additional check is made.

---
 drivers/staging/media/meson/vdec/esparser.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/meson/vdec/esparser.c +1 -2
index 86ccc8937afc..7b15fc54efe4 100644
@@ -314,8 +314,7 @@ esparser_queue(struct amvdec_session *sess, struct vb2_v4l2_buffer *vbuf)
 			num_dst_bufs = codec_ops->num_pending_bufs(sess);
 
 		num_dst_bufs += v4l2_m2m_num_dst_bufs_ready(sess->m2m_ctx);
-		if (sess->fmt_out->pixfmt == V4L2_PIX_FMT_VP9)
-			num_dst_bufs -= 3;
+		num_dst_bufs -= 3;
 
 		if (esparser_vififo_get_free_space(sess) < payload_size ||
 		    atomic_read(&sess->esparser_queued_bufs) >= num_dst_bufs)
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Christian Hewitt

From: Benjamin Roszak <[email protected]>

Checking if sess->fmt_out->pixfmt is V4L2_PIX_FMT_VP9 was already done as a condition to enter the if statement where this additional check is made.

---
  drivers/staging/media/meson/vdec/esparser.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/meson/vdec/esparser.c +0 -0
index 86ccc8937afc..7b15fc54efe4 100644

drivers/staging/media/meson/vdec/esparser.c esparser_queue(struct amvdec_session *sess, struct vb2_v4l2_buffer *vbuf) · line 320

Quoted 9 lines
drivers/staging/media/meson/vdec/esparser.c +1 -2
@@ -314,8 +314,7 @@ esparser_queue(struct amvdec_session *sess, struct vb2_v4l2_buffer *vbuf)
  			num_dst_bufs = codec_ops->num_pending_bufs(sess);
 
  		num_dst_bufs += v4l2_m2m_num_dst_bufs_ready(sess->m2m_ctx);
-		if (sess->fmt_out->pixfmt == V4L2_PIX_FMT_VP9)
-			num_dst_bufs -= 3;
+		num_dst_bufs -= 3;
 
  		if (esparser_vififo_get_free_space(sess) < payload_size ||
  		    atomic_read(&sess->esparser_queued_bufs) >= num_dst_bufs)