Skip to contentSkip to conversation

dt-bindings: thermal: Add Tegra234 BPMP thermal zones

PATCH In review Jon Hunter 2 participants 5 messages Jan 24, 2023 – Jan 25, 2023

Subsystems (3)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: thermal: Add Tegra234 BPMP thermal zones

From: Yi-Wei Wang <[email protected]>

Add BPMP thermal zone definitions for Tegra234.

---
 .../thermal/tegra234-bpmp-thermal.h           | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h
include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file +19 -0
new file mode 100644
index 000000000000..41a5efebcc7a
@@ -0,0 +1,19 @@
+/*
+ * This header provides constants for binding nvidia,tegra234-bpmp-thermal.
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H
+#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H
+
+#define TEGRA234_THERMAL_ZONE_CPU	0
+#define TEGRA234_THERMAL_ZONE_GPU	1
+#define TEGRA234_THERMAL_ZONE_CV0	2
+#define TEGRA234_THERMAL_ZONE_CV1	3
+#define TEGRA234_THERMAL_ZONE_CV2	4
+#define TEGRA234_THERMAL_ZONE_SOC0	5
+#define TEGRA234_THERMAL_ZONE_SOC1	6
+#define TEGRA234_THERMAL_ZONE_SOC2	7
+#define TEGRA234_THERMAL_ZONE_TJ_MAX	8
+#define TEGRA234_THERMAL_ZONE_COUNT	9
+
+#endif
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH 2/2 arm64: tegra: Add thermal support for Tegra234

From: Yi-Wei Wang <[email protected]>

Add the BPMP thermal device node and thermal-zones for Tegra234 and enable thermal support for the Tegra234 Jetson AGX Orin board.

---
 .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  | 276 ++++++++++++++++++
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts |  32 ++
 arch/arm64/boot/dts/nvidia/tegra234.dtsi      |  59 ++++
 3 files changed, 367 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +276 -0
index 2378da324273..7f798742df43 100644
@@ -80,6 +80,22 @@ pmc@c360000 {
 		};
 	};
 
+	bpmp {
+		i2c {
+			tegra_tmp451: thermal-sensor@4c {
+				compatible = "ti,tmp451";
+				reg = <0x4c>;
+				vcc-supply = <&vdd_1v8_ao>;
+				#thermal-sensor-cells = <1>;
+				status = "okay";
+			};
+		};
+
+		thermal {
+			status = "okay";
+		};
+	};
+
 	vdd_5v0_sys: regulator-vdd-5v0-sys {
 		compatible = "regulator-fixed";
 		regulator-name = "VIN_SYS_5V0";
@@ -139,4 +155,264 @@ vdd_12v_pcie: regulator-vdd-12v-pcie {
 		gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>;
 		regulator-boot-on;
 	};
+
+	thermal-zones {
+		cpu-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CPU>;
+			status = "okay";
+
+			trips {
+				cpu_sw_shutdown: cpu-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				cpu_sw_throttle: cpu-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		gpu-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_GPU>;
+			status = "okay";
+			status = "disabled";
+
+			trips {
+				gpu_sw_shutdown: gpu-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				gpu_sw_throttle: gpu-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&gpu_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		cv0-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CV0>;
+			status = "okay";
+
+			trips {
+				cv0_sw_shutdown: cv0-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				cv0_sw_throttle: cv0-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cv0_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+
+		cv1-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CV1>;
+			status = "okay";
+			status = "disabled";
+
+			trips {
+				cv1_sw_shutdown: cv1-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				cv1_sw_throttle: cv1-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cv1_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		cv2-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CV2>;
+			status = "okay";
+
+			trips {
+				cv2_sw_shutdown: cv2-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				cv2_sw_throttle: cv2-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cv2_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		soc0-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_SOC0>;
+			status = "okay";
+
+			trips {
+				soc0_sw_shutdown: soc0-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				soc0_sw_throttle: soc0-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&soc0_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		soc1-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_SOC1>;
+			status = "okay";
+
+			trips {
+				soc1_sw_shutdown: soc1-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				soc1_sw_throttle: soc1-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&soc1_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		soc2-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_SOC2>;
+			status = "okay";
+
+			trips {
+				soc2_sw_shutdown: soc2-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				soc2_sw_throttle: soc2-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&soc2_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+
+		tj-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_TJ_MAX>;
+			status = "okay";
+
+			trips {
+				tj_sw_shutdown: tj-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+		};
+	};
 };
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts +32 -0
index bfd935a86d19..b9c03a87fa5c 100644
@@ -2377,4 +2377,36 @@ sound {
 
 		label = "NVIDIA Jetson AGX Orin APE";
 	};
+
+	thermal-zones {
+		tboard-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&tegra_tmp451 0>;
+			status = "okay";
+
+			trips {
+				tboard_sw_shutdown: tboard-sw-shutdown {
+					temperature = <107000>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+		};
+
+		tdiode-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&tegra_tmp451 1>;
+			status = "okay";
+
+			trips {
+				tdiode_sw_shutdown: tdiode-sw-shutdown {
+					temperature = <107000>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+		};
+	};
 };
arch/arm64/boot/dts/nvidia/tegra234.dtsi +59 -0

93 lines not on this page · raw message

Signature · 1 line
2.25.1
author maintainer
#2 lore raw

Re: [PATCH 2/2] arm64: tegra: Add thermal support for Tegra234

Quoted 72 lines · Jon Hunter

From: Yi-Wei Wang <[email protected]>

Add the BPMP thermal device node and thermal-zones for Tegra234 and enable thermal support for the Tegra234 Jetson AGX Orin board.

---
  .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  | 276 ++++++++++++++++++
  .../nvidia/tegra234-p3737-0000+p3701-0000.dts |  32 ++
  arch/arm64/boot/dts/nvidia/tegra234.dtsi      |  59 ++++
  3 files changed, 367 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +44 -0
index 2378da324273..7f798742df43 100644
@@ -80,6 +80,22 @@ pmc@c360000 {
  		};
  	};
 
+	bpmp {
+		i2c {
+			tegra_tmp451: thermal-sensor@4c {
+				compatible = "ti,tmp451";
+				reg = <0x4c>;
+				vcc-supply = <&vdd_1v8_ao>;
+				#thermal-sensor-cells = <1>;
+				status = "okay";
+			};
+		};
+
+		thermal {
+			status = "okay";
+		};
+	};
+
  	vdd_5v0_sys: regulator-vdd-5v0-sys {
  		compatible = "regulator-fixed";
  		regulator-name = "VIN_SYS_5V0";
@@ -139,4 +155,264 @@ vdd_12v_pcie: regulator-vdd-12v-pcie {
  		gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>;
  		regulator-boot-on;
  	};
+
+	thermal-zones {
+		cpu-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_CPU>;
+			status = "okay";
+
+			trips {
+				cpu_sw_shutdown: cpu-sw-shutdown {
+					temperature = <104500>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+
+				cpu_sw_throttle: cpu-sw-throttle {
+					temperature = <99000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_sw_throttle>;
+					cooling-device = <&cpu0_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu1_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+							 <&cpu2_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;

arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi vdd_12v_pcie: regulator-vdd-12v-pcie { · line 195

Quoted 10 lines
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +10 -0
+				};
+			};
+		};
+
+		gpu-thermal {
+			polling-delay = <1000>;
+			polling-delay-passive = <1000>;
+			thermal-sensors = <&{/bpmp/thermal} TEGRA234_THERMAL_ZONE_GPU>;
+			status = "okay";
+			status = "disabled";

Looks like I messed this up. I will send a V2 to fix.

Jon

Signature · 1 line
nvpublic
maintainer
#3 lore raw
In reply to Jon Hunter
Quoted 8 lines · Jon Hunter

From: Yi-Wei Wang <[email protected]>

Add BPMP thermal zone definitions for Tegra234.

---
 .../thermal/tegra234-bpmp-thermal.h           | 19 +++++++++++++++++++

Match the compatible name please.

include/dt-bindings/thermal/tegra234-bpmp-thermal.h

Quoted 9 lines
 1 file changed, 19 insertions(+)
 create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h
include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file +0 -0
new file mode 100644
index 000000000000..41a5efebcc7a
@@ -0,0 +1,19 @@

License? Dual please.

Quoted 22 lines
include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file +19 -0
+/*
+ * This header provides constants for binding nvidia,tegra234-bpmp-thermal.
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H
+#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H
+
+#define TEGRA234_THERMAL_ZONE_CPU	0
+#define TEGRA234_THERMAL_ZONE_GPU	1
+#define TEGRA234_THERMAL_ZONE_CV0	2
+#define TEGRA234_THERMAL_ZONE_CV1	3
+#define TEGRA234_THERMAL_ZONE_CV2	4
+#define TEGRA234_THERMAL_ZONE_SOC0	5
+#define TEGRA234_THERMAL_ZONE_SOC1	6
+#define TEGRA234_THERMAL_ZONE_SOC2	7
+#define TEGRA234_THERMAL_ZONE_TJ_MAX	8
+#define TEGRA234_THERMAL_ZONE_COUNT	9
+
+#endif
Signature · 1 line
2.25.1
author maintainer
#4 lore raw
Quoted 11 lines · Rob Herring
Quoted 8 lines · Jon Hunter

From: Yi-Wei Wang <[email protected]>

Add BPMP thermal zone definitions for Tegra234.

---
  .../thermal/tegra234-bpmp-thermal.h           | 19 +++++++++++++++++++

Match the compatible name please.

OK, but to be clear, the compatible string is 'nvidia,tegra186-bpmp-thermal'. So should 'tegra186-bpmp-thermal.h', 'tegra194-bpmp- thermal.h' and this file be combined into a single filed called 'nvidia,tegra186-bpmp-thermal.h'?

Quoted 4 lines
Quoted 4 lines
  1 file changed, 19 insertions(+)

create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h

Quoted 8 lines

include/dt-bindings/thermal/tegra234-bpmp-thermal.h

Quoted 6 lines
include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file +0 -0
new file mode 100644
index 000000000000..41a5efebcc7a
@@ -0,0 +1,19 @@

License? Dual please.

Yes will fix this.

Thanks
Jon

Signature · 1 line
nvpublic