dt-bindings: trivial-devices: Add Infineon TDA38640 Voltage Regulator
Subsystems (2)
PATCH v3 1/2 dt-bindings: trivial-devices: Add Infineon TDA38640 Voltage Regulator
Infineon TDA38640 is PMBUS compliant voltage regulator.
--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280
base-commit: 4d891f76a30d3be4194a805c5e4277786140ef05
Signature · 1 line
2.38.1
PATCH v3 2/2 hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
--- drivers/hwmon/pmbus/Kconfig | 16 ++++++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 73 ++++++++++++++++++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 drivers/hwmon/pmbus/tda38640.c
drivers/hwmon/pmbus/Kconfig +16 -0
@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640. + + This driver can also be built as a module. If so, the module will + be called tda38640. + +config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator. + config SENSORS_TPS40422 tristate "TI TPS40422" help
drivers/hwmon/pmbus/Makefile +1 -0
@@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o
drivers/hwmon/pmbus/tda38640.c new file +73 -0
73 lines not on this page · raw message
Signature · 1 line
2.38.1
Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
Quoted 7 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>---
(...)
Quoted 40 lines
drivers/hwmon/pmbus/tda38640.c new file +40
-0+ +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { +PMBUS_REGULATOR ("vout" ,0 ), +}; + +static struct pmbus_driver_info tda38640_info = { + .pages =1 , + .format[PSC_VOLTAGE_IN ] = linear, + .format[PSC_VOLTAGE_OUT ] = linear, + .format[PSC_CURRENT_OUT ] = linear, + .format[PSC_CURRENT_IN ] = linear, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + + .func[0 ] =PMBUS_HAVE_VIN |PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_IIN + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + |PMBUS_HAVE_POUT |PMBUS_HAVE_PIN , +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators =1 , + .reg_desc = tda38640_reg_desc, +#endif +}; + +static int tda38640_probe (struct i2c_client *client) +{ +return pmbus_do_probe (client, &tda38640_info); +} + +static const struct i2c_device_id tda38640_id[] = {
drivers/hwmon/pmbus/tda38640.c line 57
Quoted 10 lines
drivers/hwmon/pmbus/tda38640.c new file +10
-0+ {"tda38640", 0}, + {} +}; +MODULE_DEVICE_TABLE (i2c, tda38640_id); + +static const struct of_device_id __maybe_unused tda38640_of_match[] = { + { .compatible ="infineon,tda38640" }, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);
No improvements here. Do not send new version without solving the feedback (or finishing the discussion). Its usage is still missing in your i2c_driver.
Best regards,
Krzysztof
Re: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
Quoted 57 lines · Krzysztof Kozlowski
Quoted 7 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>---
(...)
Quoted 46 lines
drivers/hwmon/pmbus/tda38640.c new file +46
-0+ +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { +PMBUS_REGULATOR ("vout" ,0 ), +}; + +static struct pmbus_driver_info tda38640_info = { + .pages =1 , + .format[PSC_VOLTAGE_IN ] = linear, + .format[PSC_VOLTAGE_OUT ] = linear, + .format[PSC_CURRENT_OUT ] = linear, + .format[PSC_CURRENT_IN ] = linear, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + + .func[0 ] =PMBUS_HAVE_VIN |PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_IIN + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + |PMBUS_HAVE_POUT |PMBUS_HAVE_PIN , +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators =1 , + .reg_desc = tda38640_reg_desc, +#endif +}; + +static int tda38640_probe (struct i2c_client *client) +{ +return pmbus_do_probe (client, &tda38640_info); +} + +static const struct i2c_device_id tda38640_id[] = { + {"tda38640" ,0 }, + {} +}; +MODULE_DEVICE_TABLE (i2c, tda38640_id); + +static const struct of_device_id __maybe_unused tda38640_of_match[] = {
Quoted 8 lines
drivers/hwmon/pmbus/tda38640.c line 57
Quoted 4 lines
drivers/hwmon/pmbus/tda38640.c new file +4
-0+ { .compatible = "infineon,tda38640"}, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);No improvements here. Do not send new version without solving the feedback (or finishing the discussion). Its usage is still missing in your
i2c_driver.
I realized I missed reference to tda38640_of_match below.
static struct i2c_driver tda38640_driver = {
.driver = {
.name = "tda38640",
.of_match_table = of_match_ptr(tda38640_of_match),
},
.probe_new = tda38640_probe,
.id_table = tda38640_id,
};Will fix that.
Quoted 4 lines
Best regards,
Krzysztof
Thanks,
Naresh
Guenter Roeck
maintainerRe: [PATCH v3 2/2] hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
Quoted 68 lines · Naresh Solanki
Quoted 57 lines · Krzysztof Kozlowski
Quoted 7 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>---
(...)
Quoted 46 lines
drivers/hwmon/pmbus/tda38640.c new file +46
-0+ +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = { +PMBUS_REGULATOR ("vout" ,0 ), +}; + +static struct pmbus_driver_info tda38640_info = { + .pages =1 , + .format[PSC_VOLTAGE_IN ] = linear, + .format[PSC_VOLTAGE_OUT ] = linear, + .format[PSC_CURRENT_OUT ] = linear, + .format[PSC_CURRENT_IN ] = linear, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + + .func[0 ] =PMBUS_HAVE_VIN |PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_IIN + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + |PMBUS_HAVE_POUT |PMBUS_HAVE_PIN , +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators =1 , + .reg_desc = tda38640_reg_desc, +#endif +}; + +static int tda38640_probe (struct i2c_client *client) +{ +return pmbus_do_probe (client, &tda38640_info); +} + +static const struct i2c_device_id tda38640_id[] = { + {"tda38640" ,0 }, + {} +}; +MODULE_DEVICE_TABLE (i2c, tda38640_id); + +static const struct of_device_id __maybe_unused tda38640_of_match[] = {Quoted 8 lines
drivers/hwmon/pmbus/tda38640.c line 57
Quoted 4 lines
drivers/hwmon/pmbus/tda38640.c new file +4
-0+ { .compatible = "infineon,tda38640"}, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);No improvements here. Do not send new version without solving the feedback (or finishing the discussion). Its usage is still missing in your
i2c_driver.
Quoted 7 lines
I realized I missed reference to
tda38640_of_matchbelow.static struct i2c_driver tda38640_driver = { .driver = { .name = "tda38640", .of_match_table = of_match_ptr(tda38640_of_match), },
Column alignment also looks off. I would expect tabs only, like
.driver = {
.name = "tda38640",
.of_match_table = of_match_ptr(tda38640_of_match),
},Guenter
Quoted 11 lines
.probe_new = tda38640_probe, .id_table = tda38640_id, };Will fix that.
Quoted 4 lines
Best regards,
KrzysztofThanks,
Naresh