Skip to contentSkip to conversation

uvcgadget changes

GIT PULL Michael Grzeschik 3 participants 6 messages Jan 24, 2023 – Jan 27, 2023 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

drivers/media/common/Kconfig                  |   3 +
drivers/media/common/Makefile                 |   1 +
drivers/media/common/uvc.c                    | 183 ++++++++++++++++++++++
drivers/media/usb/uvc/Kconfig                 |   1 +
drivers/media/usb/uvc/uvc_ctrl.c              |   2 +-
drivers/media/usb/uvc/uvc_driver.c            |   4 +-
drivers/usb/gadget/Kconfig                    |   1 +
drivers/usb/gadget/function/uvc_v4l2.c        |  16 +-
include/{media/v4l2-uvc.h => linux/usb/uvc.h} | 209 +-------------------------
9 files changed, 201 insertions(+), 219 deletions(-)

create mode 100644 drivers/media/common/uvc.c rename include/{media/v4l2-uvc.h => linux/usb/uvc.h} (59%)

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#1 lore raw
Quoted 16 lines · Michael Grzeschik

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Quoted 5 lines

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

Sorry, but I can't take patches like this as a pull request. I want to see the real patches and get people to review them properly that way.

thanks,

greg k-h

#2 lore raw
Quoted 17 lines · Greg KH
Quoted 16 lines · Michael Grzeschik

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Quoted 8 lines
Quoted 5 lines

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

Sorry, but I can't take patches like this as a pull request. I want to see the real patches and get people to review them properly that way.

I just did like Laurent suggested. Since the series was already properly reviewed I also thought this would be fine.

https://lore.kernel.org/linux-media/[email protected]/

Anyway. I can send another round with the patch from Marek in the series.

Thanks,
Michael

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

Hi Laurent,

Quoted 27 lines · Michael Grzeschik
Quoted 17 lines · Greg KH
Quoted 16 lines · Michael Grzeschik

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Quoted 8 lines
Quoted 5 lines

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

Sorry, but I can't take patches like this as a pull request. I want to see the real patches and get people to review them properly that way.

Quoted 7 lines

I just did like Laurent suggested. Since the series was already properly reviewed I also thought this would be fine.

https://lore.kernel.org/linux-media/[email protected]/

Anyway. I can send another round with the patch from Marek in the series.

I am unsure how to proceed here.

I could send the series again and hope for Greg to take them. But without Mauros merge of your changes underneath, Greg will not be able to apply my series.

Thanks,
Michael

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#4 lore raw

Hello,

Quoted 33 lines · Michael Grzeschik
Quoted 32 lines · Michael Grzeschik
Quoted 17 lines · Greg KH
Quoted 16 lines · Michael Grzeschik

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Quoted 8 lines
Quoted 5 lines

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

Sorry, but I can't take patches like this as a pull request. I want to see the real patches and get people to review them properly that way.

I just did like Laurent suggested. Since the series was already properly reviewed I also thought this would be fine.

https://lore.kernel.org/linux-media/[email protected]/

Quoted 8 lines
Quoted 2 lines

Anyway. I can send another round with the patch from Marek in the series.

I am unsure how to proceed here.

I could send the series again and hope for Greg to take them. But without Mauros merge of your changes underneath, Greg will not be able to apply my series.

I think Greg would like to see a v3 of the series exactly as it exists in your branch, based on top of media-uvc-next-20230115, with Marek's patch included. Could you post that, and indicate in the cover letter than it applies on top of

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git media-uvc-next-20230115

which has been merged in the Linux media tree for v6.3 (as shown by
https://git.linuxtv.org/media_stage.git/commit/?id=82adfe34694c98f1115a7b75cff6af9c4a35dba9).

Greg, can you then merge that tag in your tree first, and then pick Michael's patches up on top ?

Signature · 3 lines
Regards,

Laurent Pinchart
#5 lore raw
Quoted 50 lines · Laurent Pinchart

Hello,

Quoted 33 lines · Michael Grzeschik
Quoted 32 lines · Michael Grzeschik
Quoted 17 lines · Greg KH
Quoted 16 lines · Michael Grzeschik

The following changes since commit 82adfe34694c98f1115a7b75cff6af9c4a35dba9:

Merge tag 'media-uvc-next-20230115' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into media_stage (2023-01-22 08:43:14 +0100)

are available in the Git repository at:

git://git.pengutronix.de/mgr/linux tags/uvc-gadget-next-20230124

for you to fetch changes up to e88f760d0f7054f49aa68b75bf0530840f031d34:

usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name (2023-01-24 15:26:07 +0100)

----------------------------------------------------------------
Marek Vasut (1):
media: uvcvideo: Add GUID for BGRA/X 8:8:8:8

Quoted 8 lines
Quoted 5 lines

Michael Grzeschik (4):
usb: uvc: move media/v4l2-uvc.h to usb/uvc.h
usb: uvc: move uvc_fmts and uvc_format_by_guid to own compile unit
usb: uvc: make uvc_format_desc table const
usb: uvc: use v4l2_fill_fmtdesc instead of open coded format name

Sorry, but I can't take patches like this as a pull request. I want to see the real patches and get people to review them properly that way.

I just did like Laurent suggested. Since the series was already properly reviewed I also thought this would be fine.

https://lore.kernel.org/linux-media/[email protected]/

Quoted 8 lines
Quoted 2 lines

Anyway. I can send another round with the patch from Marek in the series.

I am unsure how to proceed here.

I could send the series again and hope for Greg to take them. But without Mauros merge of your changes underneath, Greg will not be able to apply my series.

I think Greg would like to see a v3 of the series exactly as it exists in your branch, based on top of media-uvc-next-20230115, with Marek's patch included. Could you post that, and indicate in the cover letter than it applies on top of

Quoted 7 lines

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git media-uvc-next-20230115

which has been merged in the Linux media tree for v6.3 (as shown by
https://git.linuxtv.org/media_stage.git/commit/?id=82adfe34694c98f1115a7b75cff6af9c4a35dba9).

Greg, can you then merge that tag in your tree first, and then pick Michael's patches up on top ?

Yes, I will be glad to do that, thanks.

greg k-h