drm/edid: reverse display info preserve/clear logic, defaulting to clear
Subsystems (16)
PATCH 1/3 drm/edid: reverse display info preserve/clear logic, defaulting to clear
Instead of explicitly clearing individual struct drm_display_info members manually, default to clearing everything and preserving the members that currently do need to be preserved manually. The goal is to avoid adding new members while forgetting to clear them.
Use a little bit of macro magic to avoid duplicating the types. There should be no functional changes.
The long term goal is to move the members that are modified by drivers and need to be preserved out of display info.
--- drivers/gpu/drm/drm_edid.c | 50 ++++++++++++++++++-------------------- 1 file changed, 23 insertions(+), 27 deletions(-)
drivers/gpu/drm/drm_edid.c +23 -27
@@ -6401,36 +6401,32 @@ static void drm_update_mso(struct drm_connector *connector,static void drm_reset_display_info (struct drm_connector *connector) {struct drm_display_info *info = &connector->display_info; - - info->width_mm =0 ; - info->height_mm =0 ; - - info->bpc =0 ; - info->color_formats =0 ; - info->cea_rev =0 ; - info->max_tmds_clock =0 ; - info->dvi_dual = false; - info->is_hdmi = false; - info->has_hdmi_infoframe = false; - info->rgb_quant_range_selectable = false; -memset (&info->hdmi,0 ,sizeof (info->hdmi)); - - info->edid_hdmi_rgb444_dc_modes =0 ; - info->edid_hdmi_ycbcr444_dc_modes =0 ; - - info->non_desktop =0 ; -memset (&info->monitor_range,0 ,sizeof (info->monitor_range)); -memset (&info->luminance_range,0 ,sizeof (info->luminance_range)); - - info->mso_stream_count =0 ; - info->mso_pixel_overlap =0 ; - info->max_dsc_bpp =0 ; +#define COPY_MEMBER (__member) __auto_type __member = info->__member +COPY_MEMBER (subpixel_order); +COPY_MEMBER (panel_orientation); +COPY_MEMBER (bus_formats); +COPY_MEMBER (num_bus_formats); +COPY_MEMBER (bus_flags); +#undef COPY_MEMBERkfree (info->vics); - info->vics =NULL ; - info->vics_len =0 ; - info->quirks =0 ; +memset (info,0 ,sizeof (*info)); + +/* +* Preserve certain members across display info resets. These are +* modified by drivers, and do not originate from the EDID. Please try +* to avoid adding more. +* +* FIXME: Move all of these to a separate drm_connector sub-struct, and +* make struct drm_display_info purely about info originating from the +* EDID. +*/ + info->subpixel_order = subpixel_order; + info->panel_orientation = panel_orientation; + info->bus_formats = bus_formats;/* Note: pointer copy! */ + info->num_bus_formats = num_bus_formats; + info->bus_flags = bus_flags; } static void update_display_info(struct drm_connector *connector,
Signature · 1 line
2.34.1
PATCH 2/3 drm/connector: move HDR sink metadata to display info
Information parsed from the display EDID should be stored in display info. The functional change here is clearing the HDR sink metadata in drm_reset_display_info(), which should be the right thing to do anyway.
--- drivers/gpu/drm/display/drm_hdmi_helper.c | 2 +- drivers/gpu/drm/drm_connector.c | 2 +- drivers/gpu/drm/drm_edid.c | 17 +++++++++-------- .../drm/i915/display/intel_dp_aux_backlight.c | 2 +- include/drm/drm_connector.h | 8 +++++--- 5 files changed, 17 insertions(+), 14 deletions(-)
drivers/gpu/drm/display/drm_hdmi_helper.c +1 -1
@@ -44,7 +44,7 @@ int drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame,/* Sink EOTF is Bit map while infoframe is absolute values */ if (!is_eotf_supported (hdr_metadata->hdmi_metadata_type1.eotf, - connector->hdr_sink_metadata.hdmi_type1.eotf)) { + connector->display_info.hdr_sink_metadata.hdmi_type1.eotf)) {DRM_DEBUG_KMS ("EOTF Not Supported\n" );return -EINVAL ; }
drivers/gpu/drm/drm_connector.c +1 -1
@@ -1345,7 +1345,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = {* structure from userspace. This is received as blob and stored in * &drm_connector_state.hdr_output_metadata. It parses EDID and saves the * sink metadata in &struct hdr_sink_metadata, as -* &drm_connector.hdr_sink_metadata. Driver uses +* &drm_connector.display_info.hdr_sink_metadata. Driver uses * drm_hdmi_infoframe_set_hdr_metadata() helper to set the HDR metadata, * hdmi_drm_infoframe_pack() to pack the infoframe as per spec, in case of * HDMI encoder.
drivers/gpu/drm/drm_edid.c +9 -8
@@ -5282,7 +5282,8 @@ static void fixup_detailed_cea_mode_clock(struct drm_connector *connector,static void drm_calculate_luminance_range (struct drm_connector *connector) { -struct hdr_static_metadata *hdr_metadata = &connector->hdr_sink_metadata.hdmi_type1; +const struct hdr_static_metadata *hdr_metadata = + &connector->display_info.hdr_sink_metadata.hdmi_type1;struct drm_luminance_range_info *luminance_range = &connector->display_info.luminance_range;static const u8 pre_computed_values[] = {
@@ -5343,21 +5344,21 @@ static uint8_t hdr_metadata_type(const u8 *edid_ext)static void drm_parse_hdr_metadata_block (struct drm_connector *connector,const u8 *db) { +struct hdr_static_metadata *hdr_metadata = + &connector->display_info.hdr_sink_metadata.hdmi_type1;u16 len; len =cea_db_payload_len (db); - connector->hdr_sink_metadata.hdmi_type1.eotf = -eotf_supported (db); - connector->hdr_sink_metadata.hdmi_type1.metadata_type = -hdr_metadata_type (db); + hdr_metadata->eotf =eotf_supported (db); + hdr_metadata->metadata_type =hdr_metadata_type (db);if (len >=4 ) - connector->hdr_sink_metadata.hdmi_type1.max_cll = db[4 ]; + hdr_metadata->max_cll = db[4 ];if (len >=5 ) - connector->hdr_sink_metadata.hdmi_type1.max_fall = db[5 ]; + hdr_metadata->max_fall = db[5 ];if (len >=6 ) { - connector->hdr_sink_metadata.hdmi_type1.min_cll = db[6 ]; + hdr_metadata->min_cll = db[6 ];/* Calculate only when all values are available */ drm_calculate_luminance_range (connector);
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +1 -1
@@ -144,7 +144,7 @@ intel_dp_aux_supports_hdr_backlight(struct intel_connector *connector)* ranges for such panels. */ if (i915->params.enable_dpcd_backlight !=INTEL_DP_AUX_BACKLIGHT_FORCE_INTEL && - !(connector->base.hdr_sink_metadata.hdmi_type1.metadata_type & + !(connector->base.display_info.hdr_sink_metadata.hdmi_type1.metadata_type &BIT (HDMI_STATIC_METADATA_TYPE1 ))) { drm_info(&i915->drm, "Panel is missing HDR static metadata. Possible support for Intel HDR backlight interface is not used. If your backlight controls don't work try booting with i915.enable_dpcd_backlight=%d. needs this, please file a _new_ bug report on drm/i915, see " FDO_BUG_URL " for details.\n",
include/drm/drm_connector.h +5 -3
@@ -686,6 +686,11 @@ struct drm_display_info {*/ struct drm_hdmi_info hdmi; +/** +* @hdr_sink_metadata: HDR Metadata Information read from sink +*/ +struct hdr_sink_metadata hdr_sink_metadata; +/** * @non_desktop: Non desktop display (HMD). */
@@ -1790,9 +1795,6 @@ struct drm_connector {* &drm_mode_config.connector_free_work. */ struct llist_node free_node; - -/** @hdr_sink_metadata: HDR Metadata Information read from sink */ -struct hdr_sink_metadata hdr_sink_metadata; };#define obj_to_connector (x) container_of(x, struct drm_connector, base)
Signature · 1 line
2.34.1
PATCH 3/3 drm/connector: move ELD and video/audio latencies to display info
In reply to Jani NikulaInformation parsed from the display EDID should be stored in display info. We can stop clearing ELD separately.
---
Sorry about the crazy Cc list, but this touches a lot of drivers, and I didn't want to blind side anyone.
--- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 6 +-- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 6 +-- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 +-- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 12 ++--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++--- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +- drivers/gpu/drm/bridge/ite-it66121.c | 4 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- drivers/gpu/drm/drm_edid.c | 45 +++++++------------ drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- drivers/gpu/drm/i915/display/intel_audio.c | 22 ++++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +- drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +- drivers/gpu/drm/msm/dp/dp_audio.c | 4 +- drivers/gpu/drm/radeon/dce6_afmt.c | 12 ++--- drivers/gpu/drm/radeon/evergreen_hdmi.c | 12 ++--- drivers/gpu/drm/radeon/radeon_audio.c | 4 +- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- include/drm/drm_connector.h | 39 +++++++++------- 21 files changed, 99 insertions(+), 102 deletions(-)
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +3 -3
@@ -1257,11 +1257,11 @@ static void dce_v10_0_audio_write_latency_fields(struct drm_encoder *encoder,if (mode->flags &DRM_MODE_FLAG_INTERLACE ) interlace =1 ; -if (connector->latency_present[interlace]) { +if (connector->display_info.latency_present[interlace]) { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -VIDEO_LIPSYNC , connector->video_latency[interlace]); +VIDEO_LIPSYNC , connector->display_info.video_latency[interlace]); tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -AUDIO_LIPSYNC , connector->audio_latency[interlace]); +AUDIO_LIPSYNC , connector->display_info.audio_latency[interlace]); }else { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC ,VIDEO_LIPSYNC ,0 );
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +3 -3
@@ -1283,11 +1283,11 @@ static void dce_v11_0_audio_write_latency_fields(struct drm_encoder *encoder,if (mode->flags &DRM_MODE_FLAG_INTERLACE ) interlace =1 ; -if (connector->latency_present[interlace]) { +if (connector->display_info.latency_present[interlace]) { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -VIDEO_LIPSYNC , connector->video_latency[interlace]); +VIDEO_LIPSYNC , connector->display_info.video_latency[interlace]); tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -AUDIO_LIPSYNC , connector->audio_latency[interlace]); +AUDIO_LIPSYNC , connector->display_info.audio_latency[interlace]); }else { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC ,VIDEO_LIPSYNC ,0 );
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +3 -3
@@ -1158,11 +1158,11 @@ static void dce_v6_0_audio_write_latency_fields(struct drm_encoder *encoder,if (mode->flags &DRM_MODE_FLAG_INTERLACE ) interlace =1 ; -if (connector->latency_present[interlace]) { +if (connector->display_info.latency_present[interlace]) { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -VIDEO_LIPSYNC , connector->video_latency[interlace]); +VIDEO_LIPSYNC , connector->display_info.video_latency[interlace]); tmp =REG_SET_FIELD (tmp,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC , -AUDIO_LIPSYNC , connector->audio_latency[interlace]); +AUDIO_LIPSYNC , connector->display_info.audio_latency[interlace]); }else { tmp =REG_SET_FIELD (0 ,AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC ,VIDEO_LIPSYNC ,0 );
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +6 -6
@@ -1195,11 +1195,11 @@ static void dce_v8_0_audio_write_latency_fields(struct drm_encoder *encoder, }if (mode->flags &DRM_MODE_FLAG_INTERLACE ) { -if (connector->latency_present[1 ]) +if (connector->display_info.latency_present[1 ]) tmp = - (connector->video_latency[1 ] << + (connector->display_info.video_latency[1 ] <<AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC__VIDEO_LIPSYNC__SHIFT ) | - (connector->audio_latency[1 ] << + (connector->display_info.audio_latency[1 ] <<AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC__AUDIO_LIPSYNC__SHIFT );else tmp =
@@ -1208,11 +1208,11 @@ static void dce_v8_0_audio_write_latency_fields(struct drm_encoder *encoder, (0 <<AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC__AUDIO_LIPSYNC__SHIFT ); }else { -if (connector->latency_present[0 ]) +if (connector->display_info.latency_present[0 ]) tmp = - (connector->video_latency[0 ] << + (connector->display_info.video_latency[0 ] <<AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC__VIDEO_LIPSYNC__SHIFT ) | - (connector->audio_latency[0 ] << + (connector->display_info.audio_latency[0 ] <<AZALIA_F0_CODEC_PIN_CONTROL_RESPONSE_LIPSYNC__AUDIO_LIPSYNC__SHIFT );else tmp =
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +5 -5
@@ -894,8 +894,8 @@ static int amdgpu_dm_audio_component_get_eld(struct device *kdev, int port,continue ; *enabled = true; - ret =drm_eld_size (connector->eld); -memcpy (buf, connector->eld,min (max_bytes, ret)); + ret =drm_eld_size (connector->display_info.eld); +memcpy (buf, connector->display_info.eld,min (max_bytes, ret));break ; }
@@ -5386,9 +5386,9 @@ static void fill_audio_info(struct audio_info *audio_info, audio_info->flags.all = edid_caps->speaker_flags;/* TODO: We only check for the progressive mode, check for interlace mode too */ -if (drm_connector->latency_present[0 ]) { - audio_info->video_latency = drm_connector->video_latency[0 ]; - audio_info->audio_latency = drm_connector->audio_latency[0 ]; +if (drm_connector->display_info.latency_present[0 ]) { + audio_info->video_latency = drm_connector->display_info.video_latency[0 ]; + audio_info->audio_latency = drm_connector->display_info.audio_latency[0 ]; }/* TODO: For DP, video and audio latency should be calculated from DPCD caps */
drivers/gpu/drm/bridge/analogix/anx7625.c +2 -2
@@ -1982,8 +1982,8 @@ static int anx7625_audio_get_eld(struct device *dev, void *data,memset (buf,0 , len); }else {dev_dbg (dev,"audio copy eld\n" ); -memcpy (buf, ctx->connector->eld, -min (sizeof (ctx->connector->eld), len)); +memcpy (buf, ctx->connector->display_info.eld, +min (sizeof (ctx->connector->display_info.eld), len)); }return 0 ;
drivers/gpu/drm/bridge/ite-it66121.c +2 -2
@@ -1448,8 +1448,8 @@ static int it66121_audio_get_eld(struct device *dev, void *data,mutex_lock (&ctx->lock); -memcpy (buf, ctx->connector->eld, -min (sizeof (ctx->connector->eld), len)); +memcpy (buf, ctx->connector->display_info.eld, +min (sizeof (ctx->connector->display_info.eld), len));mutex_unlock (&ctx->lock);
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -1
@@ -789,7 +789,7 @@ static u8 *hdmi_audio_get_eld(struct dw_hdmi *hdmi)if (!hdmi->curr_conn)return NULL ; -return hdmi->curr_conn->eld; +return hdmi->curr_conn->display_info.eld; }static void dw_hdmi_gp_audio_enable (struct dw_hdmi *hdmi)
drivers/gpu/drm/drm_edid.c +17 -28
94 lines not on this page · raw message
drivers/gpu/drm/exynos/exynos_hdmi.c +1 -1
@@ -1640,7 +1640,7 @@ static int hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf,struct hdmi_context *hdata =dev_get_drvdata (dev);struct drm_connector *connector = &hdata->connector; -memcpy (buf, connector->eld,min (sizeof (connector->eld), len)); +memcpy (buf, connector->display_info.eld,min (sizeof (connector->display_info.eld), len));return 0 ; }
drivers/gpu/drm/i915/display/intel_audio.c +11 -11
@@ -336,7 +336,7 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder,struct drm_i915_private *i915 =to_i915 (encoder->base.dev);struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_connector *connector = conn_state->connector; -const u32 *eld = (const u32 *)connector->eld; +const u32 *eld = (const u32 *)connector->display_info.eld;int eld_buffer_size, len, i;intel_crtc_wait_for_next_vblank (crtc);
@@ -345,7 +345,7 @@ static void g4x_audio_codec_enable(struct intel_encoder *encoder, G4X_ELD_VALID | G4X_ELD_ADDRESS_MASK, 0); eld_buffer_size =g4x_eld_buffer_size (i915); - len =min (drm_eld_size (connector->eld) /4 , eld_buffer_size); + len =min (drm_eld_size (connector->display_info.eld) /4 , eld_buffer_size);for (i =0 ; i < len; i++)intel_de_write (i915,G4X_HDMIW_HDMIEDID , eld[i]);
@@ -620,7 +620,7 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_connector *connector = conn_state->connector;enum transcoder cpu_transcoder = crtc_state->cpu_transcoder; -const u32 *eld = (const u32 *)connector->eld; +const u32 *eld = (const u32 *)connector->display_info.eld;int eld_buffer_size, len, i;mutex_lock (&i915->display.audio.mutex);
@@ -644,7 +644,7 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder, IBX_ELD_ADDRESS_MASK, 0); eld_buffer_size =hsw_eld_buffer_size (i915, cpu_transcoder); - len =min (drm_eld_size (connector->eld) /4 , eld_buffer_size); + len =min (drm_eld_size (connector->display_info.eld) /4 , eld_buffer_size);for (i =0 ; i < len; i++)intel_de_write (i915,HSW_AUD_EDID_DATA (cpu_transcoder), eld[i]);
@@ -748,7 +748,7 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder,struct drm_i915_private *i915 =to_i915 (encoder->base.dev);struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_connector *connector = conn_state->connector; -const u32 *eld = (const u32 *)connector->eld; +const u32 *eld = (const u32 *)connector->display_info.eld;enum port port = encoder->port;enum pipe pipe = crtc->pipe;int eld_buffer_size, len, i;
@@ -772,7 +772,7 @@ static void ilk_audio_codec_enable(struct intel_encoder *encoder, IBX_ELD_ADDRESS_MASK, 0); eld_buffer_size =ilk_eld_buffer_size (i915, pipe); - len =min (drm_eld_size (connector->eld) /4 , eld_buffer_size); + len =min (drm_eld_size (connector->display_info.eld) /4 , eld_buffer_size);for (i =0 ; i < len; i++)intel_de_write (i915, regs.hdmiw_hdmiedid, eld[i]);
@@ -837,15 +837,15 @@ void intel_audio_codec_enable(struct intel_encoder *encoder,drm_dbg_kms (&i915->drm,"[CONNECTOR:%d:%s][ENCODER:%d:%s] Enable audio codec on pipe %c, %u bytes ELD\n" , connector->base.id, connector->name, encoder->base.base.id, encoder->base.name, -pipe_name (pipe),drm_eld_size (connector->eld)); +pipe_name (pipe),drm_eld_size (connector->display_info.eld));/* FIXME precompute the ELD in .compute_config() */ -if (!connector->eld[0 ]) +if (!connector->display_info.eld[0 ])drm_dbg_kms (&i915->drm,"Bogus ELD on [CONNECTOR:%d:%s]\n" , connector->base.id, connector->name); - connector->eld[6 ] =drm_av_sync_delay (connector, adjusted_mode) /2 ; + connector->display_info.eld[6 ] =drm_av_sync_delay (connector, adjusted_mode) /2 ;if (i915->display.funcs.audio) i915->display.funcs.audio->audio_codec_enable(encoder,
@@ -868,7 +868,7 @@ void intel_audio_codec_enable(struct intel_encoder *encoder, (int)port, (int)pipe); } -intel_lpe_audio_notify (i915, pipe, port, connector->eld, +intel_lpe_audio_notify (i915, pipe, port, connector->display_info.eld, crtc_state->port_clock,intel_crtc_has_dp_encoder (crtc_state)); }
@@ -1236,7 +1236,7 @@ static int i915_audio_component_get_eld(struct device *kdev, int port, ret =0 ; *enabled = intel_encoder->audio_connector !=NULL ;if (*enabled) { - eld = intel_encoder->audio_connector->eld; + eld = intel_encoder->audio_connector->display_info.eld; ret =drm_eld_size (eld);memcpy (buf, eld,min (max_bytes, ret)); }
drivers/gpu/drm/i915/display/intel_sdvo.c +1 -1
@@ -1756,7 +1756,7 @@ static void intel_sdvo_enable_audio(struct intel_sdvo *intel_sdvo,const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;struct drm_connector *connector = conn_state->connector; -u8 *eld = connector->eld; +u8 *eld = connector->display_info.eld; eld[6 ] =drm_av_sync_delay (connector, adjusted_mode) /2 ;
drivers/gpu/drm/mediatek/mtk_dp.c +1 -1
@@ -2432,7 +2432,7 @@ static int mtk_dp_audio_get_eld(struct device *dev, void *data, uint8_t *buf,struct mtk_dp *mtk_dp =dev_get_drvdata (dev);if (mtk_dp->enabled) -memcpy (buf, mtk_dp->conn->eld, len); +memcpy (buf, mtk_dp->conn->display_info.eld, len);else memset (buf,0 , len);
drivers/gpu/drm/mediatek/mtk_hdmi.c +2 -1
@@ -1634,7 +1634,8 @@ static int mtk_hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf,struct mtk_hdmi *hdmi =dev_get_drvdata (dev);if (hdmi->enabled) -memcpy (buf, hdmi->curr_conn->eld,min (sizeof (hdmi->curr_conn->eld), len)); +memcpy (buf, hdmi->curr_conn->display_info.eld, +min (sizeof (hdmi->curr_conn->display_info.eld), len));else memset (buf,0 , len);return 0 ;
drivers/gpu/drm/msm/dp/dp_audio.c +2 -2
@@ -499,8 +499,8 @@ static int dp_audio_get_eld(struct device *dev,return -ENODEV ; } -memcpy (buf, dp_display->connector->eld, -min (sizeof (dp_display->connector->eld), len)); +memcpy (buf, dp_display->connector->display_info.eld, +min (sizeof (dp_display->connector->display_info.eld), len));return 0 ; }
drivers/gpu/drm/radeon/dce6_afmt.c +6 -6
@@ -134,15 +134,15 @@ void dce6_afmt_write_latency_fields(struct drm_encoder *encoder,return ;if (mode->flags &DRM_MODE_FLAG_INTERLACE ) { -if (connector->latency_present[1 ]) - tmp =VIDEO_LIPSYNC (connector->video_latency[1 ]) | -AUDIO_LIPSYNC (connector->audio_latency[1 ]); +if (connector->display_info.latency_present[1 ]) + tmp =VIDEO_LIPSYNC (connector->display_info.video_latency[1 ]) | +AUDIO_LIPSYNC (connector->display_info.audio_latency[1 ]);else tmp =VIDEO_LIPSYNC (0 ) |AUDIO_LIPSYNC (0 ); }else { -if (connector->latency_present[0 ]) - tmp =VIDEO_LIPSYNC (connector->video_latency[0 ]) | -AUDIO_LIPSYNC (connector->audio_latency[0 ]); +if (connector->display_info.latency_present[0 ]) + tmp =VIDEO_LIPSYNC (connector->display_info.video_latency[0 ]) | +AUDIO_LIPSYNC (connector->display_info.audio_latency[0 ]);else tmp =VIDEO_LIPSYNC (0 ) |AUDIO_LIPSYNC (0 ); }
drivers/gpu/drm/radeon/evergreen_hdmi.c +6 -6
@@ -102,15 +102,15 @@ void dce4_afmt_write_latency_fields(struct drm_encoder *encoder,u32 tmp =0 ;if (mode->flags &DRM_MODE_FLAG_INTERLACE ) { -if (connector->latency_present[1 ]) - tmp =VIDEO_LIPSYNC (connector->video_latency[1 ]) | -AUDIO_LIPSYNC (connector->audio_latency[1 ]); +if (connector->display_info.latency_present[1 ]) + tmp =VIDEO_LIPSYNC (connector->display_info.video_latency[1 ]) | +AUDIO_LIPSYNC (connector->display_info.audio_latency[1 ]);else tmp =VIDEO_LIPSYNC (255 ) |AUDIO_LIPSYNC (255 ); }else { -if (connector->latency_present[0 ]) - tmp =VIDEO_LIPSYNC (connector->video_latency[0 ]) | -AUDIO_LIPSYNC (connector->audio_latency[0 ]); +if (connector->display_info.latency_present[0 ]) + tmp =VIDEO_LIPSYNC (connector->display_info.video_latency[0 ]) | +AUDIO_LIPSYNC (connector->display_info.audio_latency[0 ]);else tmp =VIDEO_LIPSYNC (255 ) |AUDIO_LIPSYNC (255 ); }
drivers/gpu/drm/radeon/radeon_audio.c +2 -2
@@ -769,8 +769,8 @@ static int radeon_audio_component_get_eld(struct device *kdev, int port,if (!connector)continue ; *enabled = true; - ret =drm_eld_size (connector->eld); -memcpy (buf, connector->eld,min (max_bytes, ret)); + ret =drm_eld_size (connector->display_info.eld); +memcpy (buf, connector->display_info.eld,min (max_bytes, ret));break ; }
drivers/gpu/drm/sti/sti_hdmi.c +1 -1
@@ -1220,7 +1220,7 @@ static int hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, sizestruct drm_connector *connector = hdmi->drm_connector;DRM_DEBUG_DRIVER ("\n" ); -memcpy (buf, connector->eld,min (sizeof (connector->eld), len)); +memcpy (buf, connector->display_info.eld,min (sizeof (connector->display_info.eld), len));return 0 ; }
drivers/gpu/drm/vc4/vc4_hdmi.c +1 -1
@@ -2411,7 +2411,7 @@ static int vc4_hdmi_audio_get_eld(struct device *dev, void *data,struct drm_connector *connector = &vc4_hdmi->connector;mutex_lock (&vc4_hdmi->mutex); -memcpy (buf, connector->eld,min (sizeof (connector->eld), len)); +memcpy (buf, connector->display_info.eld,min (sizeof (connector->display_info.eld), len));mutex_unlock (&vc4_hdmi->mutex);return 0 ;
include/drm/drm_connector.h +23 -16
@@ -738,6 +738,29 @@ struct drm_display_info {* @quirks: EDID based quirks. Internal to EDID parsing. */ u32 quirks; + +#define MAX_ELD_BYTES 128 +/** +* @eld: EDID-like data, if present +*/ +u8 eld[MAX_ELD_BYTES ]; + +/** +* @latency_present: AV delay info from ELD, if found +*/ +bool latency_present[2 ]; + +/** +* @video_latency: Video latency info from ELD, if found. +* [0]: progressive, [1]: interlaced +*/ +int video_latency[2 ]; + +/** +* @audio_latency: audio latency info from ELD, if found +* [0]: progressive, [1]: interlaced +*/ +int audio_latency[2 ]; }; int drm_display_info_set_bus_formats(struct drm_display_info *info,
@@ -1685,22 +1708,6 @@ struct drm_connector {*/ struct drm_encoder *encoder; -#define MAX_ELD_BYTES 128 -/** @eld: EDID-like data, if present */ -uint8_t eld[MAX_ELD_BYTES ]; -/** @latency_present: AV delay info from ELD, if found */ -bool latency_present[2 ]; -/** -* @video_latency: Video latency info from ELD, if found. -* [0]: progressive, [1]: interlaced -*/ -int video_latency[2 ]; -/** -* @audio_latency: audio latency info from ELD, if found -* [0]: progressive, [1]: interlaced -*/ -int audio_latency[2 ]; -/** * @ddc: associated ddc adapter. * A connector usually has its associated ddc adapter. If a driver uses
Signature · 1 line
2.34.1
kernel test robot
build botRe: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info
I love your patch! Yet something to improve:
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230124094154.2282778-3-jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info config: arm-defconfig (https://download.01.org/0day-ci/archive/20230124/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1e92b5478cfc1b0df66153652111117e9548b0d5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 git checkout 1e92b5478cfc1b0df66153652111117e9548b0d5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tegra/hdmi.c: In function 'tegra_hdmi_write_eld':
>> drivers/gpu/drm/tegra/hdmi.c:620:60: error: 'struct drm_connector' has no member named 'eld'
620 | size_t length = drm_eld_size(hdmi->output.connector.eld), i;
| ^
drivers/gpu/drm/tegra/hdmi.c:624:72: error: 'struct drm_connector' has no member named 'eld'
624 | tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i],
| ^
--
drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_write_eld':
>> drivers/gpu/drm/tegra/sor.c:1951:59: error: 'struct drm_connector' has no member named 'eld'
1951 | size_t length = drm_eld_size(sor->output.connector.eld), i;
| ^
drivers/gpu/drm/tegra/sor.c:1954:69: error: 'struct drm_connector' has no member named 'eld'
1954 | tegra_sor_writel(sor, i << 8 | sor->output.connector.eld[i],
| ^vim +620 drivers/gpu/drm/tegra/hdmi.c
edec4af4c3d6d2 Thierry Reding 2012-11-15 617
5234549b93aa2a Thierry Reding 2015-08-07 618 static void tegra_hdmi_write_eld(struct tegra_hdmi *hdmi)
5234549b93aa2a Thierry Reding 2015-08-07 619 {
5234549b93aa2a Thierry Reding 2015-08-07 @620 size_t length = drm_eld_size(hdmi->output.connector.eld), i;
5234549b93aa2a Thierry Reding 2015-08-07 621 u32 value;
edec4af4c3d6d2 Thierry Reding 2012-11-15 622
5234549b93aa2a Thierry Reding 2015-08-07 623 for (i = 0; i < length; i++)
5234549b93aa2a Thierry Reding 2015-08-07 624 tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i],
5234549b93aa2a Thierry Reding 2015-08-07 625 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR);
edec4af4c3d6d2 Thierry Reding 2012-11-15 626
5234549b93aa2a Thierry Reding 2015-08-07 627 /*
5234549b93aa2a Thierry Reding 2015-08-07 628 * The HDA codec will always report an ELD buffer size of 96 bytes and
5234549b93aa2a Thierry Reding 2015-08-07 629 * the HDA codec driver will check that each byte read from the buffer
5234549b93aa2a Thierry Reding 2015-08-07 630 * is valid. Therefore every byte must be written, even if no 96 bytes
5234549b93aa2a Thierry Reding 2015-08-07 631 * were parsed from EDID.
5234549b93aa2a Thierry Reding 2015-08-07 632 */
5234549b93aa2a Thierry Reding 2015-08-07 633 for (i = length; i < HDMI_ELD_BUFFER_SIZE; i++)
5234549b93aa2a Thierry Reding 2015-08-07 634 tegra_hdmi_writel(hdmi, i << 8 | 0,
5234549b93aa2a Thierry Reding 2015-08-07 635 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR);
5234549b93aa2a Thierry Reding 2015-08-07 636
5234549b93aa2a Thierry Reding 2015-08-07 637 value = SOR_AUDIO_HDA_PRESENSE_VALID | SOR_AUDIO_HDA_PRESENSE_PRESENT;
5234549b93aa2a Thierry Reding 2015-08-07 638 tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_SOR_AUDIO_HDA_PRESENSE);
edec4af4c3d6d2 Thierry Reding 2012-11-15 639 }
edec4af4c3d6d2 Thierry Reding 2012-11-15 640 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Re: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info
Obviously, I need to still work on this. *looks for brown paper bag*
Quoted 72 lines · kernel test robot
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230124094154.2282778-3-jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info config: arm-defconfig (https://download.01.org/0day-ci/archive/20230124/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1e92b5478cfc1b0df66153652111117e9548b0d5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 git checkout1e92b5478cfc1b0df66153652111117e9548b0d5
# save the config file
mkdirbuild_dir&& cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bashdrivers/gpu/If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tegra/hdmi.c: In function 'tegra_hdmi_write_eld':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/tegra/hdmi.c:620:60: error: 'structdrm_connector' has no member named 'eld'620 | size_t length = drm_eld_size(hdmi->output.connector.eld), i; | ^ drivers/gpu/drm/tegra/hdmi.c:624:72: error: 'struct drm_connector' has no member named 'eld' 624 | tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i], | ^--
drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_write_eld':Quoted 1 line
Quoted 1 line
drivers/gpu/drm/tegra/sor.c:1951:59: error: 'structdrm_connector' has no member named 'eld'1951 | size_t length = drm_eld_size(sor->output.connector.eld), i; | ^ drivers/gpu/drm/tegra/sor.c:1954:69: error: 'struct drm_connector' has no member named 'eld' 1954 | tegra_sor_writel(sor, i << 8 | sor->output.connector.eld[i], | ^vim +620
drivers/gpu/drm/tegra/hdmi.cedec4af4c3d6d2 Thierry Reding 2012-11-15 617 5234549b93aa2a Thierry Reding 2015-08-07 618 static void tegra_hdmi_write_eld(struct tegra_hdmi *hdmi) 5234549b93aa2a Thierry Reding 2015-08-07 619 { 5234549b93aa2a Thierry Reding 2015-08-07 @620 size_t length = drm_eld_size(hdmi->output.connector.eld), i; 5234549b93aa2a Thierry Reding 2015-08-07 621 u32 value; edec4af4c3d6d2 Thierry Reding 2012-11-15 622 5234549b93aa2a Thierry Reding 2015-08-07 623 for (i = 0; i < length; i++) 5234549b93aa2a Thierry Reding 2015-08-07 624 tegra_hdmi_writel(hdmi, i << 8 | hdmi->output.connector.eld[i], 5234549b93aa2a Thierry Reding 2015-08-07 625 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR); edec4af4c3d6d2 Thierry Reding 2012-11-15 626 5234549b93aa2a Thierry Reding 2015-08-07 627 /* 5234549b93aa2a Thierry Reding 2015-08-07 628 * The HDA codec will always report an ELD buffer size of 96 bytes and 5234549b93aa2a Thierry Reding 2015-08-07 629 * the HDA codec driver will check that each byte read from the buffer 5234549b93aa2a Thierry Reding 2015-08-07 630 * is valid. Therefore every byte must be written, even if no 96 bytes 5234549b93aa2a Thierry Reding 2015-08-07 631 * were parsed from EDID. 5234549b93aa2a Thierry Reding 2015-08-07 632 */ 5234549b93aa2a Thierry Reding 2015-08-07 633 for (i = length; i < HDMI_ELD_BUFFER_SIZE; i++) 5234549b93aa2a Thierry Reding 2015-08-07 634 tegra_hdmi_writel(hdmi, i << 8 | 0, 5234549b93aa2a Thierry Reding 2015-08-07 635 HDMI_NV_PDISP_SOR_AUDIO_HDA_ELD_BUFWR); 5234549b93aa2a Thierry Reding 2015-08-07 636 5234549b93aa2a Thierry Reding 2015-08-07 637 value = SOR_AUDIO_HDA_PRESENSE_VALID | SOR_AUDIO_HDA_PRESENSE_PRESENT; 5234549b93aa2a Thierry Reding 2015-08-07 638 tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_SOR_AUDIO_HDA_PRESENSE); edec4af4c3d6d2 Thierry Reding 2012-11-15 639 } edec4af4c3d6d2 Thierry Reding 2012-11-15 640
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
kernel test robot
build botRe: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info
In reply to Jani NikulaI love your patch! Yet something to improve:
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230124094154.2282778-3-jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info config: hexagon-randconfig-r045-20230123 (https://download.01.org/0day-ci/archive/20230124/[email protected]/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1e92b5478cfc1b0df66153652111117e9548b0d5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322
git checkout 1e92b5478cfc1b0df66153652111117e9548b0d5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/gpu/drm/bridge/ drivers/gpu/drm/i2c/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/bridge/sii902x.c:17:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/gpu/drm/bridge/sii902x.c:17:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/gpu/drm/bridge/sii902x.c:17:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> drivers/gpu/drm/bridge/sii902x.c:736:33: error: no member named 'eld' in 'struct drm_connector'
memcpy(buf, sii902x->connector.eld,
~~~~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/bridge/sii902x.c:737:39: error: no member named 'eld' in 'struct drm_connector'
min(sizeof(sii902x->connector.eld), len));
~~~~~~~~~~~~~~~~~~ ^
include/linux/minmax.h:67:33: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^
include/linux/minmax.h:36:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^
include/linux/minmax.h:26:16: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/minmax.h:20:21: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
drivers/gpu/drm/bridge/sii902x.c:737:39: error: no member named 'eld' in 'struct drm_connector'
min(sizeof(sii902x->connector.eld), len));
~~~~~~~~~~~~~~~~~~ ^
include/linux/minmax.h:67:33: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^
include/linux/minmax.h:36:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^
include/linux/minmax.h:26:43: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/minmax.h:23:19: note: expanded from macro '__no_side_effects'
(__is_constexpr(x) && __is_constexpr(y))
^
include/linux/const.h:12:48: note: expanded from macro '__is_constexpr'
(sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
^ 6 warnings and 3 errors generated.
--
In file included from drivers/gpu/drm/i2c/tda998x_drv.c:10:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/gpu/drm/i2c/tda998x_drv.c:10:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/gpu/drm/i2c/tda998x_drv.c:10:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> drivers/gpu/drm/i2c/tda998x_drv.c:1156:30: error: no member named 'eld' in 'struct drm_connector'
memcpy(buf, priv->connector.eld,
~~~~~~~~~~~~~~~ ^
drivers/gpu/drm/i2c/tda998x_drv.c:1157:36: error: no member named 'eld' in 'struct drm_connector'
min(sizeof(priv->connector.eld), len));
~~~~~~~~~~~~~~~ ^
include/linux/minmax.h:67:33: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^
include/linux/minmax.h:36:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^
include/linux/minmax.h:26:16: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/minmax.h:20:21: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
drivers/gpu/drm/i2c/tda998x_drv.c:1157:36: error: no member named 'eld' in 'struct drm_connector'
min(sizeof(priv->connector.eld), len));
~~~~~~~~~~~~~~~ ^
include/linux/minmax.h:67:33: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^
include/linux/minmax.h:36:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^
include/linux/minmax.h:26:43: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/minmax.h:23:19: note: expanded from macro '__no_side_effects'
(__is_constexpr(x) && __is_constexpr(y))
^
include/linux/const.h:12:48: note: expanded from macro '__is_constexpr'
(sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
^6 warnings and 3 errors generated.
vim +736 drivers/gpu/drm/bridge/sii902x.c
ff5781634c4116 Jyri Sarha 2019-05-27 728
ff5781634c4116 Jyri Sarha 2019-05-27 729 static int sii902x_audio_get_eld(struct device *dev, void *data,
ff5781634c4116 Jyri Sarha 2019-05-27 730 uint8_t *buf, size_t len)
ff5781634c4116 Jyri Sarha 2019-05-27 731 {
ff5781634c4116 Jyri Sarha 2019-05-27 732 struct sii902x *sii902x = dev_get_drvdata(dev);
ff5781634c4116 Jyri Sarha 2019-05-27 733
ff5781634c4116 Jyri Sarha 2019-05-27 734 mutex_lock(&sii902x->mutex);
ff5781634c4116 Jyri Sarha 2019-05-27 735
ff5781634c4116 Jyri Sarha 2019-05-27 @736 memcpy(buf, sii902x->connector.eld,
ff5781634c4116 Jyri Sarha 2019-05-27 737 min(sizeof(sii902x->connector.eld), len));
ff5781634c4116 Jyri Sarha 2019-05-27 738
ff5781634c4116 Jyri Sarha 2019-05-27 739 mutex_unlock(&sii902x->mutex);
ff5781634c4116 Jyri Sarha 2019-05-27 740
ff5781634c4116 Jyri Sarha 2019-05-27 741 return 0;
ff5781634c4116 Jyri Sarha 2019-05-27 742 }
ff5781634c4116 Jyri Sarha 2019-05-27 743 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
URL : https://patchwork.freedesktop.org/series/113256/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
URL : https://patchwork.freedesktop.org/series/113256/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12627 -> Patchwork_113256v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/index.html
Participating hosts (41 -> 39)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113256v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/fi-pnv-d510/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@guc:
- {bat-rpls-2}: [DMESG-WARN][3] ([i915#7852]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/bat-rpls-2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@hangcheck:
- {bat-dg1-7}: [INCOMPLETE][5] ([i915#4983]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/bat-dg1-7/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/bat-dg1-7/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][7] ([i915#7699]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/bat-dg2-11/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/bat-dg2-11/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][9] ([i915#4983]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/bat-rpls-1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
Build changes
-------------
* Linux: CI_DRM_12627 -> Patchwork_113256v1
CI-20190529: 20190529
CI_DRM_12627: a89114c496133077159d90f4ffc0ab3a5e6e89c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7136: 31b6af91747ad8c705399c9006cdb81cb1864146 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113256v1: a89114c496133077159d90f4ffc0ab3a5e6e89c0 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
b65b2b13e778 drm/connector: move ELD and video/audio latencies to display info 508746392003 drm/connector: move HDR sink metadata to display info c0a969b6932d drm/edid: reverse display info preserve/clear logic, defaulting to clear
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/edid: reverse display info preserve/clear logic, defaulting to clear
URL : https://patchwork.freedesktop.org/series/113256/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12627_full -> Patchwork_113256v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/index.html
Participating hosts (13 -> 11)
------------------------------
Missing (2): pig-skl-6260u pig-kbl-iris
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113256v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_rotation_crc@sprite-rotation-270:
- {shard-rkl}: [SKIP][1] ([i915#1845] / [i915#4098]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@[email protected]
* igt@perf_pmu@module-unload:
- {shard-tglu-10}: NOTRUN -> [DMESG-WARN][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-tglu-10/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113256v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-glk4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk4/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-glk9/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271]) +39 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#79])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-glk1/igt@kms_flip@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk5/igt@kms_flip@[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@idle@rcs0:
- {shard-rkl}: [FAIL][14] ([i915#7742]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-4/igt@drm_fdinfo@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-3/igt@drm_fdinfo@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-5/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-glk6/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][20] ([i915#3281]) -> [PASS][21] +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@write-display:
- {shard-rkl}: [SKIP][22] ([i915#3282]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-start-param:
- {shard-rkl}: [SKIP][24] ([i915#2527]) -> [PASS][25] +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-rkl}: [WARN][26] ([i915#2681]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-5/igt@i915_pm_rc6_residency@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-1/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][28] ([fdo#109308]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- {shard-tglu}: [SKIP][30] ([i915#1845] / [i915#7651]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-tglu-6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-tglu-3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][32] ([i915#2346]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-glk6/igt@kms_cursor_legacy@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-glk9/igt@kms_cursor_legacy@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack-mmap-gtt:
- {shard-tglu}: [SKIP][34] ([i915#1849]) -> [PASS][35] +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-tglu-6/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-tglu-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- {shard-rkl}: [SKIP][36] ([i915#1849] / [i915#4098]) -> [PASS][37] +5 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-panning-top-left@pipe-a-planes:
- {shard-rkl}: [SKIP][38] ([i915#1849]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@kms_plane@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][40] ([i915#1072]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@kms_psr@sprite_plane_onoff.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- {shard-rkl}: [SKIP][42] ([i915#5461]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@[email protected]
* igt@kms_pwrite_crc:
- {shard-rkl}: [SKIP][44] ([i915#1845] / [i915#4098]) -> [PASS][45] +6 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-2/igt@kms_pwrite_crc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-6/igt@kms_pwrite_crc.html
* igt@kms_vblank@invalid:
- {shard-tglu}: [SKIP][46] ([i915#7651]) -> [PASS][47] +6 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-tglu-6/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-tglu-3/igt@[email protected]
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][48] ([i915#4349]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12627/shard-rkl-1/igt@perf_pmu@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/shard-rkl-5/igt@perf_pmu@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
Build changes
-------------
* Linux: CI_DRM_12627 -> Patchwork_113256v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12627: a89114c496133077159d90f4ffc0ab3a5e6e89c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7136: 31b6af91747ad8c705399c9006cdb81cb1864146 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113256v1: a89114c496133077159d90f4ffc0ab3a5e6e89c0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113256v1/index.html