cxl/mbox: Add debug messages for enabled mailbox commands
PATCH v2 1/1 cxl/mbox: Add debug messages for enabled mailbox commands
Only unsupported mailbox commands are reported in debug messages. A list of enabled commands is useful too. Change debug messages to also report the opcodes of enabled commands. Esp. if card initialization fails there is no way to get this information from userland.
On that occasion also add missing trailing newlines.
---
v2:
* Changed message to "Opcode 0x%04x enabled\n". Updated patch description accordingly.
drivers/cxl/core/mbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cxl/core/mbox.c +2 -1
@@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)if (!cmd) {dev_dbg (cxlds->dev, -"Opcode 0x%04x unsupported by driver" , opcode); +"Opcode 0x%04x unsupported by driver\n" , opcode);continue ; }set_bit (cmd->info.id, cxlds->enabled_cmds); +dev_dbg (cxlds->dev,"Opcode 0x%04x enabled\n" , opcode); } }
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
Signature · 1 line
2.30.2
Quoted 8 lines · On Wed, 25 Jan 2023 09:57:28 +0100 Robert Richter <[email protected]> wrote:
Only unsupported mailbox commands are reported in debug messages. A list of enabled commands is useful too. Change debug messages to also report the opcodes of enabled commands. Esp. if card initialization fails there is no way to get this information from userland.
On that occasion also add missing trailing newlines.
Signed-off-by Robert Richter <[email protected]>
Fine with change in message
Quoted 28 lines
---
v2:
* Changed message to "Opcode 0x%04x enabled\n". Updated patch description accordingly.drivers/cxl/core/mbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/cxl/core/mbox.c +2
-1@@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)if (!cmd) {dev_dbg (cxlds->dev, -"Opcode 0x%04x unsupported by driver" , opcode); +"Opcode 0x%04x unsupported by driver\n" , opcode);continue ; }set_bit (cmd->info.id, cxlds->enabled_cmds); +dev_dbg (cxlds->dev,"Opcode 0x%04x enabled\n" , opcode); } }base-commit:
1b929c02afd37871d5afb9d498426f83432e71c2
Quoted 5 lines · Robert Richter
Only unsupported mailbox commands are reported in debug messages. A list of enabled commands is useful too. Change debug messages to also report the opcodes of enabled commands. Esp. if card initialization fails there is no way to get this information from userland.
Quoted 7 lines
On that occasion also add missing trailing newlines.
Signed-off-by Robert Richter <[email protected]>---
v2:
* Changed message to "Opcode 0x%04x enabled\n". Updated patch description accordingly.
Thanks Robert,
Quoted 27 lines
drivers/cxl/core/mbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/cxl/core/mbox.c +2
-1@@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)if (!cmd) {dev_dbg (cxlds->dev, -"Opcode 0x%04x unsupported by driver" , opcode); +"Opcode 0x%04x unsupported by driver\n" , opcode);continue ; }set_bit (cmd->info.id, cxlds->enabled_cmds); +dev_dbg (cxlds->dev,"Opcode 0x%04x enabled\n" , opcode); } }base-commit:
1b929c02afd37871d5afb9d498426f83432e71c2Signature · 1 line
2.30.2
Quoted 5 lines · Robert Richter
Only unsupported mailbox commands are reported in debug messages. A list of enabled commands is useful too. Change debug messages to also report the opcodes of enabled commands. Esp. if card initialization fails there is no way to get this information from userland.
Quoted 7 lines
On that occasion also add missing trailing newlines.
Signed-off-by Robert Richter <[email protected]>---
v2:
* Changed message to "Opcode 0x%04x enabled\n". Updated patch description accordingly.
Thanks Robert, replaced v1 with v2 in my tree. Should show up on cxl/pending shortly.