vfio-mdev: add back CONFIG_VFIO dependency
PATCH 1/1 vfio-mdev: add back CONFIG_VFIO dependency
From: Arnd Bergmann <[email protected]>
CONFIG_VFIO_MDEV cannot be selected when VFIO itself is disabled, otherwise we get a link failure:
WARNING: unmet direct dependencies detected for VFIO_MDEV
Depends on [n]: VFIO [=n]
Selected by [y]:
- SAMPLE_VFIO_MDEV_MTTY [=y] && SAMPLES [=y]
- SAMPLE_VFIO_MDEV_MDPY [=y] && SAMPLES [=y]
- SAMPLE_VFIO_MDEV_MBOCHS [=y] && SAMPLES [=y]/home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld: samples/vfio-mdev/mdpy.o: in function `mdpy_remove':
mdpy.c:(.text+0x1e1): undefined reference to vfio_unregister_group_dev' /home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld: samples/vfio-mdev/mdpy.o: in function mdpy_probe':
mdpy.c:(.text+0x149e): undefined reference to `_vfio_alloc_device'
--- samples/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
samples/Kconfig +3 -0
@@ -185,6 +185,7 @@ config SAMPLE_UHID config SAMPLE_VFIO_MDEV_MTTY tristate "Build VFIO mtty example mediated device sample code" + depends on VFIO select VFIO_MDEV help Build a virtual tty sample driver for use as a VFIO
@@ -192,6 +193,7 @@ config SAMPLE_VFIO_MDEV_MTTY config SAMPLE_VFIO_MDEV_MDPY tristate "Build VFIO mdpy example mediated device sample code" + depends on VFIO select VFIO_MDEV help Build a virtual display sample driver for use as a VFIO
@@ -209,6 +211,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB config SAMPLE_VFIO_MDEV_MBOCHS tristate "Build VFIO mdpy example mediated device sample code" + depends on VFIO select VFIO_MDEV select DMA_SHARED_BUFFER help
Signature · 1 line
2.39.0
Quoted 16 lines · On Thu, 26 Jan 2023 17:37:06 +0100 Arnd Bergmann <[email protected]> wrote:
From: Arnd Bergmann <[email protected]>
CONFIG_VFIO_MDEVcannot be selected when VFIO itself is disabled, otherwise we get a link failure:WARNING: unmet direct dependencies detected for
VFIO_MDEV
Depends on [n]: VFIO [=n]
Selected by [y]:
-SAMPLE_VFIO_MDEV_MTTY[=y] && SAMPLES [=y]
-SAMPLE_VFIO_MDEV_MDPY[=y] && SAMPLES [=y]
-SAMPLE_VFIO_MDEV_MBOCHS[=y] && SAMPLES [=y]/home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld:samples/vfio-mdev/mdpy.o: in function `mdpy_remove':
mdpy.c:(.text+0x1e1): undefined reference tovfio_unregister_group_dev' /home/arnd/cross/arm64/gcc-13.0.1-nolibc/x86_64-linux/bin/x86_64-linux-ld: samples/vfio-mdev/mdpy.o: in functionmdpy_probe':
mdpy.c:(.text+0x149e): undefined reference to `_vfio_alloc_device'
Quoted 5 lines
Fixes 8bf8c5ee1f38 ("vfio-mdev: turn VFIO_MDEV into a selectable symbol")Signed-off-by Arnd Bergmann <[email protected]>--- samples/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
Seems like it wouldn't just be the sample drivers with this issue, don't VFIO_CCW, VFIO_AP, and DRM_I915_GVT_KVMGT all have this problem? Thanks,
Alex
Quoted 29 lines
samples/Kconfig +3
-0@@ -185,6 +185,7 @@ config SAMPLE_UHID config SAMPLE_VFIO_MDEV_MTTY tristate "Build VFIO mtty example mediated device sample code" + depends on VFIO select VFIO_MDEV help Build a virtual tty sample driver for use as a VFIO@@ -192,6 +193,7 @@ config SAMPLE_VFIO_MDEV_MTTY config SAMPLE_VFIO_MDEV_MDPY tristate "Build VFIO mdpy example mediated device sample code" + depends on VFIO select VFIO_MDEV help Build a virtual display sample driver for use as a VFIO@@ -209,6 +211,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB config SAMPLE_VFIO_MDEV_MBOCHS tristate "Build VFIO mdpy example mediated device sample code" + depends on VFIO select VFIO_MDEV select DMA_SHARED_BUFFER help
Quoted 3 lines · Alex Williamson
Seems like it wouldn't just be the sample drivers with this issue, don't
VFIO_CCW,VFIO_AP, andDRM_I915_GVT_KVMGTall have this problem? Thanks,
Yes, they all need to depend on VFIO.
Should I resend the series with that fixed?
Quoted 8 lines · On Thu, 26 Jan 2023 18:40:44 +0100 Christoph Hellwig <[email protected]> wrote:
Quoted 3 lines · Alex Williamson
Seems like it wouldn't just be the sample drivers with this issue, don't
VFIO_CCW,VFIO_AP, andDRM_I915_GVT_KVMGTall have this problem? Thanks,Yes, they all need to depend on VFIO.
Should I resend the series with that fixed?
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Alex
Quoted 3 lines · Alex Williamson
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Arnd, do you plan to resend the patch, or should I take care of it?
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Alex Williamson
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Arnd, do you plan to resend the patch, or should I take care of it?
I sent the v2 last week, it looks like I forgot to add you to Cc there:
https://lore.kernel.org/all/[email protected]/
Arnd
Quoted 11 lines · Arnd Bergmann
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Alex Williamson
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Arnd, do you plan to resend the patch, or should I take care of it?
I sent the v2 last week, it looks like I forgot to add you to Cc there:
I just tried again and see that neither my own script nor the normal scripts/get_maintainer.pl picks up the [email protected] address from the Signed-off-by line in the "Fixes" commit, though it does pick up the addresses from Jason, Tony and Alex. I have no idea what is going on there.
arnd
Quoted 11 lines · Arnd Bergmann
Quoted 10 lines · Arnd Bergmann
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Alex Williamson
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Arnd, do you plan to resend the patch, or should I take care of it?
I sent the v2 last week, it looks like I forgot to add you to Cc there:
Quoted 7 lines
Quoted 1 line
I just tried again and see that neither my own script nor the normal
scripts/get_maintainer.plpicks up the [email protected] address from the Signed-off-by line in the "Fixes" commit, though it does pick up the addresses from Jason, Tony and Alex. I have no idea what is going on there.
Christoph is in .get_maintainer.ignore
Jason
Quoted 11 lines · On Mon, 30 Jan 2023 14:34:54 +0100 "Arnd Bergmann" <[email protected]> wrote:
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Alex Williamson
The culprit is already in my next branch, we just need a fix that includes all the cases. A respin of Arnd's patch would be preferable to keep the fixes in one place. Thanks,
Arnd, do you plan to resend the patch, or should I take care of it?
I sent the v2 last week, it looks like I forgot to add you to Cc there:
Thanks for the v2, Arnd. Last call for any acks on the above, this is setting off too many build failures. Thanks,
Alex