Skip to contentSkip to conversation

docs/about/deprecated: Mark HAXM in QEMU as deprecated

PATCH In review Thomas Huth 2 participants 2 messages Jan 26, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 docs/about/deprecated: Mark HAXM in QEMU as deprecated

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

---
v2: Added a message to hax_accel_init(), too

 docs/about/deprecated.rst | 6 ++++++
 target/i386/hax/hax-all.c | 3 +++
 2 files changed, 9 insertions(+)
docs/about/deprecated.rst +6 -0
index 3f4d678eb4..da2e6fe63d 100644
@@ -93,6 +93,12 @@ form is preferred.
 The HPET setting has been turned into a machine property.
 Use ``-machine hpet=off`` instead.
 
+``-accel hax`` (since 8.0)
+''''''''''''''''''''''''''
+
+The HAXM project has been retired (see https://github.com/intel/haxm#status).
+Use "whpx" (on Windows) or "hvf" (on macOS) instead.
+
 
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
target/i386/hax/hax-all.c +3 -0
index b7fb5385b2..3e5992a63b 100644
@@ -357,6 +357,9 @@ static int hax_accel_init(MachineState *ms)
         fprintf(stdout, "HAX is %s and emulator runs in %s mode.\n",
                 !ret ? "working" : "not working",
                 !ret ? "fast virt" : "emulation");
+        fprintf(stdout,
+                "NOTE: HAX is deprecated and will be removed in a future release.\n"
+                "      Use 'whpx' (on Windows) or 'hvf' (on macOS) instead.\n");
     }
     return ret;
 }
Signature · 1 line
2.31.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · Thomas Huth

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

Quoted 7 lines

---
v2: Added a message to hax_accel_init(), too

 docs/about/deprecated.rst | 6 ++++++
 target/i386/hax/hax-all.c | 3 +++
 2 files changed, 9 insertions(+)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|