Allow error capture without a request & fix locking issues
Subsystems (2)
v6 cover Allow error capture without a request & fix locking issues
From: John Harrison <[email protected]>
It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing.
Similarly, in the case of an engine reset failure the GuC is not able to report the guilty context. So try a manual search instead of reporting nothing.
While doing all this, it was noticed that the locking was broken in a number of places when searching for hung requests and dumping request info. So fix all that up as well.
v2: Tidy up code flow in error capture. Reword some comments/messages. (review feedback from Tvrtko)
Also fix up request locking issues from earlier changes noticed during code review of this change.
v3: Fix some potential null pointer derefs and a reference leak. Add new patch to refactor the duplicated hung request search code into a common backend agnostic wrapper function and use the correct spinlocks for the correct lists. Also tweak some of the patch descriptions for better accuracy.
v4: Shuffle some code around to more appropriate source files. Fix potential leak of GuC capture object after code flow re-org and pull improved info message earlier (Daniele). Also rename the GuC capture object to be more consistent.
v5: Split one self contained locking fix out into a separate patch and rename a function to be shorter (Tvrtko).
v6: s/locking/reference counting/ in message of patch #2 (Tvrtko)
John Harrison (8):
drm/i915/guc: Fix locking when searching for a hung request drm/i915: Fix request ref counting during error capture & debugfs dump drm/i915: Fix up locking around dumping requests lists drm/i915: Allow error capture without a request
drm/i915: Allow error capture of a pending request drm/i915/guc: Look for a guilty context when an engine reset fails drm/i915/guc: Add a debug print on GuC triggered reset drm/i915/guc: Rename GuC register state capture node to be more
obvious
drivers/gpu/drm/i915/gt/intel_context.c | 4 +- drivers/gpu/drm/i915/gt/intel_context.h | 3 +- drivers/gpu/drm/i915/gt/intel_engine.h | 4 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 74 ++++++++------- .../drm/i915/gt/intel_execlists_submission.c | 27 ++++++ .../drm/i915/gt/intel_execlists_submission.h | 4 + .../gpu/drm/i915/gt/uc/intel_guc_capture.c | 8 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 35 ++++++- drivers/gpu/drm/i915/i915_gpu_error.c | 92 ++++++++++--------- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 10 files changed, 160 insertions(+), 93 deletions(-)
Signature · 1 line
2.39.1
PATCH v6 1/8 drm/i915/guc: Fix locking when searching for a hung request
From: John Harrison <[email protected]>
intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up. While at it, add some extra whitespace padding for readability.
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +11 -0
@@ -4820,6 +4820,8 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)xa_lock_irqsave (&guc->context_lookup, flags);xa_for_each (&guc->context_lookup, index, ce) { +bool found; +if (!kref_get_unless_zero (&ce->ref))continue ;
@@ -4836,10 +4838,18 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine) goto next; } + found = false; +spin_lock (&ce->guc_state.lock);list_for_each_entry (rq, &ce->guc_state.requests, sched.link) {if (i915_test_request_state (rq) !=I915_REQUEST_ACTIVE )continue ; + found = true; +break ; + } +spin_unlock (&ce->guc_state.lock); + +if (found) {intel_engine_set_hung_context (engine, ce);/* Can only cope with one hang at a time... */
@@ -4847,6 +4857,7 @@ void intel_guc_find_hung_context(struct intel_engine_cs *engine)xa_lock (&guc->context_lookup); goto done; } + next:intel_context_put (ce);xa_lock (&guc->context_lookup);
Signature · 1 line
2.39.1
PATCH v6 2/8 drm/i915: Fix request ref counting during error capture & debugfs dump
In reply to [email protected]From: John Harrison <[email protected]>
When GuC support was added to error capture, the reference counting around the request object was broken. Fix it up.
The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based search relies on external locking, so it needs an external reference count but within the spinlock not outside it.
The only other caller of the context based search is the code for dumping engine state to debugfs. That code wasn't previously getting an explicit reference at all as it does everything while holding the execlist specific spinlock. So, that needs updaing as well as that spinlock doesn't help when using GuC submission. Rather than trying to conditionally get/put depending on submission model, just change it to always do the get/put.
v2: Explicitly document adding an extra blank line in some dense code (Andy Shevchenko). Fix multiple potential null pointer derefs in case of no request found (some spotted by Tvrtko, but there was more!). Also fix a leaked request in case of !started and another in __guc_reset_context now that intel_context_find_active_request is actually reference counting the returned request.
v3: Add a _get suffix to intel_context_find_active_request now that it grabs a reference (Daniele).
v4: Split the intel_guc_find_hung_context change to a separate patch and rename intel_context_find_active_request_get to intel_context_get_active_request (Tvrtko).
v5: s/locking/reference counting/ in commit message (Tvrtko)
--- drivers/gpu/drm/i915/gt/intel_context.c | 4 +++- drivers/gpu/drm/i915/gt/intel_context.h | 3 +-- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +++++- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 3 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 13 ++++++------- 5 files changed, 17 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +3 -1
@@ -528,7 +528,7 @@ struct i915_request *intel_context_create_request(struct intel_context *ce)return rq; } -struct i915_request *intel_context_find_active_request (struct intel_context *ce) +struct i915_request *intel_context_get_active_request (struct intel_context *ce) {struct intel_context *parent =intel_context_to_parent (ce);struct i915_request *rq, *active =NULL ;
@@ -552,6 +552,8 @@ struct i915_request *intel_context_find_active_request(struct intel_context *ce) active = rq; } +if (active) + active =i915_request_get_rcu (active);spin_unlock_irqrestore (&parent->guc_state.lock, flags);return active;
drivers/gpu/drm/i915/gt/intel_context.h +1 -2
@@ -268,8 +268,7 @@ int intel_context_prepare_remote_request(struct intel_context *ce,struct i915_request *intel_context_create_request (struct intel_context *ce); -struct i915_request * -intel_context_find_active_request (struct intel_context *ce); +struct i915_request *intel_context_get_active_request (struct intel_context *ce);static inline bool intel_context_is_barrier (const struct intel_context *ce) {
drivers/gpu/drm/i915/gt/intel_engine_cs.c +5 -1
@@ -2237,9 +2237,11 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct dif (guc) { ce =intel_engine_get_hung_context (engine);if (ce) - hung_rq =intel_context_find_active_request (ce); + hung_rq =intel_context_get_active_request (ce); }else { hung_rq =intel_engine_execlist_find_hung_request (engine); +if (hung_rq) + hung_rq =i915_request_get_rcu (hung_rq); }if (hung_rq)
@@ -2250,6 +2252,8 @@ static void engine_dump_active_requests(struct intel_engine_cs *engine, struct delse intel_engine_dump_active_requests (&engine->sched_engine->requests, hung_rq, m); +if (hung_rq) +i915_request_put (hung_rq); } void intel_engine_dump(struct intel_engine_cs *engine,
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 -1
@@ -1702,7 +1702,7 @@ static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t st goto next_context; guilty = false; - rq =intel_context_find_active_request (ce); + rq =intel_context_get_active_request (ce);if (!rq) { head = ce->ring->tail; goto out_replay;
@@ -1715,6 +1715,7 @@ static void __guc_reset_context(struct intel_context *ce, intel_engine_mask_t st head =intel_ring_wrap (ce->ring, rq->head);__i915_request_reset (rq, guilty); +i915_request_put (rq); out_replay:guc_reset_state (ce, head, guilty); next_context:
drivers/gpu/drm/i915/i915_gpu_error.c +6 -7
@@ -1607,7 +1607,7 @@ capture_engine(struct intel_engine_cs *engine, ce =intel_engine_get_hung_context (engine);if (ce) {intel_engine_clear_hung_context (engine); - rq =intel_context_find_active_request (ce); + rq =intel_context_get_active_request (ce);if (!rq || !i915_request_started (rq)) goto no_request_capture; }else {
@@ -1618,21 +1618,18 @@ capture_engine(struct intel_engine_cs *engine,if (!intel_uc_uses_guc_submission (&engine->gt->uc)) {spin_lock_irqsave (&engine->sched_engine->lock, flags); rq =intel_engine_execlist_find_hung_request (engine); +if (rq) + rq =i915_request_get_rcu (rq);spin_unlock_irqrestore (&engine->sched_engine->lock, flags); } } -if (rq) - rq =i915_request_get_rcu (rq); -if (!rq) goto no_request_capture; capture =intel_engine_coredump_add_request (ee, rq,ATOMIC_MAYFAIL ); -if (!capture) { -i915_request_put (rq); +if (!capture) goto no_request_capture; - }if (dump_flags &CORE_DUMP_FLAG_IS_GUC_CAPTURE )intel_guc_capture_get_matching_node (engine->gt, ee, ce);
@@ -1642,6 +1639,8 @@ capture_engine(struct intel_engine_cs *engine,return ee; no_request_capture: +if (rq) +i915_request_put (rq);kfree (ee);return NULL ; }
Signature · 1 line
2.39.1
PATCH v6 3/8 drm/i915: Fix up locking around dumping requests lists
In reply to [email protected]From: John Harrison <[email protected]>
The debugfs dump of requests was confused about what state requires the execlist lock versus the GuC lock. There was also a bunch of duplicated messy code between it and the error capture code.
So refactor the hung request search into a re-usable function. And reduce the span of the execlist state lock to only the execlist specific code paths. In order to do that, also move the report of hold count (which is an execlist only concept) from the top level dump function to the lower level execlist specific function. Also, move the execlist specific code into the execlist source file.
v2: Rename some functions and move to more appropriate files (Daniele).
v3: Rename new execlist dump function (Daniele)
--- drivers/gpu/drm/i915/gt/intel_engine.h | 4 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 74 +++++++++---------- .../drm/i915/gt/intel_execlists_submission.c | 27 +++++++ .../drm/i915/gt/intel_execlists_submission.h | 4 + drivers/gpu/drm/i915/i915_gpu_error.c | 26 +------ 5 files changed, 73 insertions(+), 62 deletions(-)
drivers/gpu/drm/i915/gt/intel_engine.h +2 -2
@@ -250,8 +250,8 @@ void intel_engine_dump_active_requests(struct list_head *requests,ktime_t intel_engine_get_busy_time (struct intel_engine_cs *engine,ktime_t *now); -struct i915_request * -intel_engine_execlist_find_hung_request (struct intel_engine_cs *engine); +void intel_engine_get_hung_entity (struct intel_engine_cs *engine, +struct intel_context **ce,struct i915_request **rq);u32 intel_engine_context_size (struct intel_gt *gt,u8 class); struct intel_context *
drivers/gpu/drm/i915/gt/intel_engine_cs.c +37 -37
128 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_execlists_submission.c +27 -0
@@ -4150,6 +4150,33 @@ void intel_execlists_show_requests(struct intel_engine_cs *engine,spin_unlock_irqrestore (&sched_engine->lock, flags); } +static unsigned long list_count (struct list_head *list) +{ +struct list_head *pos; +unsigned long count =0 ; + +list_for_each (pos, list) + count++; + +return count; +} + +void intel_execlists_dump_active_requests (struct intel_engine_cs *engine, +struct i915_request *hung_rq, +struct drm_printer *m) +{ +unsigned long flags; + +spin_lock_irqsave (&engine->sched_engine->lock, flags); + +intel_engine_dump_active_requests (&engine->sched_engine->requests, hung_rq, m); + +drm_printf (m,"\tOn hold?: %lu\n" , +list_count (&engine->sched_engine->hold)); + +spin_unlock_irqrestore (&engine->sched_engine->lock, flags); +} +#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )#include "selftest_execlists.c" #endif
drivers/gpu/drm/i915/gt/intel_execlists_submission.h +4 -0
@@ -32,6 +32,10 @@ void intel_execlists_show_requests(struct intel_engine_cs *engine, int indent), unsigned int max); +void intel_execlists_dump_active_requests (struct intel_engine_cs *engine, +struct i915_request *hung_rq, +struct drm_printer *m); +bool intel_engine_in_execlists_submission_mode (const struct intel_engine_cs *engine);
drivers/gpu/drm/i915/i915_gpu_error.c +3 -23
@@ -1596,35 +1596,15 @@ capture_engine(struct intel_engine_cs *engine, {struct intel_engine_capture_vma *capture =NULL ;struct intel_engine_coredump *ee; -struct intel_context *ce; +struct intel_context *ce =NULL ;struct i915_request *rq =NULL ; -unsigned long flags; ee =intel_engine_coredump_alloc (engine,ALLOW_FAIL , dump_flags);if (!ee)return NULL ; - ce =intel_engine_get_hung_context (engine); -if (ce) { -intel_engine_clear_hung_context (engine); - rq =intel_context_get_active_request (ce); -if (!rq || !i915_request_started (rq)) - goto no_request_capture; - }else { -/* -* Getting here with GuC enabled means it is a forced error capture -* with no actual hang. So, no need to attempt the execlist search. -*/ -if (!intel_uc_uses_guc_submission (&engine->gt->uc)) { -spin_lock_irqsave (&engine->sched_engine->lock, flags); - rq =intel_engine_execlist_find_hung_request (engine); -if (rq) - rq =i915_request_get_rcu (rq); -spin_unlock_irqrestore (&engine->sched_engine->lock, - flags); - } - } -if (!rq) +intel_engine_get_hung_entity (engine, &ce, &rq); +if (!rq || !i915_request_started (rq)) goto no_request_capture; capture =intel_engine_coredump_add_request (ee, rq,ATOMIC_MAYFAIL );
Signature · 1 line
2.39.1
PATCH v6 4/8 drm/i915: Allow error capture without a request
In reply to [email protected]From: John Harrison <[email protected]>
There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active requests. For example, if the hang was in the context switch itself then the breadcrumb write would have occurred and the KMD would see an idle context.
In the interests of attempting to provide as much information as possible about a hang, it seems wise to include the engine info regardless of whether a request was found or not. As opposed to just prentending there was no hang at all.
So update the error capture code to always record engine information if a context is given. Which means updating record_context() to take a context instead of a request (which it only ever used to find the context anyway). And split the request agnostic parts of intel_engine_coredump_add_request() out into a seaprate function.
v2: Remove a duplicate 'if' statement (Umesh) and fix a put of a null pointer.
v3: Tidy up request locking code flow (Tvrtko)
v4: Pull in improved info message from next patch and fix up potential leak of GuC register state (Daniele)
--- drivers/gpu/drm/i915/i915_gpu_error.c | 74 ++++++++++++++++++--------- 1 file changed, 50 insertions(+), 24 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +50 -24
@@ -1370,14 +1370,14 @@ static void engine_record_execlists(struct intel_engine_coredump *ee) }static bool record_context (struct i915_gem_context_coredump *e, -const struct i915_request *rq) +struct intel_context *ce) {struct i915_gem_context *ctx;struct task_struct *task;bool simulated;rcu_read_lock (); - ctx =rcu_dereference (rq->context->gem_context); + ctx =rcu_dereference (ce->gem_context);if (ctx && !kref_get_unless_zero (&ctx->ref)) ctx =NULL ;rcu_read_unlock ();
@@ -1396,8 +1396,8 @@ static bool record_context(struct i915_gem_context_coredump *e, e->guilty =atomic_read (&ctx->guilty_count); e->active =atomic_read (&ctx->active_count); - e->total_runtime =intel_context_get_total_runtime_ns (rq->context); - e->avg_runtime =intel_context_get_avg_runtime_ns (rq->context); + e->total_runtime =intel_context_get_total_runtime_ns (ce); + e->avg_runtime =intel_context_get_avg_runtime_ns (ce); simulated =i915_gem_context_no_error_capture (ctx);
@@ -1532,15 +1532,37 @@ intel_engine_coredump_alloc(struct intel_engine_cs *engine, gfp_t gfp, u32 dump_return ee; } +static struct intel_engine_capture_vma * +engine_coredump_add_context (struct intel_engine_coredump *ee, +struct intel_context *ce, +gfp_t gfp) +{ +struct intel_engine_capture_vma *vma =NULL ; + + ee->simulated |=record_context (&ee->context, ce); +if (ee->simulated) +return NULL ; + +/* +* We need to copy these to an anonymous buffer +* as the simplest method to avoid being overwritten +* by userspace. +*/ + vma =capture_vma (vma, ce->ring->vma,"ring" , gfp); + vma =capture_vma (vma, ce->state,"HW context" , gfp); + +return vma; +} +struct intel_engine_capture_vma *intel_engine_coredump_add_request (struct intel_engine_coredump *ee,struct i915_request *rq,gfp_t gfp) { -struct intel_engine_capture_vma *vma =NULL ; +struct intel_engine_capture_vma *vma; - ee->simulated |=record_context (&ee->context, rq); -if (ee->simulated) + vma =engine_coredump_add_context (ee, rq->context, gfp); +if (!vma)return NULL ;/*
@@ -1550,8 +1572,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,*/ vma =capture_vma_snapshot (vma, rq->batch_res, gfp,"batch" ); vma =capture_user (vma, rq, gfp); - vma =capture_vma (vma, rq->ring->vma,"ring" , gfp); - vma =capture_vma (vma, rq->context->state,"HW context" , gfp); ee->rq_head = rq->head; ee->rq_post = rq->postfix;
@@ -1604,25 +1624,31 @@ capture_engine(struct intel_engine_cs *engine,return NULL ;intel_engine_get_hung_entity (engine, &ce, &rq); -if (!rq || !i915_request_started (rq)) - goto no_request_capture; +if (rq && !i915_request_started (rq)) { +drm_info (&engine->gt->i915->drm,"Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n" , + engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id); +i915_request_put (rq); + rq =NULL ; + } - capture =intel_engine_coredump_add_request (ee, rq,ATOMIC_MAYFAIL ); -if (!capture) - goto no_request_capture; -if (dump_flags &CORE_DUMP_FLAG_IS_GUC_CAPTURE ) -intel_guc_capture_get_matching_node (engine->gt, ee, ce); +if (rq) { + capture =intel_engine_coredump_add_request (ee, rq,ATOMIC_MAYFAIL ); +i915_request_put (rq); + }else if (ce) { + capture =engine_coredump_add_context (ee, ce,ATOMIC_MAYFAIL ); + } -intel_engine_coredump_add_vma (ee, capture, compress); -i915_request_put (rq); +if (capture) { +intel_engine_coredump_add_vma (ee, capture, compress); -return ee; +if (dump_flags &CORE_DUMP_FLAG_IS_GUC_CAPTURE ) +intel_guc_capture_get_matching_node (engine->gt, ee, ce); + }else { +kfree (ee); + ee =NULL ; + } -no_request_capture: -if (rq) -i915_request_put (rq); -kfree (ee); -return NULL ; +return ee; } static void
Signature · 1 line
2.39.1
PATCH v6 5/8 drm/i915: Allow error capture of a pending request
In reply to [email protected]From: John Harrison <[email protected]>
A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that this might be better than nothing.
v2: Reword 'not started' warning message (Tvrtko)
--- drivers/gpu/drm/i915/i915_gpu_error.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +1 -4
@@ -1624,12 +1624,9 @@ capture_engine(struct intel_engine_cs *engine,return NULL ;intel_engine_get_hung_entity (engine, &ce, &rq); -if (rq && !i915_request_started (rq)) { +if (rq && !i915_request_started (rq))drm_info (&engine->gt->i915->drm,"Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n" , engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id); -i915_request_put (rq); - rq =NULL ; - }if (rq) { capture =intel_engine_coredump_add_request (ee, rq,ATOMIC_MAYFAIL );
Signature · 1 line
2.39.1
PATCH v6 6/8 drm/i915/guc: Look for a guilty context when an engine reset fails
In reply to [email protected]From: John Harrison <[email protected]>
Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC intentionally dies on such a situation, it is not possible to get a guilty context notification back. So do a manual search instead. Given that GuC is dead, this is safe because GuC won't be changing the engine state asynchronously.
v2: Change comment to be less alarming (Tvrtko)
--- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +15 -2
@@ -4755,11 +4755,24 @@ static void reset_fail_worker_func(struct work_struct *w) guc->submission_state.reset_fail_mask =0 ;spin_unlock_irqrestore (&guc->submission_state.lock, flags); -if (likely (reset_fail_mask)) +if (likely (reset_fail_mask)) { +struct intel_engine_cs *engine; +enum intel_engine_id id; + +/* +* GuC is toast at this point - it dead loops after sending the failed +* reset notification. So need to manually determine the guilty context. +* Note that it should be reliable to do this here because the GuC is +* toast and will not be scheduling behind the KMD's back. +*/ +for_each_engine_masked (engine, gt, reset_fail_mask, id) +intel_guc_find_hung_context (engine); +intel_gt_handle_error (gt, reset_fail_mask,I915_ERROR_CAPTURE , -"GuC failed to reset engine mask=0x%x\n" , +"GuC failed to reset engine mask=0x%x" , reset_fail_mask); + } } int intel_guc_engine_failure_process_msg(struct intel_guc *guc,
Signature · 1 line
2.39.1
PATCH v6 7/8 drm/i915/guc: Add a debug print on GuC triggered reset
In reply to [email protected]From: John Harrison <[email protected]>
For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages.
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +4 -0
@@ -4666,6 +4666,10 @@ static void guc_handle_context_reset(struct intel_guc *guc, {trace_intel_context_reset (ce); +drm_dbg (&guc_to_gt (guc)->i915->drm,"Got GuC reset of 0x%04X, exiting = %d, banned = %d\n" , + ce->guc_id.id,test_bit (CONTEXT_EXITING , &ce->flags), +test_bit (CONTEXT_BANNED , &ce->flags)); +if (likely (intel_context_is_schedulable (ce))) {capture_error_state (guc, ce);guc_context_replay (ce);
Signature · 1 line
2.39.1
PATCH v6 8/8 drm/i915/guc: Rename GuC register state capture node to be more obvious
In reply to [email protected]From: John Harrison <[email protected]>
The GuC specific register state entry in the error capture object was just called 'capture'. Although the companion 'node' entry was called 'guc_capture_node'. Rename the base entry to be 'guc_capture' instead so that it is a) more consistent and b) more obvious what it is.
--- drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c +4 -4
@@ -1506,7 +1506,7 @@ int intel_guc_capture_print_engine_node(struct drm_i915_error_state_buf *ebuf,if (!ebuf || !ee)return -EINVAL ; - cap = ee->capture; + cap = ee->guc_capture;if (!cap || !ee->engine)return -ENODEV ;
@@ -1576,8 +1576,8 @@ void intel_guc_capture_free_node(struct intel_engine_coredump *ee)if (!ee || !ee->guc_capture_node)return ; -guc_capture_add_node_to_cachelist (ee->capture, ee->guc_capture_node); - ee->capture =NULL ; +guc_capture_add_node_to_cachelist (ee->guc_capture, ee->guc_capture_node); + ee->guc_capture =NULL ; ee->guc_capture_node =NULL ; }
@@ -1611,7 +1611,7 @@ void intel_guc_capture_get_matching_node(struct intel_gt *gt, (ce->lrc.lrca & CTX_GTT_ADDRESS_MASK)) {list_del (&n->link); ee->guc_capture_node = n; - ee->capture = guc->capture; + ee->guc_capture = guc->capture;return ; } }
drivers/gpu/drm/i915/i915_gpu_error.h +1 -1
@@ -94,7 +94,7 @@ struct intel_engine_coredump {struct intel_instdone instdone;/* GuC matched capture-lists info */ -struct intel_guc_state_capture *capture; +struct intel_guc_state_capture *guc_capture;struct __guc_capture_parsed_output *guc_capture_node;struct i915_gem_context_coredump {
Signature · 1 line
2.39.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Allow error capture without a request & fix locking issues (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Allow error capture without a request & fix locking issues (rev4)
URL : https://patchwork.freedesktop.org/series/113078/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Allow error capture without a request & fix locking issues (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Allow error capture without a request & fix locking issues (rev4)
URL : https://patchwork.freedesktop.org/series/113078/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12648 -> Patchwork_113078v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/index.html
Participating hosts (25 -> 23)
------------------------------
Missing (2): bat-atsm-1 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113078v4 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {bat-dg2-11}: [INCOMPLETE][1] ([i915#7834]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/bat-dg2-11/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/bat-dg2-11/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][3] ([i915#6367]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/bat-rpls-1/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/bat-rpls-1/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7834]: https://gitlab.freedesktop.org/drm/intel/issues/7834
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
Build changes
-------------
* Linux: CI_DRM_12648 -> Patchwork_113078v4
CI-20190529: 20190529
CI_DRM_12648: 312e89088380562297f7b434d2c11c8e83bf7833 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7137: 5f7ea985ac0828bec5e1bbc101b7931bd7fb62e3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113078v4: 312e89088380562297f7b434d2c11c8e83bf7833 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4c51691fcb52 drm/i915/guc: Rename GuC register state capture node to be more obvious 9a59841aa447 drm/i915/guc: Add a debug print on GuC triggered reset 5bd81a7db9a5 drm/i915/guc: Look for a guilty context when an engine reset fails 01213d0d64a1 drm/i915: Allow error capture of a pending request 8d6836debad4 drm/i915: Allow error capture without a request 52fcc1ce5427 drm/i915: Fix up locking around dumping requests lists e99fff87cd5f drm/i915: Fix request ref counting during error capture & debugfs dump 3ed39a7f0239 drm/i915/guc: Fix locking when searching for a hung request
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Allow error capture without a request & fix locking issues (rev4)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Allow error capture without a request & fix locking issues (rev4)
URL : https://patchwork.freedesktop.org/series/113078/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12648_full -> Patchwork_113078v4_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/index.html
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113078v4_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_suspend@basic-s3-without-i915:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-dg1-17/igt@[email protected]
* igt@kms_ccs:
- {shard-tglu-10}: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-tglu-10/igt@kms_ccs.html
Known issues
------------
Here are the changes found in Patchwork_113078v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk3/igt@[email protected]
* igt@kms_fbcon_fbt@fbc:
- shard-glk: NOTRUN -> [FAIL][4] ([i915#4767])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk3/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-upscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +13 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk3/igt@kms_flip_scaled_crc@[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][6] ([i915#7742]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][8] ([i915#7052]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-3/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][10] ([i915#5784]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-dg1-16/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-dg1-12/igt@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- {shard-rkl}: [FAIL][12] ([i915#2842]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][14] ([i915#2842]) -> [PASS][15] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-glk1/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- {shard-rkl}: [SKIP][16] ([fdo#109313]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-2/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][18] ([i915#3281]) -> [PASS][19] +10 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
* igt@gem_pwrite@basic-self:
- {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][22] ([i915#5566] / [i915#716]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-glk5/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk3/igt@[email protected]
* igt@gen9_exec_parse@batch-zero-length:
- {shard-rkl}: [SKIP][24] ([i915#2527]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][26] ([i915#1845] / [i915#4098]) -> [PASS][27] +8 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_fbcon_fbt@psr:
- {shard-rkl}: [SKIP][28] ([fdo#110189] / [i915#3955]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@[email protected]
* igt@kms_flip@plain-flip-ts-check@b-hdmi-a1:
- shard-glk: [FAIL][30] ([i915#2122]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-glk4/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-glk4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- {shard-rkl}: [SKIP][32] ([i915#1849] / [i915#4098]) -> [PASS][33] +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][34] ([i915#1849]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@kms_plane@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_psr@primary_mmap_cpu:
- {shard-rkl}: [SKIP][36] ([i915#1072]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@kms_psr@primary_mmap_cpu.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@kms_psr@primary_mmap_cpu.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-a:
- {shard-rkl}: [SKIP][38] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-6/igt@[email protected]
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][40] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12648/shard-rkl-2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/shard-rkl-5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
Build changes
-------------
* Linux: CI_DRM_12648 -> Patchwork_113078v4
CI-20190529: 20190529
CI_DRM_12648: 312e89088380562297f7b434d2c11c8e83bf7833 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7137: 5f7ea985ac0828bec5e1bbc101b7931bd7fb62e3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113078v4: 312e89088380562297f7b434d2c11c8e83bf7833 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v4/index.html