gpiolib cleanups

From: Arnd Bergmann <[email protected]>

The arm and sh versions of this file are identical to the generic versions and can just be removed.

The drivers that actually use the sh3 specific version also include cpu/gpio.h directly, with the exception of magicpanelr2, which is easily fixed. This leaves coldfire as the only gpio driver that needs something custom for gpiolib.

Reviewed-by Geert Uytterhoeven <[email protected]>

Reviewed-by Andy Shevchenko <[email protected]>

Acked-by Bartosz Golaszewski <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

Now that coldfire is the only user of a custom asm/gpio.h, it seems better to remove this as well, and have the same interface everywhere.

For the gpio_get_value()/gpio_set_value()/gpio_to_irq(), gpio_cansleep() functions, the custom version is only a micro-optimization to inline the function for constant GPIO numbers. However, in the coldfire defconfigs, I was unable to find a single instance where this micro-optimization was even used, and according to Geert the only user appears to be the QSPI chip that is disabled everywhere.

The custom gpio_request_one() function is even less useful, as it is guarded by an #ifdef that is never true.

Reviewed-by Geert Uytterhoeven <[email protected]>

Reviewed-by Andy Shevchenko <[email protected]>

Acked-by Bartosz Golaszewski <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

The asm-generic/gpio.h file is now always included when using gpiolib, so just move its contents into linux/gpio.h with a few minor simplifications.

Signed-off-by Arnd Bergmann <[email protected]>

---
 MAINTAINERS                     |   1 -
 arch/m68k/include/asm/mcfgpio.h |   2 +-
 drivers/gpio/gpio-davinci.c     |   2 -
 drivers/pinctrl/core.c          |   1 -
 include/asm-generic/gpio.h      | 147 --------------------------------
 include/linux/gpio.h            |  93 ++++++++++++++++++--
 6 files changed, 85 insertions(+), 161 deletions(-)
 delete mode 100644 include/asm-generic/gpio.h

MAINTAINERS +0 -1

index f64c8f15df4b..25f16f825427 100644
@@ -8731,7 +8731,6 @@ F:	Documentation/admin-guide/gpio/
 F:	Documentation/devicetree/bindings/gpio/
 F:	Documentation/driver-api/gpio/
 F:	drivers/gpio/
-F:	include/asm-generic/gpio.h
 F:	include/dt-bindings/gpio/
 F:	include/linux/gpio.h
 F:	include/linux/gpio/

arch/m68k/include/asm/mcfgpio.h +1 -1

index 27f32cc81da6..2cefe8445980 100644
@@ -9,7 +9,7 @@
 #define mcfgpio_h
 
 #ifdef CONFIG_GPIOLIB
-#include <asm-generic/gpio.h>
+#include <linux/gpio.h>
 #else
 
 int __mcfgpio_get_value(unsigned gpio);

drivers/gpio/gpio-davinci.c +0 -2

index 26b1f7465e09..7fc83057990a 100644
@@ -24,8 +24,6 @@
 #include <linux/spinlock.h>
 #include <linux/pm_runtime.h>
 
-#include <asm-generic/gpio.h>
-
 #define MAX_REGS_BANKS 5
 #define MAX_INT_PER_BANK 32
 

drivers/pinctrl/core.c +0 -1

index d6e6c751255f..401886c81344 100644
@@ -30,7 +30,6 @@
 
 #ifdef CONFIG_GPIOLIB
 #include "../gpio/gpiolib.h"
-#include <asm-generic/gpio.h>
 #endif
 
 #include "core.h"

include/asm-generic/gpio.h deleted +0 -147

deleted file mode 100644
index 22cb8c9efc1d..000000000000
@@ -1,147 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _ASM_GENERIC_GPIO_H
-#define _ASM_GENERIC_GPIO_H
-
-#include <linux/types.h>
-#include <linux/errno.h>
-
-#ifdef CONFIG_GPIOLIB
-
-#include <linux/compiler.h>
-#include <linux/gpio/driver.h>
-#include <linux/gpio/consumer.h>
-
-/*
- * Platforms may implement their GPIO interface with library code,
- * at a small performance cost for non-inlined operations and some
- * extra memory (for code and for per-GPIO table entries).
- */
-
-/*
- * At the end we want all GPIOs to be dynamically allocated from 0.
- * However, some legacy drivers still perform fixed allocation.
- * Until they are all fixed, leave 0-512 space for them.
- */
-#define GPIO_DYNAMIC_BASE	512
-
-struct device;
-struct gpio;
-struct seq_file;
-struct module;
-struct device_node;
-struct gpio_desc;
-
-/* Always use the library code for GPIO management calls,
- * or when sleeping may be involved.
- */
-extern int gpio_request(unsigned gpio, const char *label);
-extern void gpio_free(unsigned gpio);
-
-static inline int gpio_direction_input(unsigned gpio)
-{
-	return gpiod_direction_input(gpio_to_desc(gpio));
-}
-static inline int gpio_direction_output(unsigned gpio, int value)
-{
-	return gpiod_direction_output_raw(gpio_to_desc(gpio), value);
-}
-
-static inline int gpio_set_debounce(unsigned gpio, unsigned debounce)
-{
-	return gpiod_set_debounce(gpio_to_desc(gpio), debounce);
-}
-
-static inline int gpio_get_value_cansleep(unsigned gpio)
-{
-	return gpiod_get_raw_value_cansleep(gpio_to_desc(gpio));
-}
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
-	return gpiod_set_raw_value_cansleep(gpio_to_desc(gpio), value);
-}
-
-
-/* A platform's <asm/gpio.h> code may want to inline the I/O calls when
- * the GPIO is constant and refers to some always-present controller,
- * giving direct access to chip registers and tight bitbanging loops.
- */
-static inline int __gpio_get_value(unsigned gpio)
-{
-	return gpiod_get_raw_value(gpio_to_desc(gpio));
-}
-static inline void __gpio_set_value(unsigned gpio, int value)
-{
-	return gpiod_set_raw_value(gpio_to_desc(gpio), value);
-}
-
-static inline int __gpio_cansleep(unsigned gpio)
-{
-	return gpiod_cansleep(gpio_to_desc(gpio));
-}
-
-static inline int __gpio_to_irq(unsigned gpio)
-{
-	return gpiod_to_irq(gpio_to_desc(gpio));
-}
-
-extern int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
-extern int gpio_request_array(const struct gpio *array, size_t num);
-extern void gpio_free_array(const struct gpio *array, size_t num);
-
-/*
- * A sysfs interface can be exported by individual drivers if they want,
- * but more typically is configured entirely from userspace.
- */
-static inline int gpio_export(unsigned gpio, bool direction_may_change)
-{
-	return gpiod_export(gpio_to_desc(gpio), direction_may_change);
-}
-
-static inline void gpio_unexport(unsigned gpio)
-{
-	gpiod_unexport(gpio_to_desc(gpio));
-}
-
-#else	/* !CONFIG_GPIOLIB */
-
-#include <linux/kernel.h>
-
-/* platforms that don't directly support access to GPIOs through I2C, SPI,
- * or other blocking infrastructure can use these wrappers.
- */
-
-static inline int gpio_cansleep(unsigned gpio)
-{
-	return 0;
-}
-
-static inline int gpio_get_value_cansleep(unsigned gpio)
-{
-	might_sleep();
-	return __gpio_get_value(gpio);
-}
-
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
-	might_sleep();
-	__gpio_set_value(gpio, value);
-}
-
-#endif /* !CONFIG_GPIOLIB */
-
-/*
- * "valid" GPIO numbers are nonnegative and may be passed to
- * setup routines like gpio_request().  only some valid numbers
- * can successfully be requested and used.
- *
- * Invalid GPIO numbers are useful for indicating no-such-GPIO in
- * platform data and other tables.
- */
-
-static inline bool gpio_is_valid(int number)
-{
-	/* only non-negative numbers are valid */
-	return number >= 0;
-}
-
-#endif /* _ASM_GENERIC_GPIO_H */

include/linux/gpio.h +84 -9

index 2b75017b3aad..6719a82eeec5 100644
@@ -54,26 +54,101 @@ struct gpio {
 };
 
 #ifdef CONFIG_GPIOLIB
-#include <asm-generic/gpio.h>
+#include <linux/compiler.h>
+#include <linux/gpio/consumer.h>
+#include <linux/gpio/driver.h>
 
-static inline int gpio_get_value(unsigned int gpio)
+/*
+ * "valid" GPIO numbers are nonnegative and may be passed to
+ * setup routines like gpio_request().  Only some valid numbers
+ * can successfully be requested and used.
+ *
+ * Invalid GPIO numbers are useful for indicating no-such-GPIO in
+ * platform data and other tables.
+ */
+static inline bool gpio_is_valid(int number)
+{
+	/* only non-negative numbers are valid */
+	return number >= 0;
+}
+
+/*
+ * Platforms may implement their GPIO interface with library code,
+ * at a small performance cost for non-inlined operations and some
+ * extra memory (for code and for per-GPIO table entries).
+ */
+
+/*
+ * At the end we want all GPIOs to be dynamically allocated from 0.
+ * However, some legacy drivers still perform fixed allocation.
+ * Until they are all fixed, leave 0-512 space for them.
+ */
+#define GPIO_DYNAMIC_BASE	512
+
+/* Always use the library code for GPIO management calls,
+ * or when sleeping may be involved.
+ */
+int gpio_request(unsigned gpio, const char *label);
+void gpio_free(unsigned gpio);
+
+static inline int gpio_direction_input(unsigned gpio)
+{
+	return gpiod_direction_input(gpio_to_desc(gpio));
+}
+static inline int gpio_direction_output(unsigned gpio, int value)
 {
-	return __gpio_get_value(gpio);
+	return gpiod_direction_output_raw(gpio_to_desc(gpio), value);
 }
 
-static inline void gpio_set_value(unsigned int gpio, int value)
+static inline int gpio_set_debounce(unsigned gpio, unsigned debounce)
 {
-	__gpio_set_value(gpio, value);
+	return gpiod_set_debounce(gpio_to_desc(gpio), debounce);
 }
 
-static inline int gpio_cansleep(unsigned int gpio)
+static inline int gpio_get_value_cansleep(unsigned gpio)
+{
+	return gpiod_get_raw_value_cansleep(gpio_to_desc(gpio));
+}
+static inline void gpio_set_value_cansleep(unsigned gpio, int value)
 {
-	return __gpio_cansleep(gpio);
+	return gpiod_set_raw_value_cansleep(gpio_to_desc(gpio), value);
 }
 
-static inline int gpio_to_irq(unsigned int gpio)
+static inline int gpio_get_value(unsigned gpio)
+{
+	return gpiod_get_raw_value(gpio_to_desc(gpio));
+}
+static inline void gpio_set_value(unsigned gpio, int value)
+{
+	return gpiod_set_raw_value(gpio_to_desc(gpio), value);
+}
+
+static inline int gpio_cansleep(unsigned gpio)
+{
+	return gpiod_cansleep(gpio_to_desc(gpio));
+}
+
+static inline int gpio_to_irq(unsigned gpio)
+{
+	return gpiod_to_irq(gpio_to_desc(gpio));
+}
+
+int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
+int gpio_request_array(const struct gpio *array, size_t num);
+void gpio_free_array(const struct gpio *array, size_t num);
+
+/*
+ * A sysfs interface can be exported by individual drivers if they want,
+ * but more typically is configured entirely from userspace.
+ */
+static inline int gpio_export(unsigned gpio, bool direction_may_change)
+{
+	return gpiod_export(gpio_to_desc(gpio), direction_may_change);
+}
+
+static inline void gpio_unexport(unsigned gpio)
 {
-	return __gpio_to_irq(gpio);
+	gpiod_unexport(gpio_to_desc(gpio));
 }
 
 /* CONFIG_GPIOLIB: bindings for managed devices that want to request gpios */

Signature · 1 line

2.39.0

From: Arnd Bergmann <[email protected]>

The asm-generic/gpio.h file is now always included when using gpiolib, so just move its contents into linux/gpio.h with a few minor simplifications.

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

gpio_set_debounce() only has a single user, which is trivially converted to gpiod_set_debounce().

Signed-off-by Arnd Bergmann <[email protected]>

---
 Documentation/driver-api/gpio/legacy.rst      |  2 --
 .../zh_CN/driver-api/gpio/legacy.rst          |  1 -
 Documentation/translations/zh_TW/gpio.txt     |  1 -
 drivers/input/touchscreen/ads7846.c           | 25 ++++++++++---------
 include/linux/gpio.h                          | 10 --------
 5 files changed, 13 insertions(+), 26 deletions(-)

Documentation/driver-api/gpio/legacy.rst +0 -2

index a0559d93efd1..e0306e78e34b 100644
@@ -238,8 +238,6 @@ setup or driver probe/teardown code, so this is an easy constraint.)::
         ## 	gpio_free_array()
 
                 gpio_free()
-                gpio_set_debounce()
-
 
 
 Claiming and Releasing GPIOs

Documentation/translations/zh_CN/driver-api/gpio/legacy.rst +0 -1

index 74fa473bb504..dee2a0517c1c 100644
@@ -219,7 +219,6 @@ GPIO 值的命令需要等待其信息排到队首才发送命令，再获得其
         ## 	gpio_free_array()
 
                 gpio_free()
-                gpio_set_debounce()
 
 
 

Documentation/translations/zh_TW/gpio.txt +0 -1

index 1b986bbb0909..dc608358d90a 100644
@@ -226,7 +226,6 @@ GPIO 值的命令需要等待其信息排到隊首才發送命令，再獲得其
 ## 	gpio_free_array()
 
 	gpio_free()
-	gpio_set_debounce()
 
 
 

drivers/input/touchscreen/ads7846.c +13 -12

index 4c3dd01902d0..da3c55d9cb98 100644
@@ -25,8 +25,8 @@
 #include <linux/slab.h>
 #include <linux/pm.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/of_device.h>
+#include <linux/gpio/consumer.h>
 #include <linux/gpio.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>

@@ -139,7 +139,7 @@ struct ads7846 {
 	int			(*filter)(void *data, int data_idx, int *val);
 	void			*filter_data;
 	int			(*get_pendown_state)(void);
-	int			gpio_pendown;
+	struct gpio_desc	*gpio_pendown;
 
 	void			(*wait_for_sync)(void);
 };

@@ -222,7 +222,7 @@ static int get_pendown_state(struct ads7846 *ts)
 	if (ts->get_pendown_state)
 		return ts->get_pendown_state();
 
-	return !gpio_get_value(ts->gpio_pendown);
+	return !gpiod_get_value(ts->gpio_pendown);
 }
 
 static void ads7846_report_pen_up(struct ads7846 *ts)

@@ -1005,7 +1005,6 @@ static int ads7846_setup_pendown(struct spi_device *spi,
 	if (pdata->get_pendown_state) {
 		ts->get_pendown_state = pdata->get_pendown_state;
 	} else if (gpio_is_valid(pdata->gpio_pendown)) {
-
 		err = devm_gpio_request_one(&spi->dev, pdata->gpio_pendown,
 					    GPIOF_IN, "ads7846_pendown");
 		if (err) {

@@ -1015,15 +1014,17 @@ static int ads7846_setup_pendown(struct spi_device *spi,
 			return err;
 		}
 
-		ts->gpio_pendown = pdata->gpio_pendown;
-
-		if (pdata->gpio_pendown_debounce)
-			gpio_set_debounce(pdata->gpio_pendown,
-					  pdata->gpio_pendown_debounce);
+		ts->gpio_pendown = gpio_to_desc(pdata->gpio_pendown);
 	} else {
-		dev_err(&spi->dev, "no get_pendown_state nor gpio_pendown?\n");
-		return -EINVAL;
+		ts->gpio_pendown = gpiod_get(&spi->dev, "pendown-gpio", GPIOD_IN);
+		if (IS_ERR(ts->gpio_pendown)) {
+			dev_err(&spi->dev, "no get_pendown_state nor gpio_pendown?\n");
+			return PTR_ERR(ts->gpio_pendown);
+		}
 	}
+	if (pdata->gpio_pendown_debounce)
+		gpiod_set_debounce(ts->gpio_pendown,
+				   pdata->gpio_pendown_debounce);
 
 	return 0;
 }

@@ -1192,7 +1193,7 @@ static const struct ads7846_platform_data *ads7846_probe_dt(struct device *dev)
 	pdata->wakeup = of_property_read_bool(node, "wakeup-source") ||
 			of_property_read_bool(node, "linux,wakeup");
 
-	pdata->gpio_pendown = of_get_named_gpio(dev->of_node, "pendown-gpio", 0);
+	pdata->gpio_pendown = -1;
 
 	return pdata;
 }

include/linux/gpio.h +0 -10

index 6719a82eeec5..220e8656f2ab 100644
@@ -100,11 +100,6 @@ static inline int gpio_direction_output(unsigned gpio, int value)
 	return gpiod_direction_output_raw(gpio_to_desc(gpio), value);
 }
 
-static inline int gpio_set_debounce(unsigned gpio, unsigned debounce)
-{
-	return gpiod_set_debounce(gpio_to_desc(gpio), debounce);
-}
-
 static inline int gpio_get_value_cansleep(unsigned gpio)
 {
 	return gpiod_get_raw_value_cansleep(gpio_to_desc(gpio));

@@ -215,11 +210,6 @@ static inline int gpio_direction_output(unsigned gpio, int value)
 	return -ENOSYS;
 }
 
-static inline int gpio_set_debounce(unsigned gpio, unsigned debounce)
-{
-	return -ENOSYS;
-}
-
 static inline int gpio_get_value(unsigned gpio)
 {
 	/* GPIO can never have been requested or set as {in,out}put */

Signature · 1 line

2.39.0

From: Arnd Bergmann <[email protected]>

gpio_set_debounce() only has a single user, which is trivially converted to gpiod_set_debounce().

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

gpio_set_debounce() only has a single user, which is trivially converted to gpiod_set_debounce().

Signed-off-by Arnd Bergmann <[email protected]>

---
 Documentation/driver-api/gpio/legacy.rst      |  2 --
 .../zh_CN/driver-api/gpio/legacy.rst          |  1 -
 Documentation/translations/zh_TW/gpio.txt     |  1 -
 drivers/input/touchscreen/ads7846.c           | 25 ++++++++++---------
 include/linux/gpio.h                          | 10 --------
 5 files changed, 13 insertions(+), 26 deletions(-)

Documentation/driver-api/gpio/legacy.rst +0 -2

index a0559d93efd1..e0306e78e34b 100644
@@ -238,8 +238,6 @@ setup or driver probe/teardown code, so this is an easy constraint.)::
         ## 	gpio_free_array()
 
                 gpio_free()
-                gpio_set_debounce()
-
 
 
 Claiming and Releasing GPIOs

Documentation/translations/zh_CN/driver-api/gpio/legacy.rst +0 -1

index 74fa473bb504..dee2a0517c1c 100644
@@ -219,7 +219,6 @@ GPIO 值的命令需要等待其信息排到队首才发送命令，再获得其
         ## 	gpio_free_array()
 
                 gpio_free()
-                gpio_set_debounce()
 
 
 

Documentation/translations/zh_TW/gpio.txt +0 -1

index 1b986bbb0909..dc608358d90a 100644
@@ -226,7 +226,6 @@ GPIO 值的命令需要等待其信息排到隊首才發送命令，再獲得其
 ## 	gpio_free_array()
 
 	gpio_free()
-	gpio_set_debounce()
 
 
 

drivers/input/touchscreen/ads7846.c +2 -2

index 4c3dd01902d0..da3c55d9cb98 100644
@@ -25,8 +25,8 @@
 #include <linux/slab.h>
 #include <linux/pm.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/of_device.h>
+#include <linux/gpio/consumer.h>
 #include <linux/gpio.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>

@@ -139,7 +139,7 @@ struct ads7846 {
 	int			(*filter)(void *data, int data_idx, int *val);
 	void			*filter_data;
 	int			(*get_pendown_state)(void);
-	int			gpio_pendown;
+	struct gpio_desc	*gpio_pendown;
 
 	void			(*wait_for_sync)(void);
 };

On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:

drivers/input/touchscreen/ads7846.c static int get_pendown_state(struct ads7846 *ts) · line 225

Quoted 2 lines

drivers/input/touchscreen/ads7846.c +1 -1

-	return !gpio_get_value(ts->gpio_pendown);
+	return !gpiod_get_value(ts->gpio_pendown);

No, we can not blindly do that without checking annotations on GPIOs.

drivers/input/touchscreen/ads7846.c static int ads7846_setup_pendown(struct spi_device *spi, · line 1019

Quoted 1 line

drivers/input/touchscreen/ads7846.c +1 -0

+		ts->gpio_pendown = gpiod_get(&spi->dev, "pendown-gpio", GPIOD_IN);

Wrong name, you will be looking for "pendown-gpio-gpios".

Sorry, but I have to NAK this in the current form.

Quoted 1 line · Dmitry Torokhov

On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:

...

Quoted 4 lines

drivers/input/touchscreen/ads7846.c static int get_pendown_state(struct ads7846 *ts) · line 225

Quoted 2 lines

drivers/input/touchscreen/ads7846.c +1 -1

-	return !gpio_get_value(ts->gpio_pendown);
+	return !gpiod_get_value(ts->gpio_pendown);

No, we can not blindly do that without checking annotations on GPIOs.

But this is easy to fix, i.e. use raw API, no?

Quoted 2 lines · Andy Shevchenko

Quoted 1 line · Dmitry Torokhov

On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:

Quoted 5 lines

Quoted 4 lines

drivers/input/touchscreen/ads7846.c static int get_pendown_state(struct ads7846 *ts) · line 225

Quoted 2 lines

drivers/input/touchscreen/ads7846.c +1 -1

-	return !gpio_get_value(ts->gpio_pendown);
+	return !gpiod_get_value(ts->gpio_pendown);

No, we can not blindly do that without checking annotations on GPIOs.

Quoted 1 line

But this is easy to fix, i.e. use raw API, no?

I'd rather not (I hope I can make this driver respect declared polarity at some point), so for debounce we could do:

	gpiod_set_debounce(gpio_to_gpiod(), ...);

in ads7846 for now, and get rid of gpio_set_debounce() as a publc API.

Quoted 3 lines · Dmitry Torokhov

Quoted 2 lines · Andy Shevchenko

Quoted 1 line · Dmitry Torokhov

On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:

...

Quoted 12 lines

Quoted 6 lines

Quoted 4 lines

drivers/input/touchscreen/ads7846.c static int get_pendown_state(struct ads7846 *ts) · line 225

Quoted 2 lines

drivers/input/touchscreen/ads7846.c +1 -1

-	return !gpio_get_value(ts->gpio_pendown);
+	return !gpiod_get_value(ts->gpio_pendown);

No, we can not blindly do that without checking annotations on GPIOs.

But this is easy to fix, i.e. use raw API, no?

I'd rather not (I hope I can make this driver respect declared polarity at some point), so for debounce we could do:

	gpiod_set_debounce(gpio_to_gpiod(), ...);

Quoted 1 line

in ads7846 for now, and get rid of gpio_set_debounce() as a publc API.

This will work and we can keep it for a while (gpio_to_desc(), I believe you meant this one, is part of the new API to keep this bridge for the cases like this).

Arnd, are you going to send a v3? It would be really nice to have less collisions next cycle if your series is applied.

From: Arnd Bergmann <[email protected]>

There are only a handful of users of gpio_export() and related functions.

As these are just wrappers around the modern gpiod_export() helper, remove the wrappers and open-code the gpio_to_desc in all callers to shrink the legacy API.

Reviewed-by Andy Shevchenko <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

Almost all gpio drivers include linux/gpio/driver.h, and other files should not rely on includes from this header.

Remove the indirect include from here and include the correct headers directly from where they are used.

Reviewed-by Andy Shevchenko <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Almost all gpio drivers include linux/gpio/driver.h, and other files should not rely on includes from this header.

Remove the indirect include from here and include the correct headers directly from where they are used.

Quoted 2 lines

Reviewed-by Andy Shevchenko <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

As mentioned on v1 you will need two additional patches to avoid build errors from the bots, perhaps Bartosz can cherry-pick them?

https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=73ca8058a7b2075c993040bdc92b6a82f57d4316
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-no-driver-h&id=89f4f9cc70c686303679e57bdc3ac86507979fe3

(Maybe the Viper cf adapter is deleted in the PXA boardfile removal so it's not an issue. The HTE file needs patching through.)

Reviewed-by Linus Walleij <[email protected]>

From: Arnd Bergmann <[email protected]>

This is a rarely used feature that has nothing to do with the client-side of_gpio.h.

Split it out with a separate header file and Kconfig option so it can be removed on its own timeline aside from removing the of_gpio consumer interfaces.

Reviewed-by Andy Shevchenko <[email protected]>

Signed-off-by Arnd Bergmann <[email protected]>

From: Arnd Bergmann <[email protected]>

These are some older patches I did last year, rebased to linux-next-20230127.

The main goal is to remove some of the legacy bits of the gpiolib interfaces, where the corner cases are easily avoided or replaced with gpio descriptor based interfaces.

Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

These are some older patches I did last year, rebased to linux-next-20230127.

Quoted 3 lines

The main goal is to remove some of the legacy bits of the gpiolib interfaces, where the corner cases are easily avoided or replaced with gpio descriptor based interfaces.

Thank you!

I guess we may go with this via GPIO tree.