Skip to contentSkip to conversation

usg: gadget: Move validation out of lock in webusb_bcdVersion_store()

PATCH New Andy Shevchenko 1 participant 1 message Jan 27, 2023 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usg: gadget: Move validation out of lock in webusb_bcdVersion_store()

Validation has nothing to do with any protected data, move it out of the lock and make code neater.

---
 drivers/usb/gadget/configfs.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/usb/gadget/configfs.c +3 -7
index 63dc15b4f6d8..1346b330b358 100644
@@ -836,19 +836,15 @@ static ssize_t webusb_bcdVersion_store(struct config_item *item,
 	if (ret)
 		return ret;
 
-	mutex_lock(&gi->lock);
-
 	ret = is_valid_bcd(bcdVersion);
 	if (ret)
-		goto out;
+		return ret;
 
+	mutex_lock(&gi->lock);
 	gi->bcd_webusb_version = bcdVersion;
-	ret = len;
-
-out:
 	mutex_unlock(&gi->lock);
 
-	return ret;
+	return len;
 }
 
 static ssize_t webusb_bVendorCode_show(struct config_item *item, char *page)
Signature · 1 line
2.39.0