fs: gracefully handle ->get_block not mapping bh in __mpage_writepage
Jan Kara
reviewerPATCH 1/1 fs: gracefully handle ->get_block not mapping bh in __mpage_writepage
When filesystem's ->get_block function does not map the buffer head when called from __mpage_writepage(), the function will happily go and pass bogus bdev and block number to bio allocation routines which leads to crashes sooner or later. E.g. UDF can do this because it doesn't want to allocate blocks from ->writepages callbacks. It allocates blocks on write or page fault but writeback can still spot dirty buffers without underlying blocks allocated e.g. if blocksize < pagesize, the tail page is dirtied (which means all its buffers are dirtied), and truncate extends the file so that some buffer starts to be within i_size.
--- fs/mpage.c | 2 ++ 1 file changed, 2 insertions(+)
I'd like to get this patch merged through my tree as other UDF fixes depend on it and without this change the kernel crashes in unfortunate ways.
fs/mpage.c +2 -0
@@ -538,6 +538,8 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, map_bh.b_size =1 << blkbits;if (mpd->get_block (inode, block_in_file, &map_bh,1 )) goto confused; +if (!buffer_mapped (&map_bh)) + goto confused;if (buffer_new (&map_bh))clean_bdev_bh_alias (&map_bh);if (buffer_boundary (&map_bh)) {
Signature · 1 line
2.35.3
Quoted 9 lines · Jan Kara
When filesystem's ->get_block function does not map the buffer head when called from
__mpage_writepage(), the function will happily go and pass bogus bdev and block number to bio allocation routines which leads to crashes sooner or later. E.g. UDF can do this because it doesn't want to allocate blocks from ->writepages callbacks. It allocates blocks on write or page fault but writeback can still spot dirty buffers without underlying blocks allocated e.g. if blocksize < pagesize, the tail page is dirtied (which means all its buffers are dirtied), and truncate extends the file so that some buffer starts to be withini_size.
Yes, this matches what the buffer.c helpers do, so:
Quoted 2 lines · On Thu, 26 Jan 2023 09:51:55 +0100 Jan Kara <[email protected]> wrote:
When filesystem's ->get_block function does not map the buffer head when called from
__mpage_writepage(), the function will happily go and pass
"the function" being __mpage_writepage(), not ->get_block()...
Quoted 2 lines
bogus bdev and block number to bio allocation routines which leads to crashes sooner or later.
Crashes are unwelcome. How is this bug triggered? Should we backport the fix? I assume this is a longstanding thing and that any Fixes:
target would be ancient? If ancient, why did it take so long to discover?
Quoted 8 lines
E.g. UDF can do this because it doesn't want to
allocate blocks from ->writepages callbacks. It allocates blocks on write or page fault but writeback can still spot dirty buffers without underlying blocks allocated e.g. if blocksize < pagesize, the tail page is dirtied (which means all its buffers are dirtied), and truncate extends the file so that some buffer starts to be withini_size....
Jan Kara
reviewerQuoted 6 lines · Andrew Morton
Quoted 2 lines · On Thu, 26 Jan 2023 09:51:55 +0100 Jan Kara <[email protected]> wrote:
When filesystem's ->get_block function does not map the buffer head when called from
__mpage_writepage(), the function will happily go and pass"the function" being
__mpage_writepage(), not ->get_block()...
Ah, right :)
Quoted 7 lines
Quoted 2 lines
bogus bdev and block number to bio allocation routines which leads to crashes sooner or later.
Crashes are unwelcome. How is this bug triggered? Should we backport the fix? I assume this is a longstanding thing and that any Fixes:
target would be ancient? If ancient, why did it take so long to discover?
fsstress was able to trigger the problem for UDF. The problem is there likely since the time __mpage_writepage() was created (definitely pre-git). But usually filesystems using mpage_writepages() just allocate blocks in their ->get_block() method so the problem was not visible until I've changed UDF to not allocate blocks from page writeback (to fix some other bug).
For that reason, I'm actually carrying this change in my tree so that I don't get swamped with 0-day and syzbot reports on that offending UDF fix.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR