Skip to contentSkip to conversation

make dist: Ship ovpn_dco_freebsd.h, too

PATCH In review Matthias Andree 2 participants 3 messages Jan 27, 2023 – Jan 28, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make dist: Ship ovpn_dco_freebsd.h, too

This file was missing from src/openvpn/Makefile.am.

---
 src/openvpn/Makefile.am | 1 +
 1 file changed, 1 insertion(+)
src/openvpn/Makefile.am +1 -0
index 3ed73fa4..a8e44528 100644
@@ -78,6 +78,7 @@ openvpn_SOURCES = \
 	mbuf.c mbuf.h \
 	memdbg.h \
 	misc.c misc.h \
+	ovpn_dco_freebsd.h \
 	ovpn_dco_linux.h \
 	ovpn_dco_win.h \
 	platform.c platform.h \

--
2.39.1

Acked-by on v1 1/1
#1 lore raw

To see the actual failure, one needs to build a tarball ("make dist"), and from that tarball, compile with "configure --enable-dco", on FreeBSD
- so a pure "make distcheck" did not see it. Apologies for that oversight.

Your patch has been applied to the master and release/2.6 branch.

commit ffcf20ca7070027ccb16c3697b2a0e263cbc78a4 (master) commit 680ba43355f6d9e4dcdf6c6eb9ace09946dba8f3 (HEAD -> release/2.6)

Author: Matthias Andree
Date:   Fri Jan 27 21:32:08 2023 +0100
     make dist: Ship ovpn_dco_freebsd.h, too

     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg26085.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#2 lore raw

Am 28.01.23 um 19:55 schrieb Gert Doering:

Quoted 7 lines

To see the actual failure, one needs to build a tarball ("make dist"), and from that tarball, compile with "configure --enable-dco", on FreeBSD
- so a pure "make distcheck" did not see it. Apologies for that oversight.

Your patch has been applied to the master and release/2.6 branch.

Hi Gert,

Danke.

We could set AM_DISTCHECK_CONFIGURE_FLAGS=--enable-dco (and possibly other --enable-* or -with-*) in the relevant Makefile.am though if you want a more complete feature set in "make distcheck".

Cheers,
Matthias