drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11
Subsystems (3)
PATCH RESEND 1/1 drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11
PMFW will handle the features disablement properly for gpu reset case, driver involvement may cause some unexpected issues.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +14 -0
@@ -1497,6 +1497,20 @@ static int smu_disable_dpms(struct smu_context *smu) } } +/* +* For SMU 13.0.4/11, PMFW will handle the features disablement properly +* for gpu reset case. Driver involvement is unnecessary. +*/ +if (amdgpu_in_reset (adev)) { +switch (adev->ip_versions[MP1_HWIP ][0 ]) { +case IP_VERSION (13 ,0 ,4 ): +case IP_VERSION (13 ,0 ,11 ): +return 0 ; +default : +break ; + } + } +/* * For gpu reset, runpm and hibernation through BACO, * BACO feature has to be kept enabled.
Signature · 1 line
2.25.1
[AMD Official Use Only - General]
-----Original Message-----
From: Huang, Tim <[email protected]>
Sent: Saturday, January 28, 2023 11:36 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Yifan <[email protected]>; Du, Xiaojian <[email protected]>; Ma, Li <[email protected]>; Limonciello, Mario <[email protected]>; Huang, Tim <[email protected]>
Subject: [PATCH RESEND] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11
PMFW will handle the features disablement properly for gpu reset case, driver involvement may cause some unexpected issues.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +14 -0
@@ -1497,6 +1497,20 @@ static int smu_disable_dpms(struct smu_context *smu) } } +/* +* For SMU 13.0.4/11, PMFW will handle the features disablement properly +* for gpu reset case. Driver involvement is unnecessary. +*/ +if (amdgpu_in_reset (adev)) { +switch (adev->ip_versions[MP1_HWIP ][0 ]) { +case IP_VERSION (13 ,0 ,4 ): +case IP_VERSION (13 ,0 ,11 ): +return 0 ; +default : +break ; + } + } +/* * For gpu reset, runpm and hibernation through BACO, * BACO feature has to be kept enabled.
--
2.25.1