Skip to contentSkip to conversation

scripts/tags.sh: Fix the Kconfig tags generation when using latest ctags

PATCH Applied Kevin Hao 1 participant 1 message Jan 28, 2023

lore
Share & tools
lore

Kevin Hao

author
#0 lore raw

PATCH v3 1/1 scripts/tags.sh: Fix the Kconfig tags generation when using latest ctags

The Kconfig language has already been built-in in the latest ctags, so it would error exit if we try to define it as an user-defined language via '--langdef=kconfig'. This results that there is no Kconfig tags in the final tag file. Fix this by skipping the user Kconfig definition for the latest ctags.

---
v3: Add Reviewed-by from Cristian.

Hi Andrew,

The scripts/get_maintainer.pl can't tell me who own scripts/tags.sh, and the v2 [1] has dangled in the list for almost one month without further comment. So I am wondering if you could pick up this patch.

[1] https://lore.kernel.org/all/[email protected]/

 scripts/tags.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
scripts/tags.sh +6 -4
index 14d0209893e9..da4d404cd1f0 100755
@@ -271,10 +271,12 @@ exuberant()
 	--$CTAGS_EXTRA=+fq --c-kinds=+px --fields=+iaS --langmap=c:+.h \
 	"${regex[@]}"
 
-	setup_regex exuberant kconfig
-	all_kconfigs | xargs $1 -a                              \
-	--langdef=kconfig --language-force=kconfig "${regex[@]}"
-
+	KCONFIG_ARGS=()
+	if ! $1 --list-languages | grep -iq kconfig; then
+		setup_regex exuberant kconfig
+		KCONFIG_ARGS=(--langdef=kconfig --language-force=kconfig "${regex[@]}")
+	fi
+	all_kconfigs | xargs $1 -a "${KCONFIG_ARGS[@]}"
 }
 
 emacs()
Signature · 1 line
2.38.1