sh: checksum: add missing linux/uaccess.h include
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 sh: checksum: add missing linux/uaccess.h include
SuperH does not include uaccess.h, even tho it calls access_ok().
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- arch/sh/include/asm/checksum_32.h | 1 + 1 file changed, 1 insertion(+)
arch/sh/include/asm/checksum_32.h +1 -0
@@ -7,6 +7,7 @@*/ #include <linux/in6.h> +#include <linux/uaccess.h> /* * computes the checksum of a memory block at buff, length len,
Signature · 1 line
2.39.1
Quoted 1 line · Jakub Kicinski
SuperH does not include
uaccess.h, even tho it callsaccess_ok().
I see that is true.
But it's less clear to me why that is a problem.
Quoted 25 lines
Fixes 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]--- arch/sh/include/asm/checksum_32.h | 1 + 1 file changed, 1 insertion(+)arch/sh/include/asm/checksum_32.h +1
-0@@ -7,6 +7,7 @@*/ #include <linux/in6.h> +#include <linux/uaccess.h> /* * computes the checksum of a memory block at buff, length len, Signature · 1 line
2.39.1
Quoted 5 lines · Simon Horman
Quoted 1 line · Jakub Kicinski
SuperH does not include
uaccess.h, even tho it callsaccess_ok().I see that is true.
But it's less clear to me why that is a problem.
Ok, now I see the kernel test robot splat. Let me try and reproduce it for my own edification.
Quoted 9 lines · Simon Horman
Quoted 5 lines · Simon Horman
Quoted 1 line · Jakub Kicinski
SuperH does not include
uaccess.h, even tho it callsaccess_ok().I see that is true.
But it's less clear to me why that is a problem.Ok, now I see the kernel test robot splat. Let me try and reproduce it for my own edification.
Done. Unsurprisingly, your patch resolves the problem.
For the record, the splat is here:
- https://lore.kernel.org/netdev/[email protected]/
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Fri, 27 Jan 2023 23:31:08 -0800 you wrote:
SuperH does not include
uaccess.h, even tho it callsaccess_ok().Fixes 68f4eae781dd ("net: checksum: drop the linux/uaccess.h include")Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected][...]
Here is the summary with links:
- [net-next] sh: checksum: add missing linux/uaccess.h include
https://git.kernel.org/netdev/net-next/c/2083656bb30d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html