Skip to contentSkip to conversation

dt-bindings: rename .yamllint to yamllint

PATCH In review Masahiro Yamada 3 participants 4 messages Jan 30, 2023 – Jan 31, 2023 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: rename .yamllint to yamllint

This file is ignored by git by the '.*' rule in the top .gitignore.

I do not see a good reason why this should be a hidden file.

---

I think many people are aware of this issue
since this is now W=1 warning due to this patch:
https://lore.kernel.org/all/[email protected]/

 Documentation/devicetree/bindings/Makefile                | 4 ++--
 Documentation/devicetree/bindings/{.yamllint => yamllint} | 0
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/{.yamllint => yamllint} (100%)
Documentation/devicetree/bindings/Makefile +2 -2
index bf2d8a8ced77..edc65522072b 100644
@@ -34,7 +34,7 @@ CHK_DT_DOCS := $(shell $(find_cmd))
 quiet_cmd_yamllint = LINT    $(src)
       cmd_yamllint = ($(find_cmd) | \
                      xargs -n200 -P$$(nproc) \
-		     $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/.yamllint >&2) || true
+		     $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/yamllint >&2) || true
 
 quiet_cmd_chk_bindings = CHKDT   $@
       cmd_chk_bindings = ($(find_cmd) | \
@@ -64,7 +64,7 @@ override DTC_FLAGS := \
 # Disable undocumented compatible checks until warning free
 override DT_CHECKER_FLAGS ?=
 
-$(obj)/processed-schema.json: $(DT_DOCS) $(src)/.yamllint check_dtschema_version FORCE
+$(obj)/processed-schema.json: $(DT_DOCS) $(src)/yamllint check_dtschema_version FORCE
 	$(call if_changed_rule,chkdt)
 
 always-y += processed-schema.json
Documentation/devicetree/bindings/yamllint renamed from Documentation/devicetree/bindings/.yamllint +0 -0
similarity index 100%
rename from Documentation/devicetree/bindings/.yamllint
rename to Documentation/devicetree/bindings/yamllint
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Masahiro Yamada

This file is ignored by git by the '.*' rule in the top .gitignore.

I do not see a good reason why this should be a hidden file.

Only because that is the default name yamllint will pick up if it is run from the bindings directory. Not really something I do though.

Rob

#2 lore raw
Quoted 11 lines · Rob Herring
Quoted 4 lines · Masahiro Yamada

This file is ignored by git by the '.*' rule in the top .gitignore.

I do not see a good reason why this should be a hidden file.

Only because that is the default name yamllint will pick up if it is run from the bindings directory. Not really something I do though.

Rob

Or, do you prefer adding

!/.yamllint

to Documentation/devicetree/bindings/.gitignore ?

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw
Quoted 11 lines · Masahiro Yamada
Quoted 10 lines · Rob Herring
Quoted 4 lines · Masahiro Yamada

This file is ignored by git by the '.*' rule in the top .gitignore.

I do not see a good reason why this should be a hidden file.

Only because that is the default name yamllint will pick up if it is run from the bindings directory. Not really something I do though.

Quoted 8 lines
Quoted 1 line

Rob

Or, do you prefer adding

!/.yamllint

to Documentation/devicetree/bindings/.gitignore ?

https://lore.kernel.org/all/[email protected]/

Best regards,
Krzysztof