drm/i915: LVDS cleanup
Subsystems (3)
cover drm/i915: LVDS cleanup
From: Ville Syrjälä <[email protected]>
Some cleanup/modernization of the LVDS code.
Ville Syrjälä (8):
drm/i915/lvds: Split long lines
drm/i915/lvds: Use intel_de_rmw()
drm/i915/lvds: Use REG_BIT() & co.
drm/i915/lvds: Extract intel_lvds_regs.h
drm/i915/lvds: Fix whitespace
drm/i915/lvds: s/dev_priv/i915/
drm/i915/lvds: s/intel_encoder/encoder/ etc.
drm/i915/lvds: s/pipe_config/crtc_state/
drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_lvds.c | 332 +++++++++--------- .../gpu/drm/i915/display/intel_lvds_regs.h | 65 ++++ drivers/gpu/drm/i915/display/intel_panel.c | 1 + .../gpu/drm/i915/display/intel_pch_display.c | 1 + drivers/gpu/drm/i915/display/intel_pps.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 56 --- drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 + 8 files changed, 232 insertions(+), 226 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_lvds_regs.h
Signature · 1 line
2.39.1
PATCH 1/8 drm/i915/lvds: Split long lines
From: Ville Syrjälä <[email protected]>
Split some overly long lines.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +7 -3
@@ -216,13 +216,17 @@ static void intel_lvds_pps_init_hw(struct drm_i915_private *dev_priv,intel_de_write (dev_priv,PP_CONTROL (0 ), val);intel_de_write (dev_priv,PP_ON_DELAYS (0 ), -REG_FIELD_PREP (PANEL_PORT_SELECT_MASK , pps->port) |REG_FIELD_PREP (PANEL_POWER_UP_DELAY_MASK , pps->t1_t2) |REG_FIELD_PREP (PANEL_LIGHT_ON_DELAY_MASK , pps->t5)); +REG_FIELD_PREP (PANEL_PORT_SELECT_MASK , pps->port) | +REG_FIELD_PREP (PANEL_POWER_UP_DELAY_MASK , pps->t1_t2) | +REG_FIELD_PREP (PANEL_LIGHT_ON_DELAY_MASK , pps->t5));intel_de_write (dev_priv,PP_OFF_DELAYS (0 ), -REG_FIELD_PREP (PANEL_POWER_DOWN_DELAY_MASK , pps->t3) |REG_FIELD_PREP (PANEL_LIGHT_OFF_DELAY_MASK , pps->tx)); +REG_FIELD_PREP (PANEL_POWER_DOWN_DELAY_MASK , pps->t3) | +REG_FIELD_PREP (PANEL_LIGHT_OFF_DELAY_MASK , pps->tx));intel_de_write (dev_priv,PP_DIVISOR (0 ), -REG_FIELD_PREP (PP_REFERENCE_DIVIDER_MASK , pps->divider) |REG_FIELD_PREP (PANEL_POWER_CYCLE_DELAY_MASK ,DIV_ROUND_UP (pps->t4,1000 ) +1 )); +REG_FIELD_PREP (PP_REFERENCE_DIVIDER_MASK , pps->divider) | +REG_FIELD_PREP (PANEL_POWER_CYCLE_DELAY_MASK ,DIV_ROUND_UP (pps->t4,1000 ) +1 )); } static void intel_pre_enable_lvds(struct intel_atomic_state *state,
Signature · 1 line
2.39.1
PATCH 2/8 drm/i915/lvds: Use intel_de_rmw()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Replace the hand rolled rmw stuff with intel_de_rmw().
--- drivers/gpu/drm/i915/display/intel_lvds.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +4 -8
@@ -320,11 +320,9 @@ static void intel_enable_lvds(struct intel_atomic_state *state,struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);struct drm_i915_private *dev_priv =to_i915 (dev); -intel_de_write (dev_priv, lvds_encoder->reg, -intel_de_read (dev_priv, lvds_encoder->reg) |LVDS_PORT_EN ); +intel_de_rmw (dev_priv, lvds_encoder->reg,0 ,LVDS_PORT_EN ); -intel_de_write (dev_priv,PP_CONTROL (0 ), -intel_de_read (dev_priv,PP_CONTROL (0 )) |PANEL_POWER_ON ); +intel_de_rmw (dev_priv,PP_CONTROL (0 ),0 ,PANEL_POWER_ON );intel_de_posting_read (dev_priv, lvds_encoder->reg);if (intel_de_wait_for_set (dev_priv,PP_STATUS (0 ),PP_ON ,5000 ))
@@ -342,14 +340,12 @@ static void intel_disable_lvds(struct intel_atomic_state *state,struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); -intel_de_write (dev_priv,PP_CONTROL (0 ), -intel_de_read (dev_priv,PP_CONTROL (0 )) & ~PANEL_POWER_ON ); +intel_de_rmw (dev_priv,PP_CONTROL (0 ),PANEL_POWER_ON ,0 );if (intel_de_wait_for_clear (dev_priv,PP_STATUS (0 ),PP_ON ,1000 ))drm_err (&dev_priv->drm,"timed out waiting for panel to power off\n" ); -intel_de_write (dev_priv, lvds_encoder->reg, -intel_de_read (dev_priv, lvds_encoder->reg) & ~LVDS_PORT_EN ); +intel_de_rmw (dev_priv, lvds_encoder->reg,LVDS_PORT_EN ,0 );intel_de_posting_read (dev_priv, lvds_encoder->reg); }
Signature · 1 line
2.39.1
PATCH 3/8 drm/i915/lvds: Use REG_BIT() & co.
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Use REG_BIT() & co. for the LVDS port register.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 4 +- drivers/gpu/drm/i915/i915_reg.h | 46 +++++++++++------------ 2 files changed, 24 insertions(+), 26 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +2 -2
@@ -93,9 +93,9 @@ bool intel_lvds_port_enabled(struct drm_i915_private *dev_priv,/* asserts want to know the pipe even if the port is disabled */ if (HAS_PCH_CPT (dev_priv)) - *pipe = (val &LVDS_PIPE_SEL_MASK_CPT ) >>LVDS_PIPE_SEL_SHIFT_CPT ; + *pipe =REG_FIELD_GET (LVDS_PIPE_SEL_MASK_CPT , val);else - *pipe = (val &LVDS_PIPE_SEL_MASK ) >>LVDS_PIPE_SEL_SHIFT ; + *pipe =REG_FIELD_GET (LVDS_PIPE_SEL_MASK , val);return val &LVDS_PORT_EN ; }
drivers/gpu/drm/i915/i915_reg.h +22 -24
81 lines not on this page · raw message
Signature · 1 line
2.39.1
PATCH 4/8 drm/i915/lvds: Extract intel_lvds_regs.h
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Extract the integrated LVDS port register definitions into their own header file.
--- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_lvds.c | 1 + .../gpu/drm/i915/display/intel_lvds_regs.h | 65 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_panel.c | 1 + .../gpu/drm/i915/display/intel_pch_display.c | 1 + drivers/gpu/drm/i915/display/intel_pps.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 54 --------------- drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 + 8 files changed, 71 insertions(+), 54 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_lvds_regs.h
drivers/gpu/drm/i915/display/intel_display.c +1 -0
@@ -94,6 +94,7 @@#include "intel_hotplug.h" #include "intel_hti.h" #include "intel_lvds.h" +#include "intel_lvds_regs.h" #include "intel_modeset_setup.h" #include "intel_modeset_verify.h" #include "intel_overlay.h"
drivers/gpu/drm/i915/display/intel_lvds.c +1 -0
@@ -49,6 +49,7 @@#include "intel_fdi.h" #include "intel_gmbus.h" #include "intel_lvds.h" +#include "intel_lvds_regs.h" #include "intel_panel.h" /* Private structure for the integrated LVDS support */
drivers/gpu/drm/i915/display/intel_lvds_regs.h new file +65 -0
65 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_panel.c +1 -0
@@ -39,6 +39,7 @@#include "intel_de.h" #include "intel_display_types.h" #include "intel_drrs.h" +#include "intel_lvds_regs.h" #include "intel_panel.h" #include "intel_quirks.h"
drivers/gpu/drm/i915/display/intel_pch_display.c +1 -0
@@ -10,6 +10,7 @@#include "intel_display_types.h" #include "intel_fdi.h" #include "intel_lvds.h" +#include "intel_lvds_regs.h" #include "intel_pch_display.h" #include "intel_pch_refclk.h" #include "intel_pps.h"
drivers/gpu/drm/i915/display/intel_pps.c +1 -0
@@ -13,6 +13,7 @@#include "intel_dpio_phy.h" #include "intel_dpll.h" #include "intel_lvds.h" +#include "intel_lvds_regs.h" #include "intel_pps.h" #include "intel_quirks.h"
drivers/gpu/drm/i915/i915_reg.h +0 -54
66 lines not on this page · raw message
drivers/gpu/drm/i915/intel_gvt_mmio_table.c +1 -0
@@ -8,6 +8,7 @@#include "display/intel_display_types.h" #include "display/intel_dmc_regs.h" #include "display/intel_dpio_phy.h" +#include "display/intel_lvds_regs.h" #include "display/vlv_dsi_pll_regs.h" #include "gt/intel_gt_regs.h" #include "gvt/gvt.h"
Signature · 1 line
2.39.1
PATCH 5/8 drm/i915/lvds: Fix whitespace
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Replace some stray spaes with tabs.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 28 +++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +14 -14
@@ -586,12 +586,12 @@ static const struct dmi_system_id intel_no_lvds[] = { }, { .callback = intel_no_lvds_dmi_callback, - .ident = "AOpen i45GMx-I", - .matches = { -DMI_MATCH (DMI_BOARD_VENDOR ,"AOpen" ), - DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"), - }, - }, + .ident = "AOpen i45GMx-I", + .matches = { +DMI_MATCH (DMI_BOARD_VENDOR ,"AOpen" ), + DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"), + }, + }, { .callback = intel_no_lvds_dmi_callback, .ident = "Aopen i945GTt-VFA",
@@ -608,14 +608,14 @@ static const struct dmi_system_id intel_no_lvds[] = { }, }, { - .callback = intel_no_lvds_dmi_callback, - .ident = "Clientron E830", - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Clientron" ), - DMI_MATCH(DMI_PRODUCT_NAME, "E830"), - }, - }, - { + .callback = intel_no_lvds_dmi_callback, + .ident = "Clientron E830", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Clientron" ), + DMI_MATCH(DMI_PRODUCT_NAME, "E830"), + }, + }, + { .callback = intel_no_lvds_dmi_callback, .ident = "Asus EeeBox PC EB1007", .matches = {
Signature · 1 line
2.39.1
PATCH 6/8 drm/i915/lvds: s/dev_priv/i915/
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Do the customary s/dev_priv/i915/ rename and alising 'dev' pointer removal. Though various register definitons still depend on the magic 'dev_priv' variable so not a 100% conversion.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 111 +++++++++++----------- 1 file changed, 54 insertions(+), 57 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +54 -57
@@ -85,15 +85,15 @@ static struct intel_lvds_encoder *to_lvds_encoder(struct intel_encoder *encoder) return container_of(encoder, struct intel_lvds_encoder, base); } -bool intel_lvds_port_enabled (struct drm_i915_private *dev_priv, +bool intel_lvds_port_enabled (struct drm_i915_private *i915,i915_reg_t lvds_reg,enum pipe *pipe) {u32 val; - val =intel_de_read (dev_priv, lvds_reg); + val =intel_de_read (i915, lvds_reg);/* asserts want to know the pipe even if the port is disabled */ -if (HAS_PCH_CPT (dev_priv)) +if (HAS_PCH_CPT (i915)) *pipe =REG_FIELD_GET (LVDS_PIPE_SEL_MASK_CPT , val);else *pipe =REG_FIELD_GET (LVDS_PIPE_SEL_MASK , val);
@@ -104,19 +104,18 @@ bool intel_lvds_port_enabled(struct drm_i915_private *dev_priv,static bool intel_lvds_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe) { -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct drm_i915_private *i915 =to_i915 (encoder->base.dev);struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);intel_wakeref_t wakeref;bool ret; - wakeref =intel_display_power_get_if_enabled (dev_priv, - encoder->power_domain); + wakeref =intel_display_power_get_if_enabled (i915, encoder->power_domain);if (!wakeref)return false; - ret =intel_lvds_port_enabled (dev_priv, lvds_encoder->reg, pipe); + ret =intel_lvds_port_enabled (i915, lvds_encoder->reg, pipe); -intel_display_power_put (dev_priv, encoder->power_domain, wakeref); +intel_display_power_put (i915, encoder->power_domain, wakeref);return ret; }
@@ -236,26 +235,25 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state, const struct drm_connector_state *conn_state) {struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder); -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct drm_i915_private *i915 =to_i915 (encoder->base.dev);struct intel_crtc *crtc =to_intel_crtc (pipe_config->uapi.crtc);const struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode;enum pipe pipe = crtc->pipe;u32 temp; -if (HAS_PCH_SPLIT (dev_priv)) { -assert_fdi_rx_pll_disabled (dev_priv, pipe); -assert_shared_dpll_disabled (dev_priv, - pipe_config->shared_dpll); +if (HAS_PCH_SPLIT (i915)) { +assert_fdi_rx_pll_disabled (i915, pipe); +assert_shared_dpll_disabled (i915, pipe_config->shared_dpll); }else { -assert_pll_disabled (dev_priv, pipe); +assert_pll_disabled (i915, pipe); } -intel_lvds_pps_init_hw (dev_priv, &lvds_encoder->init_pps); +intel_lvds_pps_init_hw (i915, &lvds_encoder->init_pps); temp = lvds_encoder->init_lvds_val; temp |=LVDS_PORT_EN |LVDS_A0A2_CLKA_POWER_UP ; -if (HAS_PCH_CPT (dev_priv)) { +if (HAS_PCH_CPT (i915)) { temp &= ~LVDS_PIPE_SEL_MASK_CPT ; temp |=LVDS_PIPE_SEL_CPT (pipe); }else {
@@ -290,7 +288,7 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state,* special lvds dither control bit on pch-split platforms, dithering is * only controlled through the PIPECONF reg. */ -if (DISPLAY_VER (dev_priv) ==4 ) { +if (DISPLAY_VER (i915) ==4 ) {/* * Bspec wording suggests that LVDS port dithering only exists * for 18bpp panels.
@@ -306,7 +304,7 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state,if (adjusted_mode->flags &DRM_MODE_FLAG_NVSYNC ) temp |=LVDS_VSYNC_POLARITY ; -intel_de_write (dev_priv, lvds_encoder->reg, temp); +intel_de_write (i915, lvds_encoder->reg, temp); }/*
@@ -317,9 +315,8 @@ static void intel_enable_lvds(struct intel_atomic_state *state,const struct intel_crtc_state *pipe_config, const struct drm_connector_state *conn_state) { - struct drm_device *dev = encoder->base.dev; struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(encoder); -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);intel_de_rmw (dev_priv, lvds_encoder->reg,0 ,LVDS_PORT_EN );
@@ -413,7 +410,7 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder,struct intel_crtc_state *pipe_config, struct drm_connector_state *conn_state) { - struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev); + struct drm_i915_private *i915 = to_i915(intel_encoder->base.dev);struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (intel_encoder); struct intel_connector *intel_connector =
@@ -424,8 +421,8 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder,int ret;/* Should never happen!! */ -if (DISPLAY_VER (dev_priv) <4 && crtc->pipe ==0 ) { -drm_err (&dev_priv->drm,"Can't support LVDS on pipe A\n" ); +if (DISPLAY_VER (i915) <4 && crtc->pipe ==0 ) { +drm_err (&i915->drm,"Can't support LVDS on pipe A\n" );return -EINVAL ; }
@@ -435,7 +432,7 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder, lvds_bpp =6 *3 ;if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) { -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"forcing display bpp (was %d) to LVDS (%d)\n" , pipe_config->pipe_bpp, lvds_bpp); pipe_config->pipe_bpp = lvds_bpp;
@@ -456,7 +453,7 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder,if (adjusted_mode->flags &DRM_MODE_FLAG_DBLSCAN )return -EINVAL ; -if (HAS_PCH_SPLIT (dev_priv)) +if (HAS_PCH_SPLIT (i915)) pipe_config->has_pch_encoder = true; ret =intel_panel_fitting (pipe_config, conn_state);
@@ -765,11 +762,11 @@ static const struct dmi_system_id intel_dual_link_lvds[] = { { }/* terminating entry */ }; -struct intel_encoder *intel_get_lvds_encoder (struct drm_i915_private *dev_priv) +struct intel_encoder *intel_get_lvds_encoder (struct drm_i915_private *i915) {struct intel_encoder *encoder; -for_each_intel_encoder (&dev_priv->drm, encoder) { +for_each_intel_encoder (&i915->drm, encoder) {if (encoder->type ==INTEL_OUTPUT_LVDS )return encoder; }
@@ -777,24 +774,24 @@ struct intel_encoder *intel_get_lvds_encoder(struct drm_i915_private *dev_priv)return NULL ; } -bool intel_is_dual_link_lvds (struct drm_i915_private *dev_priv) +bool intel_is_dual_link_lvds (struct drm_i915_private *i915) { -struct intel_encoder *encoder =intel_get_lvds_encoder (dev_priv); +struct intel_encoder *encoder =intel_get_lvds_encoder (i915);return encoder &&to_lvds_encoder (encoder)->is_dual_link; }static bool compute_is_dual_link_lvds (struct intel_lvds_encoder *lvds_encoder) { -struct drm_i915_private *dev_priv =to_i915 (lvds_encoder->base.base.dev); +struct drm_i915_private *i915 =to_i915 (lvds_encoder->base.base.dev);struct intel_connector *connector = lvds_encoder->attached_connector;const struct drm_display_mode *fixed_mode =intel_panel_preferred_fixed_mode (connector);unsigned int val;/* use the module option value if specified */ -if (dev_priv->params.lvds_channel_mode >0 ) -return dev_priv->params.lvds_channel_mode ==2 ; +if (i915->params.lvds_channel_mode >0 ) +return i915->params.lvds_channel_mode ==2 ;/* single channel LVDS is limited to 112 MHz */ if (fixed_mode->clock >112999 )
@@ -809,8 +806,8 @@ static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)* we need to check "the value to be set" in VBT when LVDS * register is uninitialized. */ - val =intel_de_read (dev_priv, lvds_encoder->reg); -if (HAS_PCH_CPT (dev_priv)) + val =intel_de_read (i915, lvds_encoder->reg); +if (HAS_PCH_CPT (i915)) val &= ~(LVDS_DETECTED |LVDS_PIPE_SEL_MASK_CPT );else val &= ~(LVDS_DETECTED |LVDS_PIPE_SEL_MASK );
@@ -827,12 +824,12 @@ static void intel_lvds_add_properties(struct drm_connector *connector)/** * intel_lvds_init - setup LVDS connectors on this device -* @dev_priv: i915 device +* @i915: i915 device * * Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). */ -void intel_lvds_init (struct drm_i915_private *dev_priv) +void intel_lvds_init (struct drm_i915_private *i915) {struct intel_lvds_encoder *lvds_encoder;struct intel_encoder *intel_encoder;
@@ -846,37 +843,37 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)/* Skip init on machines we know falsely report LVDS */ if (dmi_check_system (intel_no_lvds)) { -drm_WARN (&dev_priv->drm, !dev_priv->display.vbt.int_lvds_support, +drm_WARN (&i915->drm, !i915->display.vbt.int_lvds_support,"Useless DMI match. Internal LVDS support disabled by VBT\n" );return ; } -if (!dev_priv->display.vbt.int_lvds_support) { -drm_dbg_kms (&dev_priv->drm, +if (!i915->display.vbt.int_lvds_support) { +drm_dbg_kms (&i915->drm,"Internal LVDS support disabled by VBT\n" );return ; } -if (HAS_PCH_SPLIT (dev_priv)) +if (HAS_PCH_SPLIT (i915)) lvds_reg =PCH_LVDS ;else lvds_reg =LVDS ; - lvds =intel_de_read (dev_priv, lvds_reg); + lvds =intel_de_read (i915, lvds_reg); -if (HAS_PCH_SPLIT (dev_priv)) { +if (HAS_PCH_SPLIT (i915)) {if ((lvds &LVDS_DETECTED ) ==0 )return ; } pin =GMBUS_PIN_PANEL ; -if (!intel_bios_is_lvds_present (dev_priv, &pin)) { +if (!intel_bios_is_lvds_present (i915, &pin)) {if ((lvds &LVDS_PORT_EN ) ==0 ) { -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"LVDS is not present in VBT\n" );return ; } -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"LVDS is not present in VBT, but enabled anyway\n" ); }
@@ -895,16 +892,16 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) intel_encoder = &lvds_encoder->base; encoder = &intel_encoder->base; connector = &intel_connector->base; -drm_connector_init (&dev_priv->drm, &intel_connector->base, &intel_lvds_connector_funcs, +drm_connector_init (&i915->drm, &intel_connector->base, &intel_lvds_connector_funcs,DRM_MODE_CONNECTOR_LVDS ); -drm_encoder_init (&dev_priv->drm, &intel_encoder->base, &intel_lvds_enc_funcs, +drm_encoder_init (&i915->drm, &intel_encoder->base, &intel_lvds_enc_funcs,DRM_MODE_ENCODER_LVDS ,"LVDS" ); intel_encoder->enable = intel_enable_lvds; intel_encoder->pre_enable = intel_pre_enable_lvds; intel_encoder->compute_config = intel_lvds_compute_config; -if (HAS_PCH_SPLIT (dev_priv)) { +if (HAS_PCH_SPLIT (i915)) { intel_encoder->disable = pch_disable_lvds; intel_encoder->post_disable = pch_post_disable_lvds; }else {
@@ -922,7 +919,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) intel_encoder->power_domain =POWER_DOMAIN_PORT_OTHER ; intel_encoder->port =PORT_NONE ; intel_encoder->cloneable =0 ; -if (DISPLAY_VER (dev_priv) <4 ) +if (DISPLAY_VER (i915) <4 ) intel_encoder->pipe_mask =BIT (PIPE_B );else intel_encoder->pipe_mask = ~0 ;
@@ -934,7 +931,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)intel_lvds_add_properties (connector); -intel_lvds_pps_get_hw_state (dev_priv, &lvds_encoder->init_pps); +intel_lvds_pps_get_hw_state (i915, &lvds_encoder->init_pps); lvds_encoder->init_lvds_val = lvds;/*
@@ -949,13 +946,13 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)* Attempt to get the fixed panel mode from DDC. Assume that the * preferred mode is the right one. */ -mutex_lock (&dev_priv->drm.mode_config.mutex); +mutex_lock (&i915->drm.mode_config.mutex);if (vga_switcheroo_handler_flags () &VGA_SWITCHEROO_CAN_SWITCH_DDC ) {const struct edid *edid;/* FIXME: Make drm_get_edid_switcheroo() return drm_edid */ edid =drm_get_edid_switcheroo (connector, -intel_gmbus_get_adapter (dev_priv, pin)); +intel_gmbus_get_adapter (i915, pin));if (edid) { drm_edid =drm_edid_alloc (edid, (edid->extensions +1 ) *EDID_LENGTH );kfree (edid);
@@ -964,7 +961,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) } }else { drm_edid =drm_edid_read_ddc (connector, -intel_gmbus_get_adapter (dev_priv, pin)); +intel_gmbus_get_adapter (i915, pin)); }if (drm_edid) { if (drm_edid_connector_update(connector, drm_edid) ||
@@ -976,7 +973,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) }else { drm_edid =ERR_PTR (-ENOENT ); } -intel_bios_init_panel_late (dev_priv, &intel_connector->panel,NULL , +intel_bios_init_panel_late (i915, &intel_connector->panel,NULL ,IS_ERR (drm_edid) ?NULL : drm_edid);/* Try EDID first */
@@ -994,7 +991,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)if (!intel_panel_preferred_fixed_mode (intel_connector))intel_panel_add_encoder_fixed_mode (intel_connector, intel_encoder); -mutex_unlock (&dev_priv->drm.mode_config.mutex); +mutex_unlock (&i915->drm.mode_config.mutex);/* If we still don't have a mode after all that, give up. */ if (!intel_panel_preferred_fixed_mode (intel_connector))
@@ -1005,7 +1002,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)intel_backlight_setup (intel_connector,INVALID_PIPE ); lvds_encoder->is_dual_link =compute_is_dual_link_lvds (lvds_encoder); -drm_dbg_kms (&dev_priv->drm,"detected %s-link lvds configuration\n" , +drm_dbg_kms (&i915->drm,"detected %s-link lvds configuration\n" , lvds_encoder->is_dual_link ?"dual" :"single" ); lvds_encoder->a3_power = lvds &LVDS_A3_POWER_MASK ;
@@ -1013,7 +1010,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)return ; failed: -drm_dbg_kms (&dev_priv->drm,"No LVDS modes found, disabling.\n" ); +drm_dbg_kms (&i915->drm,"No LVDS modes found, disabling.\n" );drm_connector_cleanup (connector);drm_encoder_cleanup (encoder);kfree (lvds_encoder);
Signature · 1 line
2.39.1
PATCH 7/8 drm/i915/lvds: s/intel_encoder/encoder/ etc.
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Get rid of the some of the annoying aliasing drm_ vs. intel_ encoder/connector variables. Just prefer the intel_ types.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 130 +++++++++++----------- 1 file changed, 62 insertions(+), 68 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +62 -68
@@ -384,19 +384,19 @@ static void intel_lvds_shutdown(struct intel_encoder *encoder) }static enum drm_mode_status -intel_lvds_mode_valid (struct drm_connector *connector, +intel_lvds_mode_valid (struct drm_connector *_connector,struct drm_display_mode *mode) { -struct intel_connector *intel_connector =to_intel_connector (connector); +struct intel_connector *connector =to_intel_connector (_connector);const struct drm_display_mode *fixed_mode = -intel_panel_fixed_mode (intel_connector, mode); -int max_pixclk =to_i915 (connector->dev)->max_dotclk_freq; +intel_panel_fixed_mode (connector, mode); +int max_pixclk =to_i915 (connector->base.dev)->max_dotclk_freq;enum drm_mode_status status;if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ; - status =intel_panel_mode_valid (intel_connector, mode); + status =intel_panel_mode_valid (connector, mode);if (status !=MODE_OK )return status;
@@ -406,15 +406,13 @@ intel_lvds_mode_valid(struct drm_connector *connector,return MODE_OK ; } -static int intel_lvds_compute_config (struct intel_encoder *intel_encoder, +static int intel_lvds_compute_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config,struct drm_connector_state *conn_state) { -struct drm_i915_private *i915 =to_i915 (intel_encoder->base.dev); -struct intel_lvds_encoder *lvds_encoder = -to_lvds_encoder (intel_encoder); -struct intel_connector *intel_connector = - lvds_encoder->attached_connector; +struct drm_i915_private *i915 =to_i915 (encoder->base.dev); +struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder); +struct intel_connector *connector = lvds_encoder->attached_connector;struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode;struct intel_crtc *crtc =to_intel_crtc (pipe_config->uapi.crtc);unsigned int lvds_bpp;
@@ -446,7 +444,7 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder,* with the panel scaling set up to source from the H/VDisplay * of the original mode. */ - ret =intel_panel_compute_config (intel_connector, adjusted_mode); + ret =intel_panel_compute_config (connector, adjusted_mode);if (ret)return ret;
@@ -472,19 +470,19 @@ static int intel_lvds_compute_config(struct intel_encoder *intel_encoder,/* * Return the list of DDC modes if available, or the BIOS fixed mode otherwise. */ -static int intel_lvds_get_modes (struct drm_connector *connector) +static int intel_lvds_get_modes (struct drm_connector *_connector) { -struct intel_connector *intel_connector =to_intel_connector (connector); -const struct drm_edid *fixed_edid = intel_connector->panel.fixed_edid; +struct intel_connector *connector =to_intel_connector (_connector); +const struct drm_edid *fixed_edid = connector->panel.fixed_edid;/* Use panel fixed edid if we have one */ if (!IS_ERR_OR_NULL (fixed_edid)) { -drm_edid_connector_update (connector, fixed_edid); +drm_edid_connector_update (&connector->base, fixed_edid); -return drm_edid_connector_add_modes (connector); +return drm_edid_connector_add_modes (&connector->base); } -return intel_panel_get_modes (intel_connector); +return intel_panel_get_modes (connector); }static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
@@ -832,11 +830,9 @@ static void intel_lvds_add_properties(struct drm_connector *connector)void intel_lvds_init (struct drm_i915_private *i915) {struct intel_lvds_encoder *lvds_encoder; -struct intel_encoder *intel_encoder; -struct intel_connector *intel_connector; -struct drm_connector *connector; -struct drm_encoder *encoder; +struct intel_connector *connector;const struct drm_edid *drm_edid; +struct intel_encoder *encoder;i915_reg_t lvds_reg;u32 lvds;u8 pin;
@@ -881,55 +877,53 @@ void intel_lvds_init(struct drm_i915_private *i915)if (!lvds_encoder)return ; - intel_connector =intel_connector_alloc (); -if (!intel_connector) { + connector =intel_connector_alloc (); +if (!connector) {kfree (lvds_encoder);return ; } - lvds_encoder->attached_connector = intel_connector; + lvds_encoder->attached_connector = connector; + encoder = &lvds_encoder->base; - intel_encoder = &lvds_encoder->base; - encoder = &intel_encoder->base; - connector = &intel_connector->base; -drm_connector_init (&i915->drm, &intel_connector->base, &intel_lvds_connector_funcs, +drm_connector_init (&i915->drm, &connector->base, &intel_lvds_connector_funcs,DRM_MODE_CONNECTOR_LVDS ); -drm_encoder_init (&i915->drm, &intel_encoder->base, &intel_lvds_enc_funcs, +drm_encoder_init (&i915->drm, &encoder->base, &intel_lvds_enc_funcs,DRM_MODE_ENCODER_LVDS ,"LVDS" ); - intel_encoder->enable = intel_enable_lvds; - intel_encoder->pre_enable = intel_pre_enable_lvds; - intel_encoder->compute_config = intel_lvds_compute_config; + encoder->enable = intel_enable_lvds; + encoder->pre_enable = intel_pre_enable_lvds; + encoder->compute_config = intel_lvds_compute_config;if (HAS_PCH_SPLIT (i915)) { - intel_encoder->disable = pch_disable_lvds; - intel_encoder->post_disable = pch_post_disable_lvds; + encoder->disable = pch_disable_lvds; + encoder->post_disable = pch_post_disable_lvds; }else { - intel_encoder->disable = gmch_disable_lvds; + encoder->disable = gmch_disable_lvds; } - intel_encoder->get_hw_state = intel_lvds_get_hw_state; - intel_encoder->get_config = intel_lvds_get_config; - intel_encoder->update_pipe = intel_backlight_update; - intel_encoder->shutdown = intel_lvds_shutdown; - intel_connector->get_hw_state = intel_connector_get_hw_state; + encoder->get_hw_state = intel_lvds_get_hw_state; + encoder->get_config = intel_lvds_get_config; + encoder->update_pipe = intel_backlight_update; + encoder->shutdown = intel_lvds_shutdown; + connector->get_hw_state = intel_connector_get_hw_state; -intel_connector_attach_encoder (intel_connector, intel_encoder); +intel_connector_attach_encoder (connector, encoder); - intel_encoder->type =INTEL_OUTPUT_LVDS ; - intel_encoder->power_domain =POWER_DOMAIN_PORT_OTHER ; - intel_encoder->port =PORT_NONE ; - intel_encoder->cloneable =0 ; + encoder->type =INTEL_OUTPUT_LVDS ; + encoder->power_domain =POWER_DOMAIN_PORT_OTHER ; + encoder->port =PORT_NONE ; + encoder->cloneable =0 ;if (DISPLAY_VER (i915) <4 ) - intel_encoder->pipe_mask =BIT (PIPE_B ); + encoder->pipe_mask =BIT (PIPE_B );else - intel_encoder->pipe_mask = ~0 ; + encoder->pipe_mask = ~0 ; -drm_connector_helper_add (connector, &intel_lvds_connector_helper_funcs); - connector->display_info.subpixel_order = SubPixelHorizontalRGB; +drm_connector_helper_add (&connector->base, &intel_lvds_connector_helper_funcs); + connector->base.display_info.subpixel_order = SubPixelHorizontalRGB; lvds_encoder->reg = lvds_reg; -intel_lvds_add_properties (connector); +intel_lvds_add_properties (&connector->base);intel_lvds_pps_get_hw_state (i915, &lvds_encoder->init_pps); lvds_encoder->init_lvds_val = lvds;
@@ -951,7 +945,7 @@ void intel_lvds_init(struct drm_i915_private *i915)const struct edid *edid;/* FIXME: Make drm_get_edid_switcheroo() return drm_edid */ - edid =drm_get_edid_switcheroo (connector, + edid =drm_get_edid_switcheroo (&connector->base,intel_gmbus_get_adapter (i915, pin));if (edid) { drm_edid =drm_edid_alloc (edid, (edid->extensions +1 ) *EDID_LENGTH );
@@ -960,46 +954,46 @@ void intel_lvds_init(struct drm_i915_private *i915) drm_edid =NULL ; } }else { - drm_edid =drm_edid_read_ddc (connector, + drm_edid =drm_edid_read_ddc (&connector->base,intel_gmbus_get_adapter (i915, pin)); }if (drm_edid) { -if (drm_edid_connector_update (connector, drm_edid) || - !drm_edid_connector_add_modes (connector)) { -drm_edid_connector_update (connector,NULL ); +if (drm_edid_connector_update (&connector->base, drm_edid) || + !drm_edid_connector_add_modes (&connector->base)) { +drm_edid_connector_update (&connector->base,NULL );drm_edid_free (drm_edid); drm_edid =ERR_PTR (-EINVAL ); } }else { drm_edid =ERR_PTR (-ENOENT ); } -intel_bios_init_panel_late (i915, &intel_connector->panel,NULL , +intel_bios_init_panel_late (i915, &connector->panel,NULL ,IS_ERR (drm_edid) ?NULL : drm_edid);/* Try EDID first */ -intel_panel_add_edid_fixed_modes (intel_connector, true); +intel_panel_add_edid_fixed_modes (connector, true);/* Failed to get EDID, what about VBT? */ -if (!intel_panel_preferred_fixed_mode (intel_connector)) -intel_panel_add_vbt_lfp_fixed_mode (intel_connector); +if (!intel_panel_preferred_fixed_mode (connector)) +intel_panel_add_vbt_lfp_fixed_mode (connector);/* * If we didn't get a fixed mode from EDID or VBT, try checking * if the panel is already turned on. If so, assume that * whatever is currently programmed is the correct mode. */ -if (!intel_panel_preferred_fixed_mode (intel_connector)) -intel_panel_add_encoder_fixed_mode (intel_connector, intel_encoder); +if (!intel_panel_preferred_fixed_mode (connector)) +intel_panel_add_encoder_fixed_mode (connector, encoder);mutex_unlock (&i915->drm.mode_config.mutex);/* If we still don't have a mode after all that, give up. */ -if (!intel_panel_preferred_fixed_mode (intel_connector)) +if (!intel_panel_preferred_fixed_mode (connector)) goto failed; -intel_panel_init (intel_connector, drm_edid); +intel_panel_init (connector, drm_edid); -intel_backlight_setup (intel_connector,INVALID_PIPE ); +intel_backlight_setup (connector,INVALID_PIPE ); lvds_encoder->is_dual_link =compute_is_dual_link_lvds (lvds_encoder); drm_dbg_kms(&i915->drm, "detected %s-link lvds configuration\n",
@@ -1011,9 +1005,9 @@ void intel_lvds_init(struct drm_i915_private *i915) failed:drm_dbg_kms (&i915->drm,"No LVDS modes found, disabling.\n" ); -drm_connector_cleanup (connector); -drm_encoder_cleanup (encoder); +drm_connector_cleanup (&connector->base); +drm_encoder_cleanup (&encoder->base);kfree (lvds_encoder); -intel_connector_free (intel_connector); +intel_connector_free (connector);return ; }
Signature · 1 line
2.39.1
PATCH 8/8 drm/i915/lvds: s/pipe_config/crtc_state/
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Call the crtc state 'crtc_state' rather than 'pipe_config', as is the modern style.
--- drivers/gpu/drm/i915/display/intel_lvds.c | 46 +++++++++++------------ 1 file changed, 23 insertions(+), 23 deletions(-)
drivers/gpu/drm/i915/display/intel_lvds.c +23 -23
@@ -121,13 +121,13 @@ static bool intel_lvds_get_hw_state(struct intel_encoder *encoder, }static void intel_lvds_get_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config) +struct intel_crtc_state *crtc_state) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);u32 tmp, flags =0 ; - pipe_config->output_types |=BIT (INTEL_OUTPUT_LVDS ); + crtc_state->output_types |=BIT (INTEL_OUTPUT_LVDS ); tmp =intel_de_read (dev_priv, lvds_encoder->reg);if (tmp &LVDS_HSYNC_POLARITY )
@@ -139,20 +139,20 @@ static void intel_lvds_get_config(struct intel_encoder *encoder,else flags |=DRM_MODE_FLAG_PVSYNC ; - pipe_config->hw.adjusted_mode.flags |= flags; + crtc_state->hw.adjusted_mode.flags |= flags;if (DISPLAY_VER (dev_priv) <5 ) - pipe_config->gmch_pfit.lvds_border_bits = + crtc_state->gmch_pfit.lvds_border_bits = tmp &LVDS_BORDER_ENABLE ;/* gen2/3 store dither state in pfit control, needs to match */ if (DISPLAY_VER (dev_priv) <4 ) { tmp =intel_de_read (dev_priv,PFIT_CONTROL ); - pipe_config->gmch_pfit.control |= tmp &PANEL_8TO6_DITHER_ENABLE ; + crtc_state->gmch_pfit.control |= tmp &PANEL_8TO6_DITHER_ENABLE ; } - pipe_config->hw.adjusted_mode.crtc_clock = pipe_config->port_clock; + crtc_state->hw.adjusted_mode.crtc_clock = crtc_state->port_clock; } static void intel_lvds_pps_get_hw_state(struct drm_i915_private *dev_priv,
@@ -231,19 +231,19 @@ static void intel_lvds_pps_init_hw(struct drm_i915_private *dev_priv,static void intel_pre_enable_lvds (struct intel_atomic_state *state,struct intel_encoder *encoder, -const struct intel_crtc_state *pipe_config, +const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state) {struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);struct drm_i915_private *i915 =to_i915 (encoder->base.dev); -struct intel_crtc *crtc =to_intel_crtc (pipe_config->uapi.crtc); -const struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;enum pipe pipe = crtc->pipe;u32 temp;if (HAS_PCH_SPLIT (i915)) {assert_fdi_rx_pll_disabled (i915, pipe); -assert_shared_dpll_disabled (i915, pipe_config->shared_dpll); +assert_shared_dpll_disabled (i915, crtc_state->shared_dpll); }else {assert_pll_disabled (i915, pipe); }
@@ -263,7 +263,7 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state,/* set the corresponsding LVDS_BORDER bit */ temp &= ~LVDS_BORDER_ENABLE ; - temp |= pipe_config->gmch_pfit.lvds_border_bits; + temp |= crtc_state->gmch_pfit.lvds_border_bits;/* * Set the B0-B3 data pairs corresponding to whether we're going to
@@ -293,7 +293,7 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state,* Bspec wording suggests that LVDS port dithering only exists * for 18bpp panels. */ -if (pipe_config->dither && pipe_config->pipe_bpp ==18 ) +if (crtc_state->dither && crtc_state->pipe_bpp ==18 ) temp |=LVDS_ENABLE_DITHER ;else temp &= ~LVDS_ENABLE_DITHER ;
@@ -312,7 +312,7 @@ static void intel_pre_enable_lvds(struct intel_atomic_state *state,*/ static void intel_enable_lvds (struct intel_atomic_state *state,struct intel_encoder *encoder, -const struct intel_crtc_state *pipe_config, +const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state) {struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);
@@ -327,7 +327,7 @@ static void intel_enable_lvds(struct intel_atomic_state *state,drm_err (&dev_priv->drm,"timed out waiting for panel to power on\n" ); -intel_backlight_enable (pipe_config, conn_state); +intel_backlight_enable (crtc_state, conn_state); } static void intel_disable_lvds(struct intel_atomic_state *state,
@@ -407,14 +407,14 @@ intel_lvds_mode_valid(struct drm_connector *_connector, }static int intel_lvds_compute_config (struct intel_encoder *encoder, -struct intel_crtc_state *pipe_config, +struct intel_crtc_state *crtc_state,struct drm_connector_state *conn_state) {struct drm_i915_private *i915 =to_i915 (encoder->base.dev);struct intel_lvds_encoder *lvds_encoder =to_lvds_encoder (encoder);struct intel_connector *connector = lvds_encoder->attached_connector; -struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode; -struct intel_crtc *crtc =to_intel_crtc (pipe_config->uapi.crtc); +struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode; +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);unsigned int lvds_bpp;int ret;
@@ -429,14 +429,14 @@ static int intel_lvds_compute_config(struct intel_encoder *encoder,else lvds_bpp =6 *3 ; -if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) { +if (lvds_bpp != crtc_state->pipe_bpp && !crtc_state->bw_constrained) {drm_dbg_kms (&i915->drm,"forcing display bpp (was %d) to LVDS (%d)\n" , - pipe_config->pipe_bpp, lvds_bpp); - pipe_config->pipe_bpp = lvds_bpp; + crtc_state->pipe_bpp, lvds_bpp); + crtc_state->pipe_bpp = lvds_bpp; } - pipe_config->output_format =INTEL_OUTPUT_FORMAT_RGB ; + crtc_state->output_format =INTEL_OUTPUT_FORMAT_RGB ;/* * We have timings from the BIOS for the panel, put them in
@@ -452,9 +452,9 @@ static int intel_lvds_compute_config(struct intel_encoder *encoder,return -EINVAL ;if (HAS_PCH_SPLIT (i915)) - pipe_config->has_pch_encoder = true; + crtc_state->has_pch_encoder = true; - ret =intel_panel_fitting (pipe_config, conn_state); + ret =intel_panel_fitting (crtc_state, conn_state);if (ret)return ret;
Signature · 1 line
2.39.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: LVDS cleanup
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: LVDS cleanup
URL : https://patchwork.freedesktop.org/series/113503/
State : warning
== Summary ==
Error: dim checkpatch faileded78aebbde6f drm/i915/lvds: Split long lines
-:34: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #34: FILE: drivers/gpu/drm/i915/display/intel_lvds.c:229:
+ REG_FIELD_PREP(PANEL_POWER_CYCLE_DELAY_MASK, DIV_ROUND_UP(pps->t4, 1000) + 1));
total: 0 errors, 1 warnings, 0 checks, 20 lines checkedd349e9ae1383 drm/i915/lvds: Use intel_de_rmw()a2ddc2b5a37a drm/i915/lvds: Use REG_BIT() & co.c7d9325b3ecf drm/i915/lvds: Extract intel_lvds_regs.h
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #39:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 173 lines checked a315da9bcc1a drm/i915/lvds: Fix whitespace de3f39fece6a drm/i915/lvds: s/dev_priv/i915/ b3f145849bf5 drm/i915/lvds: s/intel_encoder/encoder/ etc. -:189: CHECK:CAMELCASE: Avoid CamelCase: <SubPixelHorizontalRGB> #189: FILE: drivers/gpu/drm/i915/display/intel_lvds.c:922:
+ connector->base.display_info.subpixel_order = SubPixelHorizontalRGB;
total: 0 errors, 0 warnings, 1 checks, 252 lines checked 0fc60b0c377c drm/i915/lvds: s/pipe_config/crtc_state/
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: LVDS cleanup
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: LVDS cleanup
URL : https://patchwork.freedesktop.org/series/113503/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12667 -> Patchwork_113503v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/index.html
Participating hosts (26 -> 24)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113503v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rpls-1}: [ABORT][3] ([i915#6311] / [i915#7359]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/bat-rpls-1/igt@gem_exec_suspend@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
Build changes
-------------
* Linux: CI_DRM_12667 -> Patchwork_113503v1
CI-20190529: 20190529
CI_DRM_12667: c30c24a1b2ef039980198dcfd7c3328fd61f404d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113503v1: c30c24a1b2ef039980198dcfd7c3328fd61f404d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
4d6e9b1c9ffd drm/i915/lvds: s/pipe_config/crtc_state/ 06b70b12d475 drm/i915/lvds: s/intel_encoder/encoder/ etc. 945379acd2bd drm/i915/lvds: s/dev_priv/i915/ dd41c76e79f2 drm/i915/lvds: Fix whitespace 18e49ae44b43 drm/i915/lvds: Extract intel_lvds_regs.h f6bdf12601e4 drm/i915/lvds: Use REG_BIT() & co. 41af5c474557 drm/i915/lvds: Use intel_de_rmw() 5e304bbb6a58 drm/i915/lvds: Split long lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: LVDS cleanup
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: LVDS cleanup
URL : https://patchwork.freedesktop.org/series/113503/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12667_full -> Patchwork_113503v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_113503v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_113503v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/index.html
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-tglu-9
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113503v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-glk: [PASS][1] -> [TIMEOUT][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113503v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@perf@enable-disable:
- shard-glk: [PASS][3] -> [TIMEOUT][4] ([i915#6943])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk2/igt@[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][5] ([i915#7742]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-4/igt@drm_fdinfo@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-2/igt@drm_fdinfo@[email protected]
* igt@drm_read@empty-nonblock:
- {shard-tglu}: [SKIP][7] ([i915#1845] / [i915#7651]) -> [PASS][8] +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-1/igt@[email protected]
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][9] ([i915#2582]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][11] ([i915#658]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
* igt@gem_bad_reloc@negative-reloc:
- {shard-rkl}: [SKIP][13] ([i915#3281]) -> [PASS][14] +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-5/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][15] ([i915#2842]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk9/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][17] ([i915#2842]) -> [PASS][18] +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-3/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-5/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@batch-zero-length:
- {shard-rkl}: [SKIP][19] ([i915#2527]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@cursor-dpms:
- {shard-tglu}: [SKIP][21] ([i915#1849]) -> [PASS][22] +9 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-4/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-rkl}: [SKIP][23] ([i915#1397]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
- {shard-dg1}: [SKIP][25] ([i915#1397]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-dg1-18/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-dg1-14/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-tglu}: [SKIP][27] ([i915#1397]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-1/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][29] ([i915#2346]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk7/igt@kms_cursor_legacy@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk8/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-glk: [DMESG-WARN][31] ([i915#118]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk1/igt@kms_cursor_legacy@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk8/igt@kms_cursor_legacy@[email protected]
* igt@kms_draw_crc@fill-fb:
- {shard-tglu}: [SKIP][33] ([i915#1845]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-1/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1:
- shard-glk: [FAIL][35] ([i915#2122]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-glk4/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-glk5/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][37] ([i915#1849] / [i915#4098]) -> [PASS][38] +18 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-position-covered@pipe-a-planes:
- {shard-rkl}: [SKIP][39] ([i915#1849]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@kms_plane@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-tglu}: [SKIP][41] ([i915#1849] / [i915#3558]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@kms_plane@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-4/igt@kms_plane@[email protected]
* igt@kms_psr@primary_render:
- {shard-rkl}: [SKIP][43] ([i915#1072]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-3/igt@kms_psr@primary_render.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@kms_psr@primary_render.html
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- {shard-rkl}: [SKIP][45] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-a-query-forked:
- {shard-tglu}: [SKIP][47] ([i915#7651]) -> [PASS][48] +18 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-tglu-6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-tglu-4/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-idle:
- {shard-rkl}: [SKIP][49] ([i915#1845] / [i915#4098]) -> [PASS][50] +28 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12667/shard-rkl-1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/shard-rkl-6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6943]: https://gitlab.freedesktop.org/drm/intel/issues/6943
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
Build changes
-------------
* Linux: CI_DRM_12667 -> Patchwork_113503v1
CI-20190529: 20190529
CI_DRM_12667: c30c24a1b2ef039980198dcfd7c3328fd61f404d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113503v1: c30c24a1b2ef039980198dcfd7c3328fd61f404d @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113503v1/index.html
Quoted 3 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Some cleanup/modernization of the LVDS code.
Please spell check the commit messages, otherwise the series is
Quoted 21 lines
Ville Syrjälä (8):
drm/i915/lvds: Split long lines
drm/i915/lvds: Useintel_de_rmw()
drm/i915/lvds: UseREG_BIT()& co.
drm/i915/lvds: Extractintel_lvds_regs.h
drm/i915/lvds: Fix whitespace
drm/i915/lvds: s/dev_priv/i915/
drm/i915/lvds: s/intel_encoder/encoder/ etc.
drm/i915/lvds: s/pipe_config/crtc_state/drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_lvds.c | 332 +++++++++--------- .../gpu/drm/i915/display/intel_lvds_regs.h | 65 ++++ drivers/gpu/drm/i915/display/intel_panel.c | 1 + .../gpu/drm/i915/display/intel_pch_display.c | 1 + drivers/gpu/drm/i915/display/intel_pps.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 56 --- drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 + 8 files changed, 232 insertions(+), 226 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_lvds_regs.h
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center