Skip to contentSkip to conversation

block: Fix the blk_mq_destroy_queue() documentation

PATCH Applied Bart Van Assche 3 participants 3 messages Jan 30, 2023 – Jan 31, 2023 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Fix the blk_mq_destroy_queue() documentation

Commit 2b3f056f72e5 moved a blk_put_queue() call from blk_mq_destroy_queue() into its callers. Reflect this change in the documentation block above blk_mq_destroy_queue().

Cc Christoph Hellwig <[email protected]>
Cc Sagi Grimberg <[email protected]>
Cc Chaitanya Kulkarni <[email protected]>
Cc Keith Busch <[email protected]>
Fixes 2b3f056f72e5 ("blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue")
---
 block/blk-mq.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
block/blk-mq.c +3 -2
index 9d463f7563bc..9c8dc70020bc 100644
@@ -4069,8 +4069,9 @@ EXPORT_SYMBOL(blk_mq_init_queue);
  * blk_mq_destroy_queue - shutdown a request queue
  * @q: request queue to shutdown
  *
- * This shuts down a request queue allocated by blk_mq_init_queue() and drops
- * the initial reference.  All future requests will failed with -ENODEV.
+ * This shuts down a request queue allocated by blk_mq_init_queue(). All future
+ * requests will be failed with -ENODEV. The caller is responsible for dropping
+ * the reference from blk_mq_init_queue() by calling blk_put_queue().
  *
  * Context: can sleep
  */
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Bart Van Assche

Commit 2b3f056f72e5 moved a blk_put_queue() call from blk_mq_destroy_queue() into its callers. Reflect this change in the documentation block above blk_mq_destroy_queue().

Looks good:

maintainer Applied
#2 lore raw
In reply to Bart Van Assche
Quoted 5 lines · Bart Van Assche

Commit 2b3f056f72e5 moved a blk_put_queue() call from blk_mq_destroy_queue() into its callers. Reflect this change in the documentation block above blk_mq_destroy_queue().

Applied, thanks!

[1/1] block: Fix the blk_mq_destroy_queue() documentation

      commit: 81ea42b9c3d61ea34d82d900ed93f4b4851f13b0

Best regards,

Signature · 1 line
Jens Axboe