Skip to contentSkip to conversation

dts: imx8mp-rsb3720: modify configrations to load fip into memory

PATCH In review Ying-Chun Liu (PaulLiu) 3 participants 7 messages Jan 17, 2023 – Jan 31, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover dts: imx8mp-rsb3720: modify configrations to load fip into memory

The changes of commit 6a21c695213b ("arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi") breaks the loading of the fip. This commit fixes the break by modify the configuration properly.

v2: just rebase to the latest master branch.
v3: rebase to the latest master branch.
v4: fix subject and commit log: node name -> label

Ying-Chun Liu (PaulLiu) (2):
dts: imx8mp: assign binman_configuration label to config-SEQ
dts: imx8mp-rsb3720: modify configrations to load fip into memory

 arch/arm/dts/imx8mp-rsb3720-a1-u-boot.dtsi | 10 ++++------
 arch/arm/dts/imx8mp-u-boot.dtsi            |  2 +-
 2 files changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.0
#1 lore raw

PATCH v4 1/2 dts: imx8mp: assign binman_configuration label to config-SEQ

assign a label for config-SEQ so that the board dts can modify the configuration more easily.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>

---
v2: just rebase to the latest master branch.
v3: rebase to the latest master branch.
v4: fix subject and commit log: node name -> label

---
 arch/arm/dts/imx8mp-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx8mp-u-boot.dtsi +1 -1
index f9883aa133..cb9b5b649a 100644
@@ -148,7 +148,7 @@
 			configurations {
 				default = "@config-DEFAULT-SEQ";
 
-				@config-SEQ {
+				binman_configuration: @config-SEQ {
 					description = "NAME";
 					fdt = "fdt-SEQ";
 					firmware = "uboot";
Signature · 1 line
2.39.0
reviewer Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] dts: imx8mp: assign binman_configuration label to config-SEQ

Quoted 8 lines · Ying-Chun Liu (PaulLiu)

assign a label for config-SEQ so that the board dts can modify the configuration more easily.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>
#3 lore raw

PATCH v4 1/2 dts: imx8mp: assign binman_configuration label to config-SEQ

In reply to Ying-Chun Liu (PaulLiu)
Quoted 7 lines

assign a label for config-SEQ so that the board dts can modify the configuration more easily.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#4 lore raw

PATCH v4 2/2 dts: imx8mp-rsb3720: modify configrations to load fip into memory

In reply to Ying-Chun Liu (PaulLiu)

The changes of commit 6a21c695213b ("arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi") breaks the loading of the fip. This commit fixes the break by modify the configuration properly.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>

---
v2: just rebase to the latest master branch.
v3: rebase to the latest master branch.

---
 arch/arm/dts/imx8mp-rsb3720-a1-u-boot.dtsi | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
arch/arm/dts/imx8mp-rsb3720-a1-u-boot.dtsi +4 -6
index 4419967ee4..32d9fbc886 100644
@@ -158,12 +158,10 @@
 					};
 				};
 			};
-
-			configurations {
-				conf {
-					loadables = "atf", "fip";
-				};
-			};
 		};
 	};
 };
+
+&binman_configuration {
+	loadables = "atf", "fip";
+};
Signature · 1 line
2.39.0
reviewer Reviewed-by on v4 2/2
#5 lore raw
Quoted 9 lines · Ying-Chun Liu (PaulLiu)

The changes of commit 6a21c695213b ("arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi") breaks the loading of the fip. This commit fixes the break by modify the configuration properly.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>
#6 lore raw

PATCH v4 2/2 dts: imx8mp-rsb3720: modify configrations to load fip into memory

In reply to Ying-Chun Liu (PaulLiu)
Quoted 8 lines

The changes of commit 6a21c695213b ("arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi") breaks the loading of the fip. This commit fixes the break by modify the configuration properly.

Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP i.MX U-Boot Team <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================