Skip to contentSkip to conversation

MAC address falls to permanent

PATCH In review Vlao Mao 2 participants 4 messages Jan 31, 2023

lore
Share & tools
lore

Vlao Mao

author
#0 lore raw

cover MAC address falls to permanent

A bug was found with the vmxnet3 driver, after changing the MAC address and rebooting, it falls into the category of a permanent address until the VM is turned off. Here is log output:

-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1

    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
    link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff

-bash-4.4# ip link set dev ens3 address 33:33:33:33:33:33 -bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1

    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
    link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff

-bash-4.4# ethtool -P ens3
Permanent address: 52:54:00:12:34:56
-bash-4.4# reboot

//rebooting

-bash-4.4# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1

    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
default qlen 1000
    link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff

-bash-4.4# ethtool -P ens3
Permanent address: 33:33:33:33:33:33
-bash-4.4#

Vlao Mao (1):
vmxnet3: add mac address restore upon reset

 hw/net/vmxnet3.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.35.1
author
#1 lore raw

PATCH 1/1 vmxnet3: add mac address restore upon reset

From: VlaoMao <[email protected]>

Changing the address with a subsequent reboot makes this address permanent until the vm is turned off

---
 hw/net/vmxnet3.c | 2 ++
 1 file changed, 2 insertions(+)
hw/net/vmxnet3.c +2 -0
index 04159c8222..695ca2f923 100644
@@ -1206,6 +1206,8 @@ static void vmxnet3_reset(VMXNET3State *s)
     s->drv_shmem = 0;
     s->tx_sop = true;
     s->skip_current_tx_pkt = false;
+
+    vmxnet3_reset_mac(s);
 }
 
 static void vmxnet3_update_rx_mode(VMXNET3State *s)
Signature · 1 line
2.35.1
#2 lore raw
In reply to Vlao Mao
Quoted 4 lines · Vlao Mao

A bug was found with the vmxnet3 driver, after changing the MAC address and rebooting, it falls into the category of a permanent address until the VM is turned off.

For some network device models (those where the hardware has an EEPROM and we're modelling "guest programmed a new MAC address into the EEPROM") that is the correct behaviour. Is the vmxnet3 definitely one of the kind which is not supposed to have a permanent MAC address backing storage ? (It's paravirtual, so this would hopefully be indicated in the specs for it.)

thanks
-- PMM

#3 lore raw

I cannot say for sure, but e1000 does not have this behavior, vmxnet3 in vmware also does not behave this way.
In addition, the address gets there only after a reboot, it does not get there during normal operation, as you can see from logs i attached. It seems to me that this is not quite the expected behavior, isn't it?

вт, 31 янв. 2023 г. в 21:48, Peter Maydell <[email protected]>:

Quoted 16 lines · Vlao Mao
Quoted 4 lines

A bug was found with the vmxnet3 driver, after changing the MAC address and rebooting, it falls into the category of a permanent address until the VM is turned off.

For some network device models (those where the hardware has an EEPROM and we're modelling "guest programmed a new MAC address into the EEPROM") that is the correct behaviour. Is the vmxnet3 definitely one of the kind which is not supposed to have a permanent MAC address backing storage ? (It's paravirtual, so this would hopefully be indicated in the specs for it.)

thanks
-- PMM