Skip to contentSkip to conversation

imx8mq_pins: fix configuration for UART4 on ECSPI2 pads

PATCH In review Arnaud Ferraris 3 participants 3 messages Dec 15, 2022 – Jan 31, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx8mq_pins: fix configuration for UART4 on ECSPI2 pads

When routing UART4 using the ECSPI2 pads, register IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only when dealing with RX, as its name suggests.

---
 arch/arm/include/asm/arch-imx8m/imx8mq_pins.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-imx8m/imx8mq_pins.h +1 -1
index c71913f209..16d418c687 100644
@@ -538,7 +538,7 @@ enum {
 		IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10                  = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0),
 
 		IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI                 = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0),
-		IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX                    = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0),
+		IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX                    = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0),
 		IMX8MQ_PAD_ECSPI2_MOSI__GPIO5_IO11                  = IOMUX_PAD(0x0470, 0x0208, 5, 0x0000, 0, 0),
 
 		IMX8MQ_PAD_ECSPI2_MISO__ECSPI2_MISO                 = IOMUX_PAD(0x0474, 0x020C, 0, 0x0000, 0, 0),
Signature · 1 line
2.35.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

arch/arm/include/asm/arch-imx8m/imx8mq_pins.h enum { · line 541

Quoted 10 lines · Arnaud Ferraris
arch/arm/include/asm/arch-imx8m/imx8mq_pins.h +1 -1
index c71913f209..16d418c687 100644
@@ -538,7 +538,7 @@ enum {
                IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10                  = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0),
 
                IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI                 = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0),
-               IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX                    = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0),
+               IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX                    = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0),

Yes, the DT definition does the same:

#define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DCE_TX
     0x208 0x470 0x000 0x1 0x0
#define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DTE_RX
     0x208 0x470 0x50C 0x1 0x1
#2 lore raw

PATCH 1/1 imx8mq_pins: fix configuration for UART4 on ECSPI2 pads

In reply to Arnaud Ferraris
Quoted 5 lines

When routing UART4 using the ECSPI2 pads, register IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only when dealing with RX, as its name suggests.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================