Skip to contentSkip to conversation

kasan: use %zd format for printing size_t

PATCH In review Arnd Bergmann 3 participants 3 messages Feb 1, 2023 – Feb 9, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kasan: use %zd format for printing size_t

From: Arnd Bergmann <[email protected]>

The size_t type depends on the architecture, so %lu does not work on most 32-bit ones:

In file included from include/kunit/assert.h:13,

                 from include/kunit/test.h:12,
                 from mm/kasan/report.c:12:
mm/kasan/report.c: In function 'describe_object_addr':
include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
mm/kasan/report.c:270:9: note: in expansion of macro 'pr_err'
  270 |         pr_err("The buggy address is located %d bytes %s of\n"
      |         ^~~~~~
Fixes 0e301731f558 ("kasan: infer allocation size by scanning metadata")
---
 mm/kasan/report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/kasan/report.c +1 -1
index e0492124e90a..89078f912827 100644
@@ -268,7 +268,7 @@ static void describe_object_addr(const void *addr, struct kasan_report_info *inf
 	}
 
 	pr_err("The buggy address is located %d bytes %s of\n"
-	       " %s%lu-byte region [%px, %px)\n",
+	       " %s%zu-byte region [%px, %px)\n",
 	       rel_bytes, rel_type, region_state, info->alloc_size,
 	       (void *)object_addr, (void *)(object_addr + info->alloc_size));
 }
Signature · 1 line
2.39.0
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 14 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The size_t type depends on the architecture, so %lu does not work on most 32-bit ones:

In file included from include/kunit/assert.h:13,

                 from include/kunit/test.h:12,
                 from mm/kasan/report.c:12:
mm/kasan/report.c: In function 'describe_object_addr':
include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
mm/kasan/report.c:270:9: note: in expansion of macro 'pr_err'
  270 |         pr_err("The buggy address is located %d bytes %s of\n"
      |         ^~~~~~
Quoted 2 lines
Fixes 0e301731f558 ("kasan: infer allocation size by scanning metadata")

Thanks.

Quoted 17 lines
---
 mm/kasan/report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/kasan/report.c +1 -1
index e0492124e90a..89078f912827 100644
@@ -268,7 +268,7 @@ static void describe_object_addr(const void *addr, struct kasan_report_info *inf
 	}
 
 	pr_err("The buggy address is located %d bytes %s of\n"
-	       " %s%lu-byte region [%px, %px)\n",
+	       " %s%zu-byte region [%px, %px)\n",
 	       rel_bytes, rel_type, region_state, info->alloc_size,
 	       (void *)object_addr, (void *)(object_addr + info->alloc_size));
 }
Signature · 1 line
~Randy
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 35 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The size_t type depends on the architecture, so %lu does not work on most 32-bit ones:

In file included from include/kunit/assert.h:13,

                 from include/kunit/test.h:12,
                 from mm/kasan/report.c:12:
mm/kasan/report.c: In function 'describe_object_addr':
include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
mm/kasan/report.c:270:9: note: in expansion of macro 'pr_err'
  270 |         pr_err("The buggy address is located %d bytes %s of\n"
      |         ^~~~~~
Fixes 0e301731f558 ("kasan: infer allocation size by scanning metadata")
---
 mm/kasan/report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/kasan/report.c +1 -2
index e0492124e90a..89078f912827 100644
@@ -268,7 +268,7 @@ static void describe_object_addr(const void *addr, struct kasan_report_info *inf
        }
 
        pr_err("The buggy address is located %d bytes %s of\n"
-              " %s%lu-byte region [%px, %px)\n",
+              " %s%zu-byte region [%px, %px)\n",
               rel_bytes, rel_type, region_state, info->alloc_size,
               (void *)object_addr, (void *)(object_addr + info->alloc_size));
 }
--
Quoted 2 lines

2.39.0

Thanks!