Skip to contentSkip to conversation

pinctrl: qcom: add dt-bindings and driver for sa8775p-tlmm

PATCH In review Bartosz Golaszewski 3 participants 10 messages Feb 1, 2023 – Feb 2, 2023

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

v3 cover pinctrl: qcom: add dt-bindings and driver for sa8775p-tlmm

From: Bartosz Golaszewski <[email protected]>

This series contains the device-tree bindings and the pinctrl driver for the SA8775P platforms.

v2 -> v3 (Changes in DT bindings only)
- fix the gpio pattern property (platform has 148 GPIOs)
- add blank lines for better readability

v1 -> v2:
- squash several functions into bigger groups
- fixed the emacX_ptp functions (they were generated automatically and the script made two separate functions into one)
- fixed the compatible and DT bindings examples
- added missing DT properties
- made sure the bindings pass tests
- coding style fixes in the driver

Bartosz Golaszewski (1):
dt-bindings: pinctrl: describe sa8775p-tlmm

Yadu MG (1):
pinctrl: qcom: add the tlmm driver sa8775p platforms

 .../bindings/pinctrl/qcom,sa8775p-tlmm.yaml   |  138 ++
 drivers/pinctrl/qcom/Kconfig                  |    9 +
 drivers/pinctrl/qcom/Makefile                 |    1 +
 drivers/pinctrl/qcom/pinctrl-sa8775p.c        | 1537 +++++++++++++++++
 4 files changed, 1685 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sa8775p.c
Signature · 1 line
2.37.2
#1 lore raw

PATCH v3 1/2 dt-bindings: pinctrl: describe sa8775p-tlmm

From: Bartosz Golaszewski <[email protected]>

Add DT bindings for the TLMM controller on sa8775p platforms.

---
 .../bindings/pinctrl/qcom,sa8775p-tlmm.yaml   | 138 ++++++++++++++++++
 1 file changed, 138 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +138 -0
new file mode 100644
index 000000000000..a91f5816ed5e
@@ -0,0 +1,138 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,sa8775p-tlmm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. SA8775P TLMM block
+
+maintainers:
+  - Bartosz Golaszewski <[email protected]>
+
+description: |
+  Top Level Mode Multiplexer pin controller in Qualcomm SA8775P SoC.
+
+allOf:
+  - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
+
+properties:
+  compatible:
+    const: qcom,sa8775p-tlmm
+
+  reg:
+    maxItems: 1
+
+  interrupts: true
+  interrupt-controller: true
+  "#interrupt-cells": true
+  gpio-controller: true
+  "#gpio-cells": true
+  gpio-ranges: true
+
+  gpio-reserved-ranges:
+    minItems: 1
+    maxItems: 74
+
+  gpio-line-names:
+    maxItems: 148
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+patternProperties:
+  "-state$":
+    oneOf:
+      - $ref: "#/$defs/qcom-sa8775p-tlmm-state"
+      - patternProperties:
+          "-pins$":
+            $ref: "#/$defs/qcom-sa8775p-tlmm-state"
+        additionalProperties: false
+
+$defs:
+  qcom-sa8775p-tlmm-state:
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.
+    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
+
+    properties:
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        items:
+          oneOf:
+            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-3][0-9]|14[0-7])$"
+            - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc1_rclk, ufs_reset ]
+        minItems: 1
+        maxItems: 16
+
+      function:
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+
+        enum: [ atest_char, atest_usb2, audio_ref, cam_mclk, cci_async, cci_i2c,
+                cci_timer0, cci_timer1, cci_timer2, cci_timer3, cci_timer4,
+                cci_timer5, cci_timer6, cci_timer7, cci_timer8, cci_timer9,
+                cri_trng, cri_trng0, cri_trng1, dbg_out, ddr_bist, ddr_pxi0,
+                ddr_pxi1, ddr_pxi2, ddr_pxi3, ddr_pxi4, ddr_pxi5, edp0_hot,
+                edp0_lcd, edp1_hot, edp1_lcd, edp2_hot, edp2_lcd, edp3_hot,
+                edp3_lcd, emac0_mcg0, emac0_mcg1, emac0_mcg2, emac0_mcg3,
+                emac0_mdc, emac0_mdio, emac0_ptp_aux, emac0_ptp_pps, emac1_mcg0,
+                emac1_mcg1, emac1_mcg2, emac1_mcg3, emac1_mdc, emac1_mdio,
+                emac1_ptp_aux, emac1_ptp_pps, gcc_gp1, gcc_gp2, gcc_gp3,
+                gcc_gp4, gcc_gp5, hs0_mi2s, hs1_mi2s, hs2_mi2s, ibi_i3c,
+                jitter_bist, mdp0_vsync0, mdp0_vsync1, mdp0_vsync2, mdp0_vsync3,
+                mdp0_vsync4, mdp0_vsync5, mdp0_vsync6, mdp0_vsync7, mdp0_vsync8,
+                mdp1_vsync0, mdp1_vsync1, mdp1_vsync2, mdp1_vsync3, mdp1_vsync4,
+                mdp1_vsync5, mdp1_vsync6, mdp1_vsync7, mdp1_vsync8, mdp_vsync,
+                mi2s1_data0, mi2s1_data1, mi2s1_sck, mi2s1_ws, mi2s2_data0,
+                mi2s2_data1, mi2s2_sck, mi2s2_ws, mi2s_mclk0, mi2s_mclk1,
+                pcie0_clkreq, pcie1_clkreq, phase_flag, pll_bist, pll_clk,
+                prng_rosc0, prng_rosc1, prng_rosc2, prng_rosc3, qdss_cti,
+                qdss_gpio, qup0_se0, qup0_se1, qup0_se2, qup0_se3, qup0_se4,
+                qup0_se5, qup1_se0, qup1_se1, qup1_se2, qup1_se3, qup1_se4,
+                qup1_se5, qup1_se6, qup2_se0, qup2_se1, qup2_se2, qup2_se3,
+                qup2_se4, qup2_se5, qup2_se6, qup3_se0, sailss_emac0,
+                sailss_ospi, sail_top, sgmii_phy, tb_trig, tgu_ch0, tgu_ch1,
+                tgu_ch2, tgu_ch3, tgu_ch4, tgu_ch5, tsense_pwm1, tsense_pwm2,
+                tsense_pwm3, tsense_pwm4, usb2phy_ac, vsense_trigger ]
+
+      bias-disable: true
+      bias-pull-down: true
+      bias-pull-up: true
+      drive-strength: true
+      input-enable: true
+      output-high: true
+      output-low: true
+
+    required:
+      - pins
+
+    additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    tlmm: pinctrl@f000000 {
+        compatible = "qcom,sa8775p-tlmm";
+        reg = <0xf000000 0x1000000>;
+        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        gpio-ranges = <&tlmm 0 0 149>;
+
+        qup-uart10-state {
+            pins = "gpio46", "gpio47";
+            function = "qup1_se3";
+        };
+    };
+...
Signature · 1 line
2.37.2
Reviewed-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm

Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add DT bindings for the TLMM controller on sa8775p platforms.

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +4 -0
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml line 131

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +10 -0
+
+    tlmm: pinctrl@f000000 {
+        compatible = "qcom,sa8775p-tlmm";
+        reg = <0xf000000 0x1000000>;
+        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        gpio-ranges = <&tlmm 0 0 149>;

You have 148 GPIOs, so s/149/148/.

I'll fix other bindings as we have such mistake in several places.

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm

Quoted 26 lines · Krzysztof Kozlowski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add DT bindings for the TLMM controller on sa8775p platforms.

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +4 -0
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml line 131

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +10 -0
+
+    tlmm: pinctrl@f000000 {
+        compatible = "qcom,sa8775p-tlmm";
+        reg = <0xf000000 0x1000000>;
+        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        gpio-ranges = <&tlmm 0 0 149>;

You have 148 GPIOs, so s/149/148/.

Quoted 8 lines

I'll fix other bindings as we have such mistake in several places.

Best regards,
Krzysztof

Ah, cr*p, sorry for missing it. Linus - can you change it when applying? I don't want to send more noise.

Bart

#4 lore raw

Re: [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm

Quoted 31 lines · Bartosz Golaszewski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add DT bindings for the TLMM controller on sa8775p platforms.

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +4 -0
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>

Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml line 131

Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml new file +10 -0
+
+    tlmm: pinctrl@f000000 {
+        compatible = "qcom,sa8775p-tlmm";
+        reg = <0xf000000 0x1000000>;
+        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        gpio-ranges = <&tlmm 0 0 149>;

You have 148 GPIOs, so s/149/148/.

I'll fix other bindings as we have such mistake in several places.

Quoted 8 lines
Quoted 5 lines

Best regards,
Krzysztof

Ah, cr*p, sorry for missing it. Linus - can you change it when applying? I don't want to send more noise.

Of course :)

Yours,
Linus Walleij

#5 lore raw

PATCH v3 2/2 pinctrl: qcom: add the tlmm driver sa8775p platforms

In reply to Bartosz Golaszewski

From: Yadu MG <[email protected]>

Add support for Lemans TLMM configuration and control via the pinctrl framework.

---
 drivers/pinctrl/qcom/Kconfig           |    9 +
 drivers/pinctrl/qcom/Makefile          |    1 +
 drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1537 ++++++++++++++++++++++++
 3 files changed, 1547 insertions(+)
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sa8775p.c
drivers/pinctrl/qcom/Kconfig +9 -0
index 2a517775a61e..8d4f871e07cf 100644
@@ -258,6 +258,15 @@ config PINCTRL_QDU1000
 	  Qualcomm Technologies Inc TLMM block found on the Qualcomm
 	  Technologies Inc QDU1000 and QRU1000 platforms.
 
+config PINCTRL_SA8775P
+	tristate "Qualcomm Technologies Inc SA8775P pin controller driver"
+	depends on OF
+	depends on ARM64 || COMPILE_TEST
+	depends on PINCTRL_MSM
+	help
+	  This is the pinctrl, pinmux and pinconf driver for the Qualcomm
+	  TLMM block found on the Qualcomm SA8775P platforms.
+
 config PINCTRL_SC7180
 	tristate "Qualcomm Technologies Inc SC7180 pin controller driver"
 	depends on OF
drivers/pinctrl/qcom/Makefile +1 -0
index 952f784d0888..6763aa8d319c 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
 obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
 obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
 obj-$(CONFIG_PINCTRL_QDU1000)	+= pinctrl-qdu1000.o
+obj-$(CONFIG_PINCTRL_SA8775P)	+= pinctrl-sa8775p.o
 obj-$(CONFIG_PINCTRL_SC7180)	+= pinctrl-sc7180.o
 obj-$(CONFIG_PINCTRL_SC7280)	+= pinctrl-sc7280.o
 obj-$(CONFIG_PINCTRL_SC7280_LPASS_LPI) += pinctrl-sc7280-lpass-lpi.o
drivers/pinctrl/qcom/pinctrl-sa8775p.c new file +1537 -0

1,537 lines not on this page · raw message

Signature · 1 line
2.37.2
#6 lore raw
In reply to Bartosz Golaszewski
Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series contains the device-tree bindings and the pinctrl driver for the SA8775P platforms.

v2 -> v3 (Changes in DT bindings only)
- fix the gpio pattern property (platform has 148 GPIOs)
- add blank lines for better readability

v3 patch set applied, fixing the 149->148 number in the example in patch 1!

Yours,
Linus Walleij

#7 lore raw
Quoted 8 lines · Linus Walleij
Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series contains the device-tree bindings and the pinctrl driver for the SA8775P platforms.

Quoted 7 lines
Quoted 3 lines

v2 -> v3 (Changes in DT bindings only)
- fix the gpio pattern property (platform has 148 GPIOs)
- add blank lines for better readability

v3 patch set applied, fixing the 149->148 number in the example in patch 1!

Thanks! Seems like only patch 1/2 got into your branch?

Bart

#8 lore raw
Quoted 13 lines · Bartosz Golaszewski
Quoted 12 lines · Linus Walleij
Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series contains the device-tree bindings and the pinctrl driver for the SA8775P platforms.

v2 -> v3 (Changes in DT bindings only)
- fix the gpio pattern property (platform has 148 GPIOs)
- add blank lines for better readability

Quoted 5 lines
Quoted 3 lines

v3 patch set applied, fixing the 149->148 number in the example in patch 1!

Thanks! Seems like only patch 1/2 got into your branch?

That's confusing, it looks to me like they are both there?
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Isn't "pinctrl: qcom: add the tlmm driver sa8775p platforms" patch 2/2?

Yours,
Linus Walleij

#9 lore raw
Quoted 19 lines · Linus Walleij
Quoted 17 lines · Bartosz Golaszewski
Quoted 15 lines · Linus Walleij
Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series contains the device-tree bindings and the pinctrl driver for the SA8775P platforms.

v2 -> v3 (Changes in DT bindings only)
- fix the gpio pattern property (platform has 148 GPIOs)
- add blank lines for better readability

v3 patch set applied, fixing the 149->148 number in the example in patch 1!

Quoted 7 lines
Quoted 1 line

Thanks! Seems like only patch 1/2 got into your branch?

That's confusing, it looks to me like they are both there?
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Isn't "pinctrl: qcom: add the tlmm driver sa8775p platforms" patch 2/2?

Strange, didn't see it there before. Anyway, thanks a lot!

Bart