Skip to contentSkip to conversation

misc: vmw_balloon: fix memory leak with using debugfs_lookup()

PATCH New Greg Kroah-Hartman 1 participant 1 message Feb 2, 2023

Subsystems (2)
Char and misc drivers VMware balloon driver
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 misc: vmw_balloon: fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once.

Cc Nadav Amit <[email protected]>
Cc VMware PV-Drivers Reviewers <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc [email protected]
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 drivers/misc/vmw_balloon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_balloon.c +1 -1
index 61a2be712bf7..9ce9b9e0e9b6 100644
@@ -1709,7 +1709,7 @@ static void __init vmballoon_debugfs_init(struct vmballoon *b)
 static void __exit vmballoon_debugfs_exit(struct vmballoon *b)
 {
 	static_key_disable(&balloon_stat_enabled.key);
-	debugfs_remove(debugfs_lookup("vmmemctl", NULL));
+	debugfs_lookup_and_remove("vmmemctl", NULL);
 	kfree(b->stats);
 	b->stats = NULL;
 }
Signature · 1 line
2.39.1