Skip to contentSkip to conversation

HID: logitech: Disable hi-res scrolling on USB

PATCH Applied Bastien Nocera 2 participants 2 messages Feb 3, 2023 – Feb 6, 2023

Subsystems (4)
lore
Share & tools
lore

Bastien Nocera

author reviewer
#0 lore raw

PATCH 1/1 HID: logitech: Disable hi-res scrolling on USB

On some Logitech mice, such as the G903, and possibly the G403, the HID events are generated on a different interface to the HID++ one.

If we enable hi-res through the HID++ interface, the HID interface wouldn't know anything about it, and handle the events as if they were regular scroll events, making the mouse unusable.

Disable hi-res scrolling on those devices until we implement scroll events through HID++.

Fixes 908d325e1665 ("HID: logitech-hidpp: Detect hi-res scrolling support")
---
 drivers/hid/hid-logitech-hidpp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hid/hid-logitech-hidpp.c +2 -1
index abf2c95e4d0b..9c1ee8e91e0c 100644
@@ -3978,7 +3978,8 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
 	}
 
 	hidpp_initialize_battery(hidpp);
-	hidpp_initialize_hires_scroll(hidpp);
+	if (!hid_is_usb(hidpp->hid_dev))
+		hidpp_initialize_hires_scroll(hidpp);
 
 	/* forward current battery state */
 	if (hidpp->capabilities & HIDPP_CAPABILITY_HIDPP10_BATTERY) {
Signature · 1 line
2.39.1
#1 lore raw
Quoted 8 lines · Bastien Nocera

On some Logitech mice, such as the G903, and possibly the G403, the HID events are generated on a different interface to the HID++ one.

If we enable hi-res through the HID++ interface, the HID interface wouldn't know anything about it, and handle the events as if they were regular scroll events, making the mouse unusable.

[...]

Applied to hid/hid.git (for-6.2/upstream-fixes), thanks!

[1/1] HID: logitech: Disable hi-res scrolling on USB

      https://git.kernel.org/hid/hid/c/690eb7dec72a

Cheers,

Signature · 1 line
Benjamin Tissoires <[email protected]>