cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
Subsystems (2)
PATCH v2 1/1 cpuidle: add ARCH_SUSPEND_POSSIBLE dependencies
From: Arnd Bergmann <[email protected]>
Some ARMv4 processors don't support suspend, which leads to a build failure with the tegra and qualcomm cpuidle driver:
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
Selected by [y]:
- ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference to cpu_sa110_suspend_size' (.text+0x68): undefined reference to cpu_fa526_suspend_size'
Add an explicit dependency to make randconfig builds avoid this combination.
---
I found this in my backlog of patches that never made it upstream, testing shows this is still needed. Please apply.
--- drivers/cpuidle/Kconfig.arm | 2 ++ 1 file changed, 2 insertions(+)
drivers/cpuidle/Kconfig.arm +2 -0
@@ -102,6 +102,7 @@ config ARM_MVEBU_V7_CPUIDLE config ARM_TEGRA_CPUIDLE bool "CPU Idle Driver for NVIDIA Tegra SoCs" depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU + depends on ARCH_SUSPEND_POSSIBLE select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND help
@@ -110,6 +111,7 @@ config ARM_TEGRA_CPUIDLE config ARM_QCOM_SPM_CPUIDLE bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)" depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU + depends on ARCH_SUSPEND_POSSIBLE select ARM_CPU_SUSPEND select CPU_IDLE_MULTIPLE_DRIVERS select DT_IDLE_STATES
Signature · 1 line
2.39.0
Quoted 24 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Some ARMv4 processors don't support suspend, which leads to a build failure with the tegra and qualcomm cpuidle driver:
WARNING: unmet direct dependencies detected for
ARM_CPU_SUSPEND
Depends on [n]:ARCH_SUSPEND_POSSIBLE[=n]
Selected by [y]:
-ARM_TEGRA_CPUIDLE[=y] &&CPU_IDLE[=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA[=n] ||COMPILE_TEST[=y]) && !ARM64 && MMU [=y]
arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference tocpu_sa110_suspend_size' (.text+0x68): undefined reference tocpu_fa526_suspend_size'Add an explicit dependency to make randconfig builds avoid this combination.
Fixes faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")Fixes a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")Cc Randy Dunlap <[email protected]>Reviewed-by Dmitry Osipenko <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
Quoted 6 lines
---
I found this in my backlog of patches that never made it upstream, testing shows this is still needed. Please apply.--- drivers/cpuidle/Kconfig.arm | 2 ++ 1 file changed, 2 insertions(+)
Quoted 33 lines · Thierry Reding
Quoted 24 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Some ARMv4 processors don't support suspend, which leads to a build failure with the tegra and qualcomm cpuidle driver:
WARNING: unmet direct dependencies detected for
ARM_CPU_SUSPEND
Depends on [n]:ARCH_SUSPEND_POSSIBLE[=n]
Selected by [y]:
-ARM_TEGRA_CPUIDLE[=y] &&CPU_IDLE[=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA[=n] ||COMPILE_TEST[=y]) && !ARM64 && MMU [=y]
arch/arm/kernel/sleep.o: in function `__cpu_suspend':
(.text+0x68): undefined reference tocpu_sa110_suspend_size' (.text+0x68): undefined reference tocpu_fa526_suspend_size'Add an explicit dependency to make randconfig builds avoid this combination.
Fixes faae6c9f2e68 ("cpuidle: tegra: Enable compile testing")Fixes a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic CPUidle driver")Cc Randy Dunlap <[email protected]>Reviewed-by Dmitry Osipenko <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>Quoted 6 lines
---
I found this in my backlog of patches that never made it upstream, testing shows this is still needed. Please apply.--- drivers/cpuidle/Kconfig.arm | 2 ++ 1 file changed, 2 insertions(+)
Quoted 1 line
Acked-by Thierry Reding <[email protected]>
Applied as 6.3 material, thanks!