Skip to contentSkip to conversation

ARM: dts: add device-tree and bindings for renesas,rzn1d400-eb

PATCH Superseded Clément Léger 4 participants 8 messages Feb 7, 2023 – Feb 9, 2023

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: add device-tree and bindings for renesas,rzn1d400-eb

This short series adds support for the RZ/N1 Expansion Board. This board is a carrier board on which a daughter board (either RZ/N1D or RZ/N1S) can be plugged. The device-tree that is added by this series enables the use to the 2 external switch ports that are present on this board.

Clément Léger (2):
dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb
compatible
ARM: dts: r9a06g032: add EB board device-tree

 .../bindings/soc/renesas/renesas.yaml         |  6 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts   | 92 +++++++++++++++++++
 3 files changed, 99 insertions(+)
 create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
Signature · 1 line
2.39.0
#1 lore raw

PATCH 1/2 dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.

---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +6 -0
index 2789022b52eb..c31b10e5f44e 100644
@@ -431,6 +431,12 @@ properties:
               - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
           - const: renesas,r9a06g032
 
+      - description: RZ/N1{D,S} EB
+        items:
+          - enum:
+              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
+          - const: renesas,r9a06g032
+
       - description: RZ/Five and RZ/G2UL (R9A07G043)
         items:
           - enum:
Signature · 1 line
2.39.0
maintainer Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

Quoted 8 lines · Clément Léger

Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.

---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
#3 lore raw

Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

In reply to Clément Léger

Hi Clément,

Quoted 4 lines · Clément Léger

Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.

Thanks for your patch!

Documentation/devicetree/bindings/soc/renesas/renesas.yaml properties: · line 438

Quoted 11 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +5 -0
@@ -431,6 +431,12 @@ properties:
               - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
           - const: renesas,r9a06g032
 
+      - description: RZ/N1{D,S} EB
+        items:
+          - enum:
+              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
+          - const: renesas,r9a06g032

Don't you want to have "renesas,rzn1d400-db", too, in between the two other values?

Documentation/devicetree/bindings/soc/renesas/renesas.yaml properties: · line 442

Quoted 4 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +1 -0
+
       - description: RZ/Five and RZ/G2UL (R9A07G043)
         items:
           - enum:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw

Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

Quoted 16 lines · Geert Uytterhoeven

Hi Clément,

Quoted 4 lines · Clément Léger

Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.

Thanks for your patch!

Quoted 6 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +0 -0
@@ -431,6 +431,12 @@ properties:
               - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
           - const: renesas,r9a06g032
 
Quoted 8 lines

Documentation/devicetree/bindings/soc/renesas/renesas.yaml properties: · line 438

Quoted 5 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +5 -0
+      - description: RZ/N1{D,S} EB
+        items:
+          - enum:
+              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
+          - const: renesas,r9a06g032  

Don't you want to have "renesas,rzn1d400-db", too, in between the two other values?

Do you mean like that ?

- enum:
- renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
RZN1D-DB)
- const: renesas,rzn1d400-db
- const: renesas,r9a06g032

And thus using compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Thanks,

Quoted 16 lines

Documentation/devicetree/bindings/soc/renesas/renesas.yaml properties: · line 442

Quoted 5 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +1 -0
+
       - description: RZ/Five and RZ/G2UL (R9A07G043)
         items:
           - enum:  

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Signature · 3 lines
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
#5 lore raw

Re: [PATCH 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

Hi Clément,

Quoted 27 lines · Clément Léger
Quoted 14 lines · Geert Uytterhoeven
Quoted 4 lines · Clément Léger

Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.

Thanks for your patch!

Quoted 6 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +0 -0
@@ -431,6 +431,12 @@ properties:
               - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
           - const: renesas,r9a06g032
 
Quoted 8 lines

Documentation/devicetree/bindings/soc/renesas/renesas.yaml properties: · line 438

Quoted 5 lines
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +5 -0
+      - description: RZ/N1{D,S} EB
+        items:
+          - enum:
+              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
+          - const: renesas,r9a06g032

Don't you want to have "renesas,rzn1d400-db", too, in between the two other values?

Do you mean like that ?

Quoted 8 lines

- enum:
- renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
RZN1D-DB)
- const: renesas,rzn1d400-db
- const: renesas,r9a06g032

And thus using compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Exactly!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw

PATCH 2/2 ARM: dts: r9a06g032: add EB board device-tree

In reply to Clément Léger

The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.

---
 arch/arm/boot/dts/Makefile                  |  1 +
 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts | 92 +++++++++++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
arch/arm/boot/dts/Makefile +1 -0
index d08a3c450ce7..8938db01e939 100644
@@ -1123,6 +1123,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \
 	r8a7794-alt.dtb \
 	r8a7794-silk.dtb \
 	r9a06g032-rzn1d400-db.dtb \
+	r9a06g032-rzn1d400-eb.dtb \
 	sh73a0-kzm9g.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rv1108-elgin-r1.dtb \
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
2.39.0
#7 lore raw

Re: [PATCH 2/2] ARM: dts: r9a06g032: add EB board device-tree

Quoted 47 lines · Clément Léger

The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.

---
 arch/arm/boot/dts/Makefile                  |  1 +
 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts | 92 +++++++++++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
arch/arm/boot/dts/Makefile +1 -0
index d08a3c450ce7..8938db01e939 100644
@@ -1123,6 +1123,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \
 	r8a7794-alt.dtb \
 	r8a7794-silk.dtb \
 	r9a06g032-rzn1d400-db.dtb \
+	r9a06g032-rzn1d400-eb.dtb \
 	sh73a0-kzm9g.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rv1108-elgin-r1.dtb \
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +17 -0
new file mode 100644
index 000000000000..e986b6d2fd6f
@@ -0,0 +1,92 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the RZN1D-EB Board
+ *
+ * Copyright (C) 2023 Schneider-Electric
+ *
+ */
+
+#include "r9a06g032-rzn1d400-db.dts"
+
+/ {
+	model = "RZN1D-EB Board";
+	compatible = "renesas,rzn1d400-eb", "renesas,r9a06g032";
+};
+
+&mii_conv2 {
+	renesas,miic-input = <MIIC_SWITCH_PORTD>;

arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 27

Quoted 10 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +10 -0
+	status = "okay";
+};
+
+&mii_conv3 {
+	renesas,miic-input = <MIIC_SWITCH_PORTC>;
+	status = "okay";
+};
+
+&pinctrl{
+	pins_eth1: pins_eth1 {

No underscores in node names, unless you override existing node with such underscore.

Best regards,
Krzysztof