Skip to contentSkip to conversation

telemetry: reset data before passing it to callback

PATCH In review Robin Jarry 2 participants 3 messages Feb 7, 2023 – Feb 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 telemetry: reset data before passing it to callback

If a telemetry endpoint callback returns 0 without modifying the data object, output_json() may be called with undefined contents in data. This can cause crashes and/or worse (double free, etc.).

Reset data before passing it to the endpoint callbacks.

Fixes 6dd571fd07c3 ("telemetry: introduce new functionality")
---
 lib/telemetry/telemetry.c | 2 ++
 1 file changed, 2 insertions(+)
lib/telemetry/telemetry.c +2 -0
index 655191bcf17f..6303429bb0c9 100644
@@ -335,6 +335,8 @@ perform_command(telemetry_cb fn, const char *cmd, const char *param, int s)
 {
 	struct rte_tel_data data;
 
+	memset(&data, 0, sizeof(data));
+
 	int ret = fn(cmd, param, &data);
 	if (ret < 0) {
 		char out_buf[MAX_CMD_LEN + 10];
Signature · 1 line
2.39.1
#1 lore raw
Quoted 6 lines · Robin Jarry

If a telemetry endpoint callback returns 0 without modifying the data object, output_json() may be called with undefined contents in data. This can cause crashes and/or worse (double free, etc.).

Reset data before passing it to the endpoint callbacks.

Quoted 8 lines
Fixes 6dd571fd07c3 ("telemetry: introduce new functionality")
---
 lib/telemetry/telemetry.c | 2 ++
 1 file changed, 2 insertions(+)

This is also fixed by patch http://patches.dpdk.org/project/dpdk/patch/[email protected]/

While both work the same way, I think I prefer the fix to set "= {0}" on init rather than explicit memset.

/Bruce

#2 lore raw

Bruce Richardson, Feb 08, 2023 at 10:03:

Quoted 4 lines

This is also fixed by patch http://patches.dpdk.org/project/dpdk/patch/[email protected]/

While both work the same way, I think I prefer the fix to set "= {0}" on init rather than explicit memset.

Oh I had missed that one. Any of these two patches should be applied and backported. Feel free to take the first one that was sent :)

As I said in the commit message, it can cause the whole application to crash. It may also expose data from other telemetry endpoint handlers to other handlers, I don't think this can be considered as a security issue but I may be wrong.