habanalabs: change unused extern decl of hdev to forward decl of hl_device
PATCH 1/1 habanalabs: change unused extern decl of hdev to forward decl of hl_device
Building with clang W=2 has several similar warningsdrivers/accel/habanalabs/common/decoder.c:46:51: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] static void dec_error_intr_work(struct hl_device *hdev, u32 base_addr, u32 core_id)
^
drivers/accel/habanalabs/common/security.h:13:26: note: previous declaration is here
extern struct hl_device *hdev;
^There is no global definition of hdev, so the extern is not needed. Searched with
grep -r '^struct' . | grep hl_dev
Change to an forward decl to resolve these issuesdrivers/accel/habanalabs/common/mmu/../security.h:133:40: error: ‘struct hl_device’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
133 | bool (*skip_block_hook)(struct hl_device *hdev,
| ^~~~~~~~~
--- drivers/accel/habanalabs/common/security.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accel/habanalabs/common/security.h +1 -1
@@ -10,7 +10,7 @@#include <linux/io-64-nonatomic-lo-hi.h> -extern struct hl_device *hdev; +struct hl_device ;/* special blocks */ #define HL_MAX_NUM_OF_GLBL_ERR_CAUSE 10
Signature · 1 line
2.26.3
Quoted 12 lines · Tom Rix
Building with clang W=2 has several similar warnings
drivers/accel/habanalabs/common/decoder.c:46:51: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] static voiddec_error_intr_work(struct hl_device *hdev, u32 base_addr, u32 core_id)^ drivers/accel/habanalabs/common/security.h:13:26: note: previous declaration is here extern struct hl_device *hdev; ^There is no global definition of hdev, so the extern is not needed. Searched with
grep -r '^struct' . | grephl_dev
Quoted 6 lines
Change to an forward decl to resolve these issues
drivers/accel/habanalabs/common/mmu/../security.h:133:40: error: ‘struct hl_device’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
133 | bool (*skip_block_hook)(structhl_device*hdev,
| ^~~~~~~~~Signed-off-by Tom Rix <[email protected]>
Quoted 20 lines
--- drivers/accel/habanalabs/common/security.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/accel/habanalabs/common/security.h +1
-1@@ -10,7 +10,7 @@#include <linux/io-64-nonatomic-lo-hi.h> -extern struct hl_device *hdev; +struct hl_device ;/* special blocks */ #define HL_MAX_NUM_OF_GLBL_ERR_CAUSE 10Signature · 1 line
2.26.3
Quoted 34 lines · Stanislaw Gruszka
Quoted 12 lines · Tom Rix
Building with clang W=2 has several similar warnings
drivers/accel/habanalabs/common/decoder.c:46:51: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] static voiddec_error_intr_work(struct hl_device *hdev, u32 base_addr, u32 core_id)^ drivers/accel/habanalabs/common/security.h:13:26: note: previous declaration is here extern struct hl_device *hdev; ^There is no global definition of hdev, so the extern is not needed. Searched with
grep -r '^struct' . | grephl_devQuoted 6 lines
Change to an forward decl to resolve these issues
drivers/accel/habanalabs/common/mmu/../security.h:133:40: error: ‘struct hl_device’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
133 | bool (*skip_block_hook)(structhl_device*hdev,
| ^~~~~~~~~Signed-off-by Tom Rix <[email protected]>Reviewed-by Stanislaw Gruszka <[email protected]>Quoted 12 lines
--- drivers/accel/habanalabs/common/security.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/accel/habanalabs/common/security.h +0
-0@@ -10,7 +10,7 @@#include <linux/io-64-nonatomic-lo-hi.h>
Quoted 8 lines
Quoted 8 lines
drivers/accel/habanalabs/common/security.h +1
-2-extern struct hl_device *hdev; +struct hl_device ;/* special blocks */ #define HL_MAX_NUM_OF_GLBL_ERR_CAUSE 10 --2.26.3
Thanks, applied to -next.
Oded