Skip to contentSkip to conversation

arm: qcom: sa8775p: add socinfo support

PATCH Applied Bartosz Golaszewski 4 participants 13 messages Feb 9, 2023 – Mar 15, 2023

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

v2 cover arm: qcom: sa8775p: add socinfo support

From: Bartosz Golaszewski <[email protected]>

This series adds support for qcom-socinfo for SA8775P SoCs.

v1 -> v2:
- fix ordering of socinfo defines
- fix the commit subject line for patch 2/3
- collect the Ack from Krzysztof

Bartosz Golaszewski (3):
soc: qcom: smem: update max processor count
dt-bindings: arm: qcom: add the SoC ID for SA8775P
soc: qcom: socinfo: add support for SA8775P

 drivers/soc/qcom/smem.c            | 2 +-
 drivers/soc/qcom/socinfo.c         | 1 +
 include/dt-bindings/arm/qcom,ids.h | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.37.2
author
#1 lore raw

PATCH v2 1/3 soc: qcom: smem: update max processor count

From: Bartosz Golaszewski <[email protected]>

Update max processor count to reflect the number of co-processors on SA8775P SoCs.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/soc/qcom/smem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/smem.c +1 -1
index 4f163d62942c..7666b3425b7c 100644
@@ -85,7 +85,7 @@
 #define SMEM_GLOBAL_HOST	0xfffe
 
 /* Max number of processors/hosts in a system */
-#define SMEM_HOST_COUNT		15
+#define SMEM_HOST_COUNT		20
 
 /**
   * struct smem_proc_comm - proc_comm communication struct (legacy)
Signature · 1 line
2.37.2
Reviewed-by Tested-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] soc: qcom: smem: update max processor count

Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Update max processor count to reflect the number of co-processors on SA8775P SoCs.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/soc/qcom/smem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]>
Signature · 1 line
Eric Chanudet
author
#3 lore raw

PATCH v2 2/3 dt-bindings: arm: qcom: add the SoC ID for SA8775P

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the SoC ID entry for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
include/dt-bindings/arm/qcom,ids.h +1 -0
index 22d7ba17804b..bfdf066cc690 100644
@@ -223,6 +223,7 @@
 #define QCOM_ID_SC7180P			495
 #define QCOM_ID_SM6375			507
 #define QCOM_ID_SM8550			519
+#define QCOM_ID_SA8775P			534
 #define QCOM_ID_QRU1000			539
 #define QCOM_ID_QDU1000			545
 #define QCOM_ID_QDU1010			587
Signature · 1 line
2.37.2
Reviewed-by Tested-by on v2 2/3
#4 lore raw

Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the SoC ID entry for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]>
Signature · 1 line
Eric Chanudet
#5 lore raw

Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

Quoted 5 lines · Eric Chanudet
Quoted 4 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the SoC ID entry for SA8775P.

Quoted 8 lines
Quoted 5 lines
Signed-off-by Bartosz Golaszewski <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]>

How can you test a header? What type of testing Redhat does on the headers?

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · Eric Chanudet
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the SoC ID entry for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 2 lines
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]>

How can you test a header? What type of testing Redhat does on the headers?

IIUC that ID is compared against the one read from SMEM by the socinfo driver. I meant to confirm it matched the number the board I have returned. My apologies in advance if that was inappropriate.

Signature · 1 line
Eric Chanudet
#7 lore raw

Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

Quoted 13 lines · Eric Chanudet
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · Eric Chanudet
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the SoC ID entry for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]>

How can you test a header? What type of testing Redhat does on the headers?

IIUC that ID is compared against the one read from SMEM by the socinfo driver. I meant to confirm it matched the number the board I have returned. My apologies in advance if that was inappropriate.

OK... I would say it is a review then, but can be also this way.

Best regards,
Krzysztof

author
#8 lore raw

PATCH v2 3/3 soc: qcom: socinfo: add support for SA8775P

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add SocInfo support for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/qcom/socinfo.c +1 -0
index e24895f98600..a951d0f7d3ba 100644
@@ -436,6 +436,7 @@ static const struct soc_id soc_id[] = {
 	{ qcom_board_id(SC7180P) },
 	{ qcom_board_id(SM6375) },
 	{ qcom_board_id(SM8550) },
+	{ qcom_board_id(SA8775P) },
 	{ qcom_board_id(QRU1000) },
 	{ qcom_board_id(QDU1000) },
 	{ qcom_board_id(QDU1010) },
Signature · 1 line
2.37.2
Reviewed-by Tested-by on v2 3/3
#10 lore raw

Re: [PATCH v2 3/3] soc: qcom: socinfo: add support for SA8775P

In reply to Bartosz Golaszewski
Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add SocInfo support for SA8775P.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by Eric Chanudet <[email protected]>
Tested-by Eric Chanudet <[email protected]> # sa8775p-ride
Signature · 1 line
Eric Chanudet
author
#11 lore raw
In reply to Bartosz Golaszewski
Quoted 15 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series adds support for qcom-socinfo for SA8775P SoCs.

v1 -> v2:
- fix ordering of socinfo defines
- fix the commit subject line for patch 2/3
- collect the Ack from Krzysztof

Bartosz Golaszewski (3):
soc: qcom: smem: update max processor count
dt-bindings: arm: qcom: add the SoC ID for SA8775P
soc: qcom: socinfo: add support for SA8775P

Quoted 8 lines
 drivers/soc/qcom/smem.c            | 2 +-
 drivers/soc/qcom/socinfo.c         | 1 +
 include/dt-bindings/arm/qcom,ids.h | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

--
2.37.2

Bjorn,

Looks like this is ready to go, so gentle ping.

Bart

maintainer Applied
#12 lore raw
In reply to Bartosz Golaszewski
Quoted 10 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This series adds support for qcom-socinfo for SA8775P SoCs.

v1 -> v2:
- fix ordering of socinfo defines
- fix the commit subject line for patch 2/3
- collect the Ack from Krzysztof

[...]

Applied, thanks!

[1/3] soc: qcom: smem: update max processor count

      commit: b302c64a3c0a005f39155e9aef5e99ad8a9abbb7
[2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P
      commit: 26a4bf805c6cd88847dd045f6b29d8a20f02d8df
[3/3] soc: qcom: socinfo: add support for SA8775P
      commit: 7fa9c5fc1a753ac593904ebe9c4e8628a4240096

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>