Skip to contentSkip to conversation

MIPS: pci: lantiq: Use devm_platform_get_and_ioremap_resource()

PATCH Applied [email protected] 2 participants 2 messages Feb 8, 2023 – Feb 9, 2023 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: pci: lantiq: Use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 arch/mips/pci/pci-lantiq.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
arch/mips/pci/pci-lantiq.c +2 -6
index 8d16cd021f60..d967e4c0cf24 100644
@@ -204,17 +204,13 @@ static int ltq_pci_startup(struct platform_device *pdev)
 
 static int ltq_pci_probe(struct platform_device *pdev)
 {
-	struct resource *res_cfg, *res_bridge;
-
 	pci_clear_flags(PCI_PROBE_ONLY);
 
-	res_bridge = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	ltq_pci_membase = devm_ioremap_resource(&pdev->dev, res_bridge);
+	ltq_pci_membase = devm_platform_get_and_ioremap_resource(pdev, 1, NULL);
 	if (IS_ERR(ltq_pci_membase))
 		return PTR_ERR(ltq_pci_membase);
 
-	res_cfg = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ltq_pci_mapped_cfg = devm_ioremap_resource(&pdev->dev, res_cfg);
+	ltq_pci_mapped_cfg = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(ltq_pci_mapped_cfg))
 		return PTR_ERR(ltq_pci_mapped_cfg);
 
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 10 lines · On Wed, Feb 08, 2023 at 10:46:39AM +0800, [email protected] wrote:

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 arch/mips/pci/pci-lantiq.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]