ARM: dts: add device-tree and bindings for renesas,rzn1d400-eb
Subsystems (3)
v2 cover ARM: dts: add device-tree and bindings for renesas,rzn1d400-eb
This short series adds support for the RZ/N1 Expansion Board. This board is a carrier board on which a daughter board (either RZ/N1D or RZ/N1S) can be plugged. The device-tree that is added by this series enables the use to the 2 external switch ports that are present on this board.
----------------
V2:
- Add "renesas,rzn1d400-db" in list of compatibles for EB board
- Replace '_' with '-' in eth pins node name
- Split some long lines in dts
Clément Léger (2):
dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb
compatible
ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
.../bindings/soc/renesas/renesas.yaml | 7 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts | 94 +++++++++++++++++++ 3 files changed, 102 insertions(+) create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
Signature · 1 line
2.39.0
PATCH v2 1/2 dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible
Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.
--- Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/soc/renesas/renesas.yaml +7 -0
@@ -431,6 +431,13 @@ properties: - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package) - const: renesas,r9a06g032 + - description: RZ/N1{D,S} EB + items: + - enum: + - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB) + - const: renesas,rzn1d400-db + - const: renesas,r9a06g032 + - description: RZ/Five and RZ/G2UL (R9A07G043) items: - enum:
Signature · 1 line
2.39.0
Re: [PATCH v2 1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible
Quoted 5 lines · Clément Léger
Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB daughter board is plugged on it.
Signed-off-by Clément Léger <[email protected]>Acked-by Rob Herring <[email protected]>
i.e. will queue in renesas-devel for v6.4.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH v2 2/2 ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
In reply to Clément LégerThe EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts | 94 +++++++++++++++++++++ 2 files changed, 95 insertions(+) create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -1123,6 +1123,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \ r8a7794-alt.dtb \ r8a7794-silk.dtb \ r9a06g032-rzn1d400-db.dtb \ + r9a06g032-rzn1d400-eb.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += \ rv1108-elgin-r1.dtb \
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +94 -0
94 lines not on this page · raw message
Signature · 1 line
2.39.0
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hi Clément,
CC Gareth
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>
Thanks for your patch!
Quoted 57 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +54
-0@@ -0,0 +1,94 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the RZN1D-EB Board + * + * Copyright (C) 2023 Schneider-Electric + * + */ + +#include "r9a06g032-rzn1d400-db.dts" + +/ { + model = "RZN1D-EB Board"; + compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db", + "renesas,r9a06g032"; +}; + +&mii_conv2 { + renesas,miic-input = <MIIC_SWITCH_PORTD>; + status = "okay"; +}; + +&mii_conv3 { + renesas,miic-input = <MIIC_SWITCH_PORTC>; + status = "okay"; +}; + +&pinctrl{ + pins_eth1: pins-eth1 { + pinmux = <RZN1_PINMUX(12, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(13, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(14, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(15, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(16, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(17, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(18, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(19, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(20, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(21, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(22, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(23, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable; + }; + + pins_eth2: pins-eth2 { + pinmux = <RZN1_PINMUX(24, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(25, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(26, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(27, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(28, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(29, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(30, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(31, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(32, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>,
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 64
Quoted 10 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +10
-0+ <RZN1_PINMUX(33, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(34, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(35, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable; + }; +}; + +&switch { + pinctrl-names = "default";
No need to specify pinctrl-names, as it is inherited from r9a06g032-rzn1d400-db.dts.
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 72
Quoted 8 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;
marvell,reg-init is not documented in any DT bindings document?
Quoted 12 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +12
-0+ }; + + switch0phy10: ethernet-phy@10 { + reg = <10>; + marvell,reg-init = <3 16 0 0x1010>; + }; + }; +}; + +&switch_port2 { + label = "lan2"; + phy-mode = "rgmii-id";
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 94
Quoted 10 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +10
-0+ phy-handle = <&switch0phy10>; + status = "okay"; +}; + +&switch_port3 { + label = "lan3"; + phy-mode = "rgmii-id"; + phy-handle = <&switch0phy1>; + status = "okay"; +};
The rest LGTM (as far as I can understand ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Quoted 76 lines · Geert Uytterhoeven
Hi Clément,
CC Gareth
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
Quoted 62 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +59
-0@@ -0,0 +1,94 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the RZN1D-EB Board + * + * Copyright (C) 2023 Schneider-Electric + * + */ + +#include "r9a06g032-rzn1d400-db.dts" + +/ { + model = "RZN1D-EB Board"; + compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db", + "renesas,r9a06g032"; +}; + +&mii_conv2 { + renesas,miic-input = <MIIC_SWITCH_PORTD>; + status = "okay"; +}; + +&mii_conv3 { + renesas,miic-input = <MIIC_SWITCH_PORTC>; + status = "okay"; +}; + +&pinctrl{ + pins_eth1: pins-eth1 { + pinmux = <RZN1_PINMUX(12, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(13, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(14, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(15, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(16, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(17, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(18, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(19, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(20, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(21, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(22, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(23, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable; + }; + + pins_eth2: pins-eth2 { + pinmux = <RZN1_PINMUX(24, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(25, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(26, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(27, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(28, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(29, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(30, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(31, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(32, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(33, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(34, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(35, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable;
Quoted 8 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 64
Quoted 5 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +5
-0+ }; +}; + +&switch { + pinctrl-names = "default";No need to specify pinctrl-names, as it is inherited from
r9a06g032-rzn1d400-db.dts.
Acked.
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 72
Quoted 9 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Signature · 3 lines
Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Quoted 100 lines · Clément Léger
Quoted 76 lines · Geert Uytterhoeven
Hi Clément,
CC Gareth
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
Quoted 62 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +59
-0@@ -0,0 +1,94 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the RZN1D-EB Board + * + * Copyright (C) 2023 Schneider-Electric + * + */ + +#include "r9a06g032-rzn1d400-db.dts" + +/ { + model = "RZN1D-EB Board"; + compatible = "renesas,rzn1d400-eb", "renesas,rzn1d400-db", + "renesas,r9a06g032"; +}; + +&mii_conv2 { + renesas,miic-input = <MIIC_SWITCH_PORTD>; + status = "okay"; +}; + +&mii_conv3 { + renesas,miic-input = <MIIC_SWITCH_PORTC>; + status = "okay"; +}; + +&pinctrl{ + pins_eth1: pins-eth1 { + pinmux = <RZN1_PINMUX(12, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(13, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(14, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(15, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(16, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(17, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(18, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(19, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(20, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(21, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(22, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(23, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable; + }; + + pins_eth2: pins-eth2 { + pinmux = <RZN1_PINMUX(24, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(25, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(26, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(27, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(28, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(29, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(30, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(31, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(32, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(33, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(34, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>, + <RZN1_PINMUX(35, RZN1_FUNC_CLK_ETH_MII_RGMII_RMII)>; + drive-strength = <6>; + bias-disable;Quoted 8 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 64
Quoted 5 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +5
-0+ }; +}; + +&switch { + pinctrl-names = "default";No need to specify pinctrl-names, as it is inherited from
r9a06g032-rzn1d400-db.dts.Acked.
Quoted 10 lines
Quoted 9 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;
Quoted 6 lines
Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Hi Geert,
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
Signature · 3 lines
Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hi Clément,
Quoted 32 lines · Clément Léger
Quoted 24 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 5 lines
Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Quoted 5 lines
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
In that case, please keep it.
But the property really should be documented, one day...
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hi Clément,
Quoted 34 lines · Geert Uytterhoeven
Quoted 31 lines · Clément Léger
Quoted 29 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts line 72
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Quoted 8 lines
Quoted 5 lines
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
In that case, please keep it.
But the property really should be documented, one day...
Any plans to follow-up?
Thanks!
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hello Geert,
Quoted 44 lines · Geert Uytterhoeven
Hi Clément,
Quoted 40 lines · Geert Uytterhoeven
Quoted 37 lines · Clément Léger
Quoted 24 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 5 lines
Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
Quoted 4 lines
Quoted 2 lines
In that case, please keep it.
But the property really should be documented, one day...Any plans to follow-up?
Clément is no longer working with us; most of his ongoing work has been offloaded to colleagues and mostly taken care of but this one has clearly fallen into the cracks :)
I'm adding two colleagues in Cc in case they can have a look.
Cheers,
Miquèl
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hello Geert,
I've started working on this issue, however I have one problem :
Quoted 38 lines
Quoted 38 lines
Hi Clément,
Quoted 34 lines · Geert Uytterhoeven
Quoted 31 lines · Clément Léger
Quoted 29 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
In that case, please keep it.
But the property really should be documented, one day...
As Clément mentioned, this property is used to set up the LEDs for Marvell PHY. However, Marvell's PHYs have no dedicated bindings; only their associated switches do. PHY's usually don't have their own yaml, so there is no easy place where to add this property. We could however describe them in the numerous switch bindings that embed a Marvell PHY, which are: Qualcomm ETHQOS, Cadence MACB/GEM, Gianfar, Freescale FEC, Renesas switches and of course Marvell switches.
I already thought of doing it in the binding of the renesas switch, like this :
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml:
``` \[...\] mdio: $ref: /schemas/net/mdio.yaml# patternProperties: '@\[0-9a-f\]+$': properties: marvel,reg-init: - description: Lorem Ipsum unevaluatedProperties: false \[...\] ```
but it would document it only for this particular switch.
It is also possible to do it in the main mdio.yaml on the model of this:
https://elixir.bootlin.com/linux/v6.13.1/source/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml#L121
What's your opinion on this ?
Moreover, everywhere this property is used in the kernel, it is to set up the LEDs. Nowadays, the Marvell PHY driver should be able to handle LEDs without this property. Therefore, this property should be deprecated in this case.
Regards,
Thomas
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hi Thomas,
Quoted 74 lines · Thomas Bonnefille
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines · Geert Uytterhoeven
Quoted 31 lines · Clément Léger
Quoted 29 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
In that case, please keep it.
But the property really should be documented, one day...As Clément mentioned, this property is used to set up the LEDs for Marvell PHY. However, Marvell's PHYs have no dedicated bindings; only their associated switches do. PHY's usually don't have their own yaml, so there is no easy place where to add this property. We could however describe them in the numerous switch bindings that embed a Marvell PHY, which are: Qualcomm ETHQOS, Cadence MACB/GEM, Gianfar, Freescale FEC, Renesas switches and of course Marvell switches.
I already thought of doing it in the binding of the renesas switch, like this :
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml:``` \[...\] mdio: $ref: /schemas/net/mdio.yaml# patternProperties: '@\[0-9a-f\]+$': properties: marvel,reg-init: - description: Lorem Ipsum unevaluatedProperties: false \[...\] ```
Quoted 5 lines
but it would document it only for this particular switch.
It is also possible to do it in the mainmdio.yamlon the model of this:
https://elixir.bootlin.com/linux/v6.13.1/source/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml#L121What's your opinion on this ?
Oh, so this is a similar issue as the one preventing us from converting the Micrel PHY bindings to dt-schema[1]?
You could still document it in a text binding file:Documentation/devicetree/bindings/net/marvell,phy.txt That cannot be used for validation, but at least people can find the property using git grep...
Quoted 4 lines
Moreover, everywhere this property is used in the kernel, it is to set up the LEDs. Nowadays, the Marvell PHY driver should be able to handle LEDs without this property. Therefore, this property should be deprecated in this case.
So the LED works now on this board without the property? Then the property can be dropped?
[1] "[PATCH] [RFC] dt-bindings: net: micrel: Convert to json-schema"
https://lore.kernel.org/linux-renesas-soc/943cb31d01d0da3a63911326e24fbf9b328f7206.1731580776.git.geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 2/2] ARM: dts: r9a06g032: add r9a06g032-rzn1d400-eb board device-tree
Hello Geert,
Quoted 82 lines
Quoted 74 lines · Thomas Bonnefille
Quoted 36 lines
Quoted 36 lines
Quoted 34 lines · Geert Uytterhoeven
Quoted 31 lines · Clément Léger
Quoted 29 lines · Clément Léger
Quoted 22 lines · Geert Uytterhoeven
Quoted 6 lines · Clément Léger
The EB board (Expansion board) supports both RZ/N1D and RZ-N1S. Since this configuration targets only the RZ/N1D, it is named r9a06g032-rzn1d400-eb. It adds support for the 2 additional switch ports (port C and D) that are available on that board.
Signed-off-by Clément Léger <[email protected]>Thanks for your patch!
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts
Quoted 11 lines
arch/arm/boot/dts/r9a06g032-rzn1d400-eb.dts new file +8
-0+ pinctrl-0 = <&pins_eth1>, <&pins_eth2>, <&pins_eth3>, <&pins_eth4>, + <&pins_mdio1>; + + mdio { + /* CN15 and CN16 switches must be configured in MDIO2 mode */ + switch0phy1: ethernet-phy@1 { + reg = <1>; + marvell,reg-init = <3 16 0 0x1010>;Quoted 1 line
marvell,reg-init is not documented in any DT bindings document?
Indeed, this is not somethiong that should be made available here. It's only inverting the LED polarity but supported by some internal patch. I'll remove that.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
I actually was confused by a property I added in another device-tree but marvell,reg-init exists, is handled by the marvell phy driver and used in a few device-trees. Strangely, it is not documented anywhere. So I can either remove that (and the LED won't work properly) or let it live depending on what you prefer.
In that case, please keep it.
But the property really should be documented, one day...As Clément mentioned, this property is used to set up the LEDs for Marvell PHY. However, Marvell's PHYs have no dedicated bindings; only their associated switches do. PHY's usually don't have their own yaml, so there is no easy place where to add this property. We could however describe them in the numerous switch bindings that embed a Marvell PHY, which are: Qualcomm ETHQOS, Cadence MACB/GEM, Gianfar, Freescale FEC, Renesas switches and of course Marvell switches.
I already thought of doing it in the binding of the renesas switch, like this :
Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml:``` \[...\] mdio: $ref: /schemas/net/mdio.yaml# patternProperties: '@\[0-9a-f\]+$': properties: marvel,reg-init: - description: Lorem Ipsum unevaluatedProperties: false \[...\] ```Quoted 5 lines
but it would document it only for this particular switch.
It is also possible to do it in the mainmdio.yamlon the model of this:
https://elixir.bootlin.com/linux/v6.13.1/source/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml#L121What's your opinion on this ?
Quoted 8 lines
Oh, so this is a similar issue as the one preventing us from converting the Micrel PHY bindings to dt-schema[1]?
You could still document it in a text binding file:
Documentation/devicetree/bindings/net/marvell,phy.txtThat cannot be used for validation, but at least people can find the property using git grep...
Ack, I'll do that.
However, after the third version this series will no longer be related to the marvell,reg-init property. Therefore, I might document it in a different series.
Quoted 7 lines
Quoted 4 lines
Moreover, everywhere this property is used in the kernel, it is to set up the LEDs. Nowadays, the Marvell PHY driver should be able to handle LEDs without this property. Therefore, this property should be deprecated in this case.
So the LED works now on this board without the property? Then the property can be dropped?
Yes it does, I "just" have to add an LED as a child node of the phy in the device-tree.
I'll send a third version using this mechanism soon. However, I will not be able to test it on the real evaluation board but on a proprietary board using the same SoC and PHY. It should not cause any problem as I will reproduce exactly what the marvell,reg-init property was doing.
Regards,
Thomas