Skip to contentSkip to conversation

dt-bindings: mailbox: sti: convert sti-mailbox to DT schema

PATCH Superseded Alain Volmat 2 participants 2 messages Feb 11, 2023 – Feb 12, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mailbox: sti: convert sti-mailbox to DT schema

Convert the sti-mailbox.txt dt-bindings into dt-schema YAML.

---
 .../bindings/mailbox/st,sti-mailbox.yaml      | 54 +++++++++++++++++++
 .../bindings/mailbox/sti-mailbox.txt          | 51 ------------------
 2 files changed, 54 insertions(+), 51 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml
 delete mode 100644 Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +54 -0
new file mode 100644
index 000000000000..527c88147397
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/mailbox/st,sti-mailbox.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: STMicroelectronics Mailbox Driver
+
+description:
+  Each ST Mailbox IP currently consists of 4 instances of 32 channels.
+  Messages are passed between Application and Remote processors using
+  shared memory.
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+
+properties:
+  compatible:
+    const: st,stih407-mailbox
+
+  reg:
+    maxItems: 1
+
+  mbox-name:
+    description: name of the mailbox
+    maxItems: 1
+
+  interrupts:
+    description: the irq line for the RX mailbox
+    maxItems: 1
+
+  "#mbox-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - "#mbox-cells"
+  - mbox-name
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    mailbox0: mailbox@8f00000  {
+        compatible = "st,stih407-mailbox";
+        reg = <0x08f00000 0x1000>;
+        interrupts = <GIC_SPI 1 IRQ_TYPE_NONE>;
+        #mbox-cells = <2>;
+        mbox-name = "a9";
+    };
+
+...
Documentation/devicetree/bindings/mailbox/sti-mailbox.txt deleted +0 -51

51 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 16 lines · Alain Volmat

Convert the sti-mailbox.txt dt-bindings into dt-schema YAML.

---
 .../bindings/mailbox/st,sti-mailbox.yaml      | 54 +++++++++++++++++++
 .../bindings/mailbox/sti-mailbox.txt          | 51 ------------------
 2 files changed, 54 insertions(+), 51 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml
 delete mode 100644 Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +0 -0
new file mode 100644
index 000000000000..527c88147397

Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml line 5

Quoted 5 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +5 -0
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/mailbox/st,sti-mailbox.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop quotes from both.

Quoted 11 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +11 -0
+
+title: STMicroelectronics Mailbox Driver
+
+description:
+  Each ST Mailbox IP currently consists of 4 instances of 32 channels.
+  Messages are passed between Application and Remote processors using
+  shared memory.
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+

Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml line 26

Quoted 10 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +10 -0
+properties:
+  compatible:
+    const: st,stih407-mailbox
+
+  reg:
+    maxItems: 1
+
+  mbox-name:
+    description: name of the mailbox
+    maxItems: 1

Is the field defined anywhere? Looks like not, thus you need proper type (and maxItems might not be correct then).

Quoted 13 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +13 -0
+
+  interrupts:
+    description: the irq line for the RX mailbox
+    maxItems: 1
+
+  "#mbox-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - "#mbox-cells"
+  - mbox-name

Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml line 49

Quoted 10 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +10 -0
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    mailbox0: mailbox@8f00000  {
+        compatible = "st,stih407-mailbox";
+        reg = <0x08f00000 0x1000>;
+        interrupts = <GIC_SPI 1 IRQ_TYPE_NONE>;

This should be rather proper type of interrupt, not none.

Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml line 54

Quoted 5 lines
Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml new file +5 -0
+        #mbox-cells = <2>;
+        mbox-name = "a9";
+    };
+
+...

Best regards,
Krzysztof