Skip to contentSkip to conversation

dt-bindings: arm: sti: addition of STi platform syscon

PATCH Superseded Alain Volmat 2 participants 7 messages Feb 11, 2023 – Feb 12, 2023 Device tree bindings

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: arm: sti: addition of STi platform syscon

Addition of the various STi platform syscon node description.

---
 .../bindings/arm/sti/st,sti-syscon.yaml       | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +46 -0
new file mode 100644
index 000000000000..e4bbc90694b3
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STi platform sysconfig entries
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+
+description: |
+  Binding for the various sysconfig nodes used within the STi
+  platform device-tree to point to some common configuration
+  registers used by other nodes.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - st,stih407-sbc-syscfg
+          - st,stih407-front-syscfg
+          - st,stih407-rear-syscfg
+          - st,stih407-flash-syscfg
+          - st,stih407-sbc-reg-syscfg
+          - st,stih407-core-syscfg
+          - st,stih407-lpm-syscfg
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    syscfg_sbc: sbc-syscfg@9620000 {
+        compatible = "st,stih407-sbc-syscfg", "syscon";
+        reg = <0x9620000 0x1000>;
+    };
+
+...
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 dt-bindings: arm: sti: add sti boards and remove stih415/stih416

Add bindings for STi platform boards and remove stih415/stih416 items. This commit also moves the sti.yaml binding file within the arm/sti/ folder instead of arm/

---
 .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
 .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 26 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
Documentation/devicetree/bindings/arm/sti.yaml deleted +0 -26
deleted file mode 100644
index 3ca054c64377..000000000000
@@ -1,26 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/sti.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ST STi Platforms
-
-maintainers:
-  - Patrice Chotard <[email protected]>
-
-properties:
-  $nodename:
-    const: '/'
-  compatible:
-    items:
-      - enum:
-          - st,stih415
-          - st,stih416
-          - st,stih407
-          - st,stih410
-          - st,stih418
-
-additionalProperties: true
-
-...
Documentation/devicetree/bindings/arm/sti/sti.yaml new file +33 -0
new file mode 100644
index 000000000000..aefa1919207c
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/sti.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST STi Platforms
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - items:
+          - const: st,stih407-b2120
+          - const: st,stih407
+      - items:
+          - enum:
+              - st,stih410-b2120
+              - st,stih410-b2260
+          - const: st,stih410
+      - items:
+          - enum:
+              - st,stih418-b2199
+              - st,stih418-b2264
+          - const: st,stih418
+
+additionalProperties: true
+
+...
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 2/2] dt-bindings: arm: sti: add sti boards and remove stih415/stih416

Quoted 50 lines · Alain Volmat

Add bindings for STi platform boards and remove stih415/stih416 items. This commit also moves the sti.yaml binding file within the arm/sti/ folder instead of arm/

---
 .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
 .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 26 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
Documentation/devicetree/bindings/arm/sti.yaml deleted +0 -26
deleted file mode 100644
index 3ca054c64377..000000000000
@@ -1,26 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/sti.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ST STi Platforms
-
-maintainers:
-  - Patrice Chotard <[email protected]>
-
-properties:
-  $nodename:
-    const: '/'
-  compatible:
-    items:
-      - enum:
-          - st,stih415
-          - st,stih416
-          - st,stih407
-          - st,stih410
-          - st,stih418
-
-additionalProperties: true
-
-...
Documentation/devicetree/bindings/arm/sti/sti.yaml new file +0 -0
new file mode 100644
index 000000000000..aefa1919207c

Documentation/devicetree/bindings/arm/sti/sti.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/arm/sti/sti.yaml new file +1 -0
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0

Dual-license. I don't think there is anything from old binding being copied here (you can as well start from scratch from other binding and result will be the same).

Best regards,
Krzysztof

#3 lore raw

Re: [PATCH 2/2] dt-bindings: arm: sti: add sti boards and remove stih415/stih416

Thanks for the review

Quoted 48 lines · Krzysztof Kozlowski
Quoted 47 lines · Alain Volmat

Add bindings for STi platform boards and remove stih415/stih416 items. This commit also moves the sti.yaml binding file within the arm/sti/ folder instead of arm/

---
 .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
 .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 26 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
Documentation/devicetree/bindings/arm/sti.yaml deleted +0 -26
deleted file mode 100644
index 3ca054c64377..000000000000
@@ -1,26 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/sti.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ST STi Platforms
-
-maintainers:
-  - Patrice Chotard <[email protected]>
-
-properties:
-  $nodename:
-    const: '/'
-  compatible:
-    items:
-      - enum:
-          - st,stih415
-          - st,stih416
-          - st,stih407
-          - st,stih410
-          - st,stih418
-
-additionalProperties: true
-
-...
Documentation/devicetree/bindings/arm/sti/sti.yaml new file +0 -0
new file mode 100644
index 000000000000..aefa1919207c
Quoted 8 lines

Documentation/devicetree/bindings/arm/sti/sti.yaml line 1

Quoted 4 lines
Documentation/devicetree/bindings/arm/sti/sti.yaml new file +1 -0
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0

Dual-license. I don't think there is anything from old binding being copied here (you can as well start from scratch from other binding and result will be the same).

Ok

I understand, based on your review of the other patch in the serie that I should put this sti.yaml within bindings/soc/sti right ?

Moreover, I made a mistake and removed st,stih415 and st,stih416 in this patch while I already posted the patch in the STiH415/STiH416 removal serie (https://lore.kernel.org/all/[email protected]/).
I propose to get rid of the patch in the other serie and do the removal within this patch since it also moves the file.

Quoted 4 lines

Best regards,
Krzysztof

#4 lore raw
In reply to Alain Volmat

Thank you for your patch. There is something to discuss/improve. Few nits.

Quoted 1 line · Alain Volmat

Addition of the various STi platform syscon node description.

Use imperative.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Quoted 13 lines
---
 .../bindings/arm/sti/st,sti-syscon.yaml       | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +0 -0
new file mode 100644
index 000000000000..e4bbc90694b3

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +7 -0
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STi platform sysconfig entries

Drop "entries", does not look related to hardware.

Quoted 10 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +10 -0
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+
+description: |
+  Binding for the various sysconfig nodes used within the STi
+  platform device-tree to point to some common configuration
+  registers used by other nodes.
+
+properties:

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 27

Quoted 10 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +10 -0
+  compatible:
+    items:
+      - enum:
+          - st,stih407-sbc-syscfg
+          - st,stih407-front-syscfg
+          - st,stih407-rear-syscfg
+          - st,stih407-flash-syscfg
+          - st,stih407-sbc-reg-syscfg
+          - st,stih407-core-syscfg
+          - st,stih407-lpm-syscfg

How about putting them in some order?

Quoted 4 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +4 -0
+      - const: syscon
+
+  reg:
+    maxItems: 1

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 41

Quoted 10 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    syscfg_sbc: sbc-syscfg@9620000 {

Generic node names, thus usually syscon or system-controller

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 46

Quoted 1 line
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +1 -0
+...

Best regards,
Krzysztof

#5 lore raw

Thanks for the review.

Quoted 46 lines · Krzysztof Kozlowski

Thank you for your patch. There is something to discuss/improve. Few nits.

Quoted 1 line · Alain Volmat

Addition of the various STi platform syscon node description.

Use imperative.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Quoted 13 lines
---
 .../bindings/arm/sti/st,sti-syscon.yaml       | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +0 -0
new file mode 100644
index 000000000000..e4bbc90694b3

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +7 -0
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STi platform sysconfig entries

Drop "entries", does not look related to hardware.

Quoted 14 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +14 -0
+
+maintainers:
+  - Patrice Chotard <[email protected]>
+
+description: |
+  Binding for the various sysconfig nodes used within the STi
+  platform device-tree to point to some common configuration
+  registers used by other nodes.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - st,stih407-sbc-syscfg
Quoted 8 lines

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 27

Quoted 6 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +6 -0
+          - st,stih407-front-syscfg
+          - st,stih407-rear-syscfg
+          - st,stih407-flash-syscfg
+          - st,stih407-sbc-reg-syscfg
+          - st,stih407-core-syscfg
+          - st,stih407-lpm-syscfg

How about putting them in some order?

Ok, changed to alphabet order

Quoted 17 lines
Quoted 5 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +4 -0
+      - const: syscon
+
+  reg:
+    maxItems: 1

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 41

Quoted 10 lines
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +10 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    syscfg_sbc: sbc-syscfg@9620000 {

Generic node names, thus usually syscon or system-controller

Ok, changed to syscfg_sbc: syscon@9620000

I also move the file within bindings/soc/sti as mentioned in your other reply.

Quoted 5 lines

Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml line 46

Quoted 1 line
Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml new file +1 -0
+...

Best regards,
Krzysztof

#6 lore raw
In reply to Alain Volmat
Quoted 7 lines · Alain Volmat

Addition of the various STi platform syscon node description.

---
 .../bindings/arm/sti/st,sti-syscon.yaml       | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml

Ah, and one more - incorrect directory. This should be in soc, not arm.

Best regards,
Krzysztof