nfsd: remove redundant assignment to pointer dentry
Subsystems (3)
PATCH 1/1 nfsd: remove redundant assignment to pointer dentry
The pointer dentry is assigned a value that is never read, the assignment is redundant and can be removed.
Cleans up clang-scan warning:fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is never read [deadcode.DeadStores]
dentry = ERR_PTR(ret);
--- fs/nfsd/nfsctl.c | 1 - 1 file changed, 1 deletion(-)
fs/nfsd/nfsctl.c +0 -1
@@ -1228,7 +1228,6 @@ static void nfsd_symlink(struct dentry *parent, const char *name,return ; out_err:dput (dentry); - dentry =ERR_PTR (ret); goto out; }#else
Signature · 1 line
2.30.2
Quoted 9 lines · Colin Ian King
The pointer dentry is assigned a value that is never read, the assignment is redundant and can be removed.
Cleans up clang-scan warning:
fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is never read [deadcode.DeadStores]dentry = ERR_PTR(ret);Signed-off-by Colin Ian King <[email protected]>
No need to initalized "int ret = -ENOMEM;" either.
regards,
dan carpenter
Quoted 8 lines · Dan Carpenter
Quoted 3 lines · Colin Ian King
The pointer dentry is assigned a value that is never read, the assignment is redundant and can be removed.
Quoted 8 lines
Quoted 6 lines
Cleans up clang-scan warning:
fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is never read [deadcode.DeadStores]dentry = ERR_PTR(ret);Signed-off-by Colin Ian King <[email protected]>No need to initalized "int ret =
-ENOMEM;" either.
Thanks for the report.
Both came in when I copied nfsd_mkdir. I'll clean them up.
--
Chuck Lever