memcmp.3: wfix
PATCH 1/1 memcmp.3: wfix
--- man3/memcmp.3 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
man3/memcmp.3 +1 -1
@@ -73,7 +73,7 @@ Instead, a function that performs comparisons in constant time is required. Some operating systems provide such a function (e.g., NetBSD's .BR consttime_memequal ()), but no such function is specified in POSIX. -On Linux, it may be necessary to implement such a function oneself. +On Linux, it may be necessary to implement such a function yourself. .SH SEE ALSO .BR bstring (3), .BR strcasecmp (3),
Signature · 1 line
2.39.1
man3/memcmp.3 Instead, a function that performs comparisons in constant time is required. · line 76
Quoted 2 lines · Tom Schwindl
man3/memcmp.3 +1
-1-On Linux, it may be necessary to implement such a function oneself. +On Linux, it may be necessary to implement such a function yourself.
The existing language is sound. What is the motivation for the change?
Regards,
Branden
Quoted 8 lines · G. Branden Robinson
man3/memcmp.3 Instead, a function that performs comparisons in constant time is required. · line 76
Quoted 2 lines · Tom Schwindl
man3/memcmp.3 +1
-1-On Linux, it may be necessary to implement such a function oneself. +On Linux, it may be necessary to implement such a function yourself.The existing language is sound. What is the motivation for the change?
Regards,
Branden
From a formal perspective it's probably fine. But as a reader, I think it sounds wrong. Or at least strange. That may be because I'm not a native speaker, but neither is the majority of the manpage readers.
I simply think that "yourself" sounds better in this context. That's also the reason for this patch. I've read the manpage and hesitated for a short moment which, for me, indicates a poor choice of words. A grep -i -r oneself also only yields a single result, this manpage.
Signature · 2 lines
Best Regards, Tom Schwindl
Hi Tom,
Quoted 10 lines · Tom Schwindl
Quoted 8 lines · G. Branden Robinson
man3/memcmp.3 Instead, a function that performs comparisons in constant time is required. · line 76
Quoted 2 lines · Tom Schwindl
man3/memcmp.3 +1
-1-On Linux, it may be necessary to implement such a function oneself. +On Linux, it may be necessary to implement such a function yourself.The existing language is sound. What is the motivation for the change?
Regards,
Branden
Quoted 7 lines
From a formal perspective it's probably fine. But as a reader, I think it sounds wrong. Or at least strange. That may be because I'm not a native speaker, but neither is the majority of the manpage readers.
I simply think that "yourself" sounds better in this context. That's also the reason for this patch. I've read the manpage and hesitated for a short moment which, for me, indicates a poor choice of words. Agrep -i -r oneselfalso only yields a single result, this manpage.
To me, the existing text reads fine. Maybe it's because in my language (Spanish), there's a similar expression for oneself, which may not exist in other languages?
I'd keep it as it, unless I see more similar reports. Anyway, thanks for the report!
Cheers,
Alex
Quoted 1 line
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
* Tom Schwindl <[email protected]>, 2023-02-15 13:07:
Quoted 1 line
-On Linux, it may be necessary to implement such a function oneself.
This sounds awkward to me too.
Quoted 1 line
+On Linux, it may be necessary to implement such a function yourself.
This is better, but I'd use active voice here:
On Linux, you may need to implement such a function yourself.
(I'm not a native speaker.)
Signature · 1 line
Jakub Wilk
Hi Jakub,
Quoted 10 lines · Jakub Wilk
* Tom Schwindl <[email protected]>, 2023-02-15 13:07:
Quoted 1 line
-On Linux, it may be necessary to implement such a function oneself.
This sounds awkward to me too.
Quoted 1 line
+On Linux, it may be necessary to implement such a function yourself.
This is better, but I'd use active voice here:
On Linux, you may need to implement such a function yourself.
Seems reasonable. By using active voice, you make it more personal, and "yourself" sounds more appropriate than "oneself".
Would any of you please send a patch?
Thanks for the reports!
Cheers,
Alex
Quoted 3 lines
(I'm not a native speaker.)
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5