Skip to contentSkip to conversation

arm64: dts: sc8280xp-crd: fix external display 'data-lanes'

PATCH In review Johan Hovold 2 participants 3 messages Feb 15, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: sc8280xp-crd: fix external display 'data-lanes'

The 'data-lanes' property belongs in the controller node but was erroneously moved to the endpoint nodes in the last revision of the external display series:

[drm] Invalid property "data-lanes", default max DP lanes = 4

Fixes bc9a747ae91f ("arm64: dts: qcom: sc8280xp-crd: Introduce pmic_glink")
---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +4 -2
index 0c3bdd3cdb9e..db6eb19d0da7 100644
@@ -379,20 +379,22 @@ &mdss0 {
 };
 
 &mdss0_dp0 {
+	data-lanes = <0 1>;
+
 	status = "okay";
 };
 
 &mdss0_dp0_out {
-	data-lanes = <0 1>;
 	remote-endpoint = <&pmic_glink_con0_ss>;
 };
 
 &mdss0_dp1 {
+	data-lanes = <0 1>;
+
 	status = "okay";
 };
 
 &mdss0_dp1_out {
-	data-lanes = <0 1>;
 	remote-endpoint = <&pmic_glink_con1_ss>;
 };
 
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 arm64: dts: sc8280xp-x13s: fix external display 'data-lanes'

The 'data-lanes' property belongs in the controller node but was erroneously moved to the endpoint nodes in the last revision of the external display series:

[drm] Invalid property "data-lanes", default max DP lanes = 4

Fixes 8fcff430faee ("arm64: dts: qcom: sc8280xp-x13s: Enable external display")
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +4 -2
index 918be6728baa..d52d49a82ada 100644
@@ -491,20 +491,22 @@ &mdss0 {
 };
 
 &mdss0_dp0 {
+	data-lanes = <0 1>;
+
 	status = "okay";
 };
 
 &mdss0_dp0_out {
-	data-lanes = <0 1>;
 	remote-endpoint = <&pmic_glink_con0_ss>;
 };
 
 &mdss0_dp1 {
+	data-lanes = <0 1>;
+
 	status = "okay";
 };
 
 &mdss0_dp1_out {
-	data-lanes = <0 1>;
 	remote-endpoint = <&pmic_glink_con1_ss>;
 };
 
Signature · 1 line
2.39.2
#2 lore raw
In reply to Johan Hovold
Quoted 9 lines · Johan Hovold

The 'data-lanes' property belongs in the controller node but was erroneously moved to the endpoint nodes in the last revision of the external display series:

[drm] Invalid property "data-lanes", default max DP lanes = 4

Fixes bc9a747ae91f ("arm64: dts: qcom: sc8280xp-crd: Introduce pmic_glink")

---

Please disregard these patches which are only needed for 6.2 backports of the above mentioned series.

Sorry about the noise.

Johan