Skip to contentSkip to conversation

changelog: Fix missing reference to driver notifications

PATCH In review Parav Pandit 3 participants 4 messages Feb 16, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 changelog: Fix missing reference to driver notifications

Cited commit in fixes tag missed to update the reference to drivers notifications section in past change log.
Fix the reference.

Fixes be2ce1ee17e0 ("content.tex Fix Driver notifications label")
---
 cl-os.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cl-os.tex +1 -1
index 5ae8a7b..a7364b7 100644
@@ -254,7 +254,7 @@
 
 Signed-off-by: Michael S. Tsirkin <[email protected]>
 
-See \ref{sec:Virtqueues / Driver notifications}.
+See \ref{sec:Basic Facilities of a Virtio Device / Driver notifications}.
  } \\
 \hline
 8f2c4e03eae8 & 27 Oct 2019 & Eugenio Pérez & { block: Add multiqueue
Signature · 1 line
2.26.2
#1 lore raw
Quoted 9 lines · Parav Pandit

Cited commit in fixes tag missed to update the reference to drivers notifications section in past change log.
Fix the reference.

Fixes be2ce1ee17e0 ("content.tex Fix Driver notifications label")
---
 cl-os.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does it really make sense to patch the changelog? This is about the 1.1->1.2 changes, and I'd assume it is only relevant for the released 1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.

[Speaking of the 1.3 release, we really should be planning for it. Maybe target June or so, with a freeze in April?]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

#2 lore raw
Quoted 16 lines

From: Cornelia Huck <[email protected]>
Sent: Thursday, February 16, 2023 3:01 AM

Quoted 9 lines · Parav Pandit

Cited commit in fixes tag missed to update the reference to drivers notifications section in past change log.
Fix the reference.

Fixes be2ce1ee17e0 ("content.tex Fix Driver notifications label")
---
 cl-os.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines

Does it really make sense to patch the changelog? This is about the 1.1->1.2 changes, and I'd assume it is only relevant for the released 1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.

Right. I got it.
It should be fine to drop this patch.
I took a blind scan to make sure all the previous links exists now. It isn't necessary from 1.2 to 1.3 as those entries will be removed as you say.

Quoted 2 lines

[Speaking of the 1.3 release, we really should be planning for it. Maybe target June or so, with a freeze in April?]

Very good point. Yes.
Not fully familiar yet, if its June end, may be May is alright too depending on changes in coming months. I am sure you and Michael are better place to make this call.

#3 lore raw
Quoted 16 lines · Parav Pandit
Quoted 16 lines

From: Cornelia Huck <[email protected]>
Sent: Thursday, February 16, 2023 3:01 AM

Quoted 9 lines · Parav Pandit

Cited commit in fixes tag missed to update the reference to drivers notifications section in past change log.
Fix the reference.

Fixes be2ce1ee17e0 ("content.tex Fix Driver notifications label")
---
 cl-os.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 4 lines

Does it really make sense to patch the changelog? This is about the 1.1->1.2 changes, and I'd assume it is only relevant for the released 1.2 spec. We'll replace the changelog anyway when we do the 1.3 release.

Right. I got it.
It should be fine to drop this patch.
I took a blind scan to make sure all the previous links exists now. It isn't necessary from 1.2 to 1.3 as those entries will be removed as you say.

Right just post a patch to drop all of cl-os.tex.

Quoted 5 lines
Quoted 2 lines

[Speaking of the 1.3 release, we really should be planning for it. Maybe target June or so, with a freeze in April?]

Very good point. Yes.
Not fully familiar yet, if its June end, may be May is alright too depending on changes in coming months. I am sure you and Michael are better place to make this call.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/