spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe()
Subsystems (2)
PATCH 1/1 spi: bcm63xx-hsspi: fix error return code in bcmbca_hsspi_probe()
Set the error code when sysfs_create_group() fails in bcmbca_hsspi_probe().
Fixes 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")
Signed-off-by Yang Yingliang <[email protected]>
--- drivers/spi/spi-bcm63xx-hsspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-bcm63xx-hsspi.c +2 -1
@@ -849,7 +849,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)pm_runtime_enable (&pdev->dev); -if (sysfs_create_group (&pdev->dev.kobj, &bcm63xx_hsspi_group)) { + ret =sysfs_create_group (&pdev->dev.kobj, &bcm63xx_hsspi_group); +if (ret) {dev_err (&pdev->dev,"couldn't register sysfs group\n" ); goto out_pm_disable; }
Signature · 1 line
2.25.1
William Zhang
maintainerHi Yingliang,
Quoted 14 lines · Yang Yingliang
Set the error code when
sysfs_create_group()fails inbcmbca_hsspi_probe().Fixes 50a6620dd1fb ("spi: bcm63xx-hsspi: Add polling mode support")Signed-off-by Yang Yingliang <[email protected]>--- drivers/spi/spi-bcm63xx-hsspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/spi/spi-bcm63xx-hsspi.c +0
-0
drivers/spi/spi-bcm63xx-hsspi.c static int bcm63xx_hsspi_probe(struct platform_device *pdev) · line 856
Quoted 9 lines
drivers/spi/spi-bcm63xx-hsspi.c +2
-1@@ -849,7 +849,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)pm_runtime_enable (&pdev->dev); -if (sysfs_create_group (&pdev->dev.kobj, &bcm63xx_hsspi_group)) { + ret =sysfs_create_group (&pdev->dev.kobj, &bcm63xx_hsspi_group); +if (ret) {dev_err (&pdev->dev,"couldn't register sysfs group\n" ); goto out_pm_disable; }
Thanks for the patch but this issue was previously fixed with this patch: https://lore.kernel.org/all/Y+zmoGH6LubPhiI0@kili/